From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: "Campin, Mike" <mike.campin@intel.com> Cc: Jason Gunthorpe <jgg@nvidia.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, Christoph Hellwig <hch@infradead.org>, "Tian, Kevin" <kevin.tian@intel.com>, "Luck, Tony" <tony.luck@intel.com>, "Jiang, Dave" <dave.jiang@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, Thomas Gleixner <tglx@linutronix.de>, jacob.jun.pan@linux.intel.com Subject: Re: [RFC 0/7] Support in-kernel DMA with PASID and SVA Date: Thu, 30 Sep 2021 08:21:21 -0700 [thread overview] Message-ID: <20210930082121.444299be@jacob-builder> (raw) In-Reply-To: <CO1PR11MB5153C703BC0E0112CE7F65B2F3AA9@CO1PR11MB5153.namprd11.prod.outlook.com> Hi Mike, On Thu, 30 Sep 2021 14:22:34 +0000, "Campin, Mike" <mike.campin@intel.com> wrote: > I need support for mixed user PASID, kernel PASID and non-PASID use cases > in the driver. > This specific RFC is for kernel PASID only. User PASID native use is supported under SVA lib kernel API and /dev/uacce UAPI or driver specific char dev. Guest PASID is being developed under the new /dev/iommu framework. Non-PASID kernel use should be under DMA API unchanged from the driver's POV. In fact, this proposal will map non-PASID and PASID DMA identically. Thanks, Jacob > -----Original Message----- > From: Jason Gunthorpe <jgg@nvidia.com> > Sent: Wednesday, September 29, 2021 4:43 PM > To: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: iommu@lists.linux-foundation.org; LKML > <linux-kernel@vger.kernel.org>; Joerg Roedel <joro@8bytes.org>; Christoph > Hellwig <hch@infradead.org>; Tian, Kevin <kevin.tian@intel.com>; Luck, > Tony <tony.luck@intel.com>; Jiang, Dave <dave.jiang@intel.com>; Raj, > Ashok <ashok.raj@intel.com>; Kumar, Sanjay K <sanjay.k.kumar@intel.com>; > Campin, Mike <mike.campin@intel.com>; Thomas Gleixner > <tglx@linutronix.de> Subject: Re: [RFC 0/7] Support in-kernel DMA with > PASID and SVA > > On Wed, Sep 29, 2021 at 03:57:20PM -0700, Jacob Pan wrote: > > Hi Jason, > > > > On Wed, 29 Sep 2021 16:39:53 -0300, Jason Gunthorpe <jgg@nvidia.com> > > wrote: > > > On Wed, Sep 29, 2021 at 12:37:19PM -0700, Jacob Pan wrote: > > > > > > > For #2, it seems we can store the kernel PASID in struct device. > > > > This will preserve the DMA API interface while making it PASID > > > > capable. Essentially, each PASID capable device would have two > > > > special global > > > > PASIDs: > > > > - PASID 0 for DMA request w/o PASID, aka RID2PASID > > > > - PASID 1 (randomly selected) for in-kernel DMA request w/ > > > > PASID > > > > > > This seems reasonable, I had the same thought. Basically just have > > > the driver issue some trivial call: > > > pci_enable_pasid_dma(pdev, &pasid) > > That would work, but I guess it needs to be an iommu_ call instead of > > pci_? > > Which ever makes sense.. The API should take in a struct pci_device and > return a PCI PASID - at least as a wrapper around a more generic immu api. > > > I think your suggestion is more precise, in case the driver does not > > want to do DMA w/ PASID, we can do less IOTLB flush (PASID 0 only). > > Since it is odd, and it may create overhead, I would do it only when > asked to do it > > > > Having multiple RID's pointing at the same IO page table is > > > something we expect iommufd to require so the whole thing should > > > ideally fall out naturally. > > > That would be the equivalent of attaching multiple devices to the same > > IOMMU domain. right? > > Effectively.. > > Jason Thanks, Jacob
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: "Campin, Mike" <mike.campin@intel.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, "Luck, Tony" <tony.luck@intel.com>, "Jiang, Dave" <dave.jiang@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, LKML <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, Jason Gunthorpe <jgg@nvidia.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [RFC 0/7] Support in-kernel DMA with PASID and SVA Date: Thu, 30 Sep 2021 08:21:21 -0700 [thread overview] Message-ID: <20210930082121.444299be@jacob-builder> (raw) In-Reply-To: <CO1PR11MB5153C703BC0E0112CE7F65B2F3AA9@CO1PR11MB5153.namprd11.prod.outlook.com> Hi Mike, On Thu, 30 Sep 2021 14:22:34 +0000, "Campin, Mike" <mike.campin@intel.com> wrote: > I need support for mixed user PASID, kernel PASID and non-PASID use cases > in the driver. > This specific RFC is for kernel PASID only. User PASID native use is supported under SVA lib kernel API and /dev/uacce UAPI or driver specific char dev. Guest PASID is being developed under the new /dev/iommu framework. Non-PASID kernel use should be under DMA API unchanged from the driver's POV. In fact, this proposal will map non-PASID and PASID DMA identically. Thanks, Jacob > -----Original Message----- > From: Jason Gunthorpe <jgg@nvidia.com> > Sent: Wednesday, September 29, 2021 4:43 PM > To: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: iommu@lists.linux-foundation.org; LKML > <linux-kernel@vger.kernel.org>; Joerg Roedel <joro@8bytes.org>; Christoph > Hellwig <hch@infradead.org>; Tian, Kevin <kevin.tian@intel.com>; Luck, > Tony <tony.luck@intel.com>; Jiang, Dave <dave.jiang@intel.com>; Raj, > Ashok <ashok.raj@intel.com>; Kumar, Sanjay K <sanjay.k.kumar@intel.com>; > Campin, Mike <mike.campin@intel.com>; Thomas Gleixner > <tglx@linutronix.de> Subject: Re: [RFC 0/7] Support in-kernel DMA with > PASID and SVA > > On Wed, Sep 29, 2021 at 03:57:20PM -0700, Jacob Pan wrote: > > Hi Jason, > > > > On Wed, 29 Sep 2021 16:39:53 -0300, Jason Gunthorpe <jgg@nvidia.com> > > wrote: > > > On Wed, Sep 29, 2021 at 12:37:19PM -0700, Jacob Pan wrote: > > > > > > > For #2, it seems we can store the kernel PASID in struct device. > > > > This will preserve the DMA API interface while making it PASID > > > > capable. Essentially, each PASID capable device would have two > > > > special global > > > > PASIDs: > > > > - PASID 0 for DMA request w/o PASID, aka RID2PASID > > > > - PASID 1 (randomly selected) for in-kernel DMA request w/ > > > > PASID > > > > > > This seems reasonable, I had the same thought. Basically just have > > > the driver issue some trivial call: > > > pci_enable_pasid_dma(pdev, &pasid) > > That would work, but I guess it needs to be an iommu_ call instead of > > pci_? > > Which ever makes sense.. The API should take in a struct pci_device and > return a PCI PASID - at least as a wrapper around a more generic immu api. > > > I think your suggestion is more precise, in case the driver does not > > want to do DMA w/ PASID, we can do less IOTLB flush (PASID 0 only). > > Since it is odd, and it may create overhead, I would do it only when > asked to do it > > > > Having multiple RID's pointing at the same IO page table is > > > something we expect iommufd to require so the whole thing should > > > ideally fall out naturally. > > > That would be the equivalent of attaching multiple devices to the same > > IOMMU domain. right? > > Effectively.. > > Jason Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-09-30 15:17 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-21 20:29 [RFC 0/7] Support in-kernel DMA with PASID and SVA Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 1/7] ioasid: reserve special PASID for in-kernel DMA Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 2/7] dma-iommu: Add API for DMA request with PASID Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 3/7] iommu/vt-d: Add DMA w/ PASID support for PA and IOVA Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 4/7] dma-iommu: Add support for DMA w/ PASID in KVA Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 5/7] iommu/vt-d: Add support for KVA PASID mode Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 6/7] iommu: Add KVA map API Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-21 20:29 ` [RFC 7/7] dma/idxd: Use dma-iommu PASID API instead of SVA lib Jacob Pan 2021-09-21 20:29 ` Jacob Pan 2021-09-22 17:04 ` [RFC 0/7] Support in-kernel DMA with PASID and SVA Jason Gunthorpe 2021-09-22 17:04 ` Jason Gunthorpe via iommu 2021-09-29 19:37 ` Jacob Pan 2021-09-29 19:37 ` Jacob Pan 2021-09-29 19:39 ` Jason Gunthorpe 2021-09-29 19:39 ` Jason Gunthorpe via iommu 2021-09-29 22:57 ` Jacob Pan 2021-09-29 22:57 ` Jacob Pan 2021-09-29 23:43 ` Jason Gunthorpe 2021-09-29 23:43 ` Jason Gunthorpe via iommu 2021-09-30 14:22 ` Campin, Mike 2021-09-30 14:22 ` Campin, Mike 2021-09-30 15:21 ` Jacob Pan [this message] 2021-09-30 15:21 ` Jacob Pan 2021-10-01 12:24 ` Barry Song 2021-10-01 12:24 ` Barry Song 2021-10-01 12:36 ` Jason Gunthorpe 2021-10-01 12:36 ` Jason Gunthorpe via iommu 2021-10-01 12:45 ` Barry Song 2021-10-01 12:45 ` Barry Song 2021-10-04 16:40 ` Jacob Pan 2021-10-04 16:40 ` Jacob Pan 2021-10-04 18:21 ` Jason Gunthorpe 2021-10-04 18:21 ` Jason Gunthorpe via iommu 2021-10-07 5:43 ` Barry Song 2021-10-07 5:43 ` Barry Song 2021-10-07 11:32 ` Jason Gunthorpe 2021-10-07 11:32 ` Jason Gunthorpe via iommu 2021-10-07 11:54 ` Barry Song 2021-10-07 11:54 ` Barry Song 2021-10-07 11:59 ` Jason Gunthorpe 2021-10-07 11:59 ` Jason Gunthorpe via iommu 2021-10-07 17:50 ` Jacob Pan 2021-10-07 17:50 ` Jacob Pan 2021-10-07 17:48 ` Jason Gunthorpe 2021-10-07 17:48 ` Jason Gunthorpe via iommu 2021-10-07 18:08 ` Jacob Pan 2021-10-07 18:08 ` Jacob Pan 2021-10-07 19:11 ` Jacob Pan 2021-10-07 19:11 ` Jacob Pan 2021-10-07 19:10 ` Jason Gunthorpe 2021-10-07 19:10 ` Jason Gunthorpe via iommu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210930082121.444299be@jacob-builder \ --to=jacob.jun.pan@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=dave.jiang@intel.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mike.campin@intel.com \ --cc=sanjay.k.kumar@intel.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.