* [meta-virtualization][PATCH] oath: inherit pkgconfig
@ 2021-09-30 8:49 Martin Jansa
2021-10-01 2:36 ` Bruce Ashfield
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2021-09-30 8:49 UTC (permalink / raw)
To: meta-virtualization; +Cc: Martin Jansa
* Newer oe-core doesn't pull many default dependencies anymore:
https://lists.openembedded.org/g/openembedded-core/message/156185
add explicit dependency on pkgconfig through pkgconfig.bbclass as
we're using it here.
* fixes:
../../oath-toolkit-2.6.2/liboath/configure: line 30585: PKG_PROG_PKG_CONFIG: command not found
checking for gtk-doc... ../../oath-toolkit-2.6.2/liboath/configure: line 30595: syntax error near unexpected token `$gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no'
../../oath-toolkit-2.6.2/liboath/configure: line 30595: ` PKG_CHECK_EXISTS($gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no)'
configure: error: ../../oath-toolkit-2.6.2/liboath/configure failed for liboath
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
recipes-extended/oath/oath_2.6.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-extended/oath/oath_2.6.2.bb b/recipes-extended/oath/oath_2.6.2.bb
index f423044..d568ec0 100644
--- a/recipes-extended/oath/oath_2.6.2.bb
+++ b/recipes-extended/oath/oath_2.6.2.bb
@@ -12,7 +12,7 @@ S = "${WORKDIR}/${BPN}-toolkit-${PV}"
SRC_URI[md5sum] = "4a05cd4768764843bd5493609a6bdb17"
SRC_URI[sha256sum] = "b03446fa4b549af5ebe4d35d7aba51163442d255660558cd861ebce536824aa0"
-inherit autotools
+inherit autotools pkgconfig
# Specify any options you want to pass to the configure script using EXTRA_OECONF:
EXTRA_OECONF = ""
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-virtualization][PATCH] oath: inherit pkgconfig
2021-09-30 8:49 [meta-virtualization][PATCH] oath: inherit pkgconfig Martin Jansa
@ 2021-10-01 2:36 ` Bruce Ashfield
2021-10-01 9:01 ` Martin Jansa
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Ashfield @ 2021-10-01 2:36 UTC (permalink / raw)
To: Martin Jansa; +Cc: meta-virtualization
I've been watching for these as well, but haven't gotten to doing
my 'all' builds to trigger them.
Out of curiosity, what level of coverage do you end up with on
the meta-virt layers ? I'm just trying to scope out how many more
of these may be lurking :D
I've grabbed this, and will push it shortly.
Bruce
In message: [meta-virtualization][PATCH] oath: inherit pkgconfig
on 30/09/2021 Martin Jansa wrote:
> * Newer oe-core doesn't pull many default dependencies anymore:
> https://lists.openembedded.org/g/openembedded-core/message/156185
> add explicit dependency on pkgconfig through pkgconfig.bbclass as
> we're using it here.
>
> * fixes:
> ../../oath-toolkit-2.6.2/liboath/configure: line 30585: PKG_PROG_PKG_CONFIG: command not found
> checking for gtk-doc... ../../oath-toolkit-2.6.2/liboath/configure: line 30595: syntax error near unexpected token `$gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no'
> ../../oath-toolkit-2.6.2/liboath/configure: line 30595: ` PKG_CHECK_EXISTS($gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no)'
> configure: error: ../../oath-toolkit-2.6.2/liboath/configure failed for liboath
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> recipes-extended/oath/oath_2.6.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/oath/oath_2.6.2.bb b/recipes-extended/oath/oath_2.6.2.bb
> index f423044..d568ec0 100644
> --- a/recipes-extended/oath/oath_2.6.2.bb
> +++ b/recipes-extended/oath/oath_2.6.2.bb
> @@ -12,7 +12,7 @@ S = "${WORKDIR}/${BPN}-toolkit-${PV}"
> SRC_URI[md5sum] = "4a05cd4768764843bd5493609a6bdb17"
> SRC_URI[sha256sum] = "b03446fa4b549af5ebe4d35d7aba51163442d255660558cd861ebce536824aa0"
>
> -inherit autotools
> +inherit autotools pkgconfig
>
> # Specify any options you want to pass to the configure script using EXTRA_OECONF:
> EXTRA_OECONF = ""
> --
> 2.32.0
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-virtualization][PATCH] oath: inherit pkgconfig
2021-10-01 2:36 ` Bruce Ashfield
@ 2021-10-01 9:01 ` Martin Jansa
0 siblings, 0 replies; 3+ messages in thread
From: Martin Jansa @ 2021-10-01 9:01 UTC (permalink / raw)
To: Bruce Ashfield, Khem Raj, Richard Purdie; +Cc: meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 3188 bytes --]
I did "bitbake world" build with webOS OSE
https://github.com/shr-project/build-webos/tree/honister with it's default
DISTRO_FEATUREs and PNBLACKLIST, so not all of meta-virtualization was
built, but most of it and this was the only failed task from there
(surprisingly).
But be aware that yesterday I also notice once strange issue, that a recipe
"collada-dom" started to shows textrel QA issue and it was actually caused
by pkgconfig not being available where do_configure "silently" failed to
find system bzip2 and minizip due to missing pkgconfig and built own
version instead which lead to this textrel QA issue.
There might be many more recipes like this, which build something
differently without pkgconfig evailable, without triggering any QA check
like in this case. It might be useful to compare at least buildhistory
results with and without the layer.conf change to see what else was changed
unexpectedly.
+ RP and Khem (maybe I should report this on the layer.conf change review
instead..)
On Fri, Oct 1, 2021 at 4:36 AM Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:
> I've been watching for these as well, but haven't gotten to doing
> my 'all' builds to trigger them.
>
> Out of curiosity, what level of coverage do you end up with on
> the meta-virt layers ? I'm just trying to scope out how many more
> of these may be lurking :D
>
> I've grabbed this, and will push it shortly.
>
> Bruce
>
> In message: [meta-virtualization][PATCH] oath: inherit pkgconfig
> on 30/09/2021 Martin Jansa wrote:
>
> > * Newer oe-core doesn't pull many default dependencies anymore:
> > https://lists.openembedded.org/g/openembedded-core/message/156185
> > add explicit dependency on pkgconfig through pkgconfig.bbclass as
> > we're using it here.
> >
> > * fixes:
> > ../../oath-toolkit-2.6.2/liboath/configure: line 30585:
> PKG_PROG_PKG_CONFIG: command not found
> > checking for gtk-doc... ../../oath-toolkit-2.6.2/liboath/configure:
> line 30595: syntax error near unexpected token
> `$gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no'
> > ../../oath-toolkit-2.6.2/liboath/configure: line 30595: `
> PKG_CHECK_EXISTS($gtk_doc_requires,have_gtk_doc=yes,have_gtk_doc=no)'
> > configure: error: ../../oath-toolkit-2.6.2/liboath/configure failed
> for liboath
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > recipes-extended/oath/oath_2.6.2.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-extended/oath/oath_2.6.2.bb
> b/recipes-extended/oath/oath_2.6.2.bb
> > index f423044..d568ec0 100644
> > --- a/recipes-extended/oath/oath_2.6.2.bb
> > +++ b/recipes-extended/oath/oath_2.6.2.bb
> > @@ -12,7 +12,7 @@ S = "${WORKDIR}/${BPN}-toolkit-${PV}"
> > SRC_URI[md5sum] = "4a05cd4768764843bd5493609a6bdb17"
> > SRC_URI[sha256sum] =
> "b03446fa4b549af5ebe4d35d7aba51163442d255660558cd861ebce536824aa0"
> >
> > -inherit autotools
> > +inherit autotools pkgconfig
> >
> > # Specify any options you want to pass to the configure script using
> EXTRA_OECONF:
> > EXTRA_OECONF = ""
> > --
> > 2.32.0
> >
>
> >
> >
> >
>
>
[-- Attachment #2: Type: text/html, Size: 4451 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-01 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 8:49 [meta-virtualization][PATCH] oath: inherit pkgconfig Martin Jansa
2021-10-01 2:36 ` Bruce Ashfield
2021-10-01 9:01 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.