* [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default
@ 2021-09-30 10:29 derek.fang
2021-09-30 10:29 ` [PATCH 2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug derek.fang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: derek.fang @ 2021-09-30 10:29 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, Derek Fang, shumingf, flove
From: Derek Fang <derek.fang@realtek.com>
This reg is for SW reset.
It shouldn't have default value, so remove.
Signed-off-by: Derek Fang <derek.fang@realtek.com>
---
sound/soc/codecs/rt5682s.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c
index d3e965b2e707..2b229c074a31 100644
--- a/sound/soc/codecs/rt5682s.c
+++ b/sound/soc/codecs/rt5682s.c
@@ -72,7 +72,6 @@ static void rt5682s_apply_patch_list(struct rt5682s_priv *rt5682s,
}
const struct reg_default rt5682s_reg[] = {
- {0x0000, 0x0001},
{0x0002, 0x8080},
{0x0003, 0x0001},
{0x0005, 0x0000},
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug
2021-09-30 10:29 [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default derek.fang
@ 2021-09-30 10:29 ` derek.fang
2021-09-30 10:29 ` [PATCH 3/3] ASoC: rt5682s: Revise the macro RT5682S_PLLB_SRC_MASK derek.fang
2021-09-30 14:58 ` [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: derek.fang @ 2021-09-30 10:29 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, Derek Fang, shumingf, flove
From: Derek Fang <derek.fang@realtek.com>
It could observe the debug messages more clearly by using dev_dbg.
Signed-off-by: Derek Fang <derek.fang@realtek.com>
---
sound/soc/codecs/rt5682s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c
index 2b229c074a31..122adeb7beb1 100644
--- a/sound/soc/codecs/rt5682s.c
+++ b/sound/soc/codecs/rt5682s.c
@@ -768,7 +768,7 @@ static int rt5682s_headset_detect(struct snd_soc_component *component, int jack_
count++;
} while (val == 0 && count < 50);
- pr_debug("%s, val=%d, count=%d\n", __func__, val, count);
+ dev_dbg(component->dev, "%s, val=%d, count=%d\n", __func__, val, count);
switch (val) {
case 0x1:
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ASoC: rt5682s: Revise the macro RT5682S_PLLB_SRC_MASK
2021-09-30 10:29 [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default derek.fang
2021-09-30 10:29 ` [PATCH 2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug derek.fang
@ 2021-09-30 10:29 ` derek.fang
2021-09-30 14:58 ` [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: derek.fang @ 2021-09-30 10:29 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, Derek Fang, shumingf, flove
From: Derek Fang <derek.fang@realtek.com>
Revise the macro RT5682S_PLLB_SRC_MASK to 0x1
because the mux is only two-source.
Signed-off-by: Derek Fang <derek.fang@realtek.com>
---
sound/soc/codecs/rt5682s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h
index 7c755e5efb81..55f1febb81e9 100644
--- a/sound/soc/codecs/rt5682s.h
+++ b/sound/soc/codecs/rt5682s.h
@@ -1094,7 +1094,7 @@
#define RT5682S_PLLA_K_BP_SFT 6
/* PLL M/N/K Code Control 7 (0x009e) */
-#define RT5682S_PLLB_SRC_MASK (0x3 << 0)
+#define RT5682S_PLLB_SRC_MASK (0x1)
#define RT5682S_PLLB_SRC_DFIN (0x1)
#define RT5682S_PLLB_SRC_PLLA (0x0)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default
2021-09-30 10:29 [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default derek.fang
2021-09-30 10:29 ` [PATCH 2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug derek.fang
2021-09-30 10:29 ` [PATCH 3/3] ASoC: rt5682s: Revise the macro RT5682S_PLLB_SRC_MASK derek.fang
@ 2021-09-30 14:58 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-09-30 14:58 UTC (permalink / raw)
To: derek.fang, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, Mark Brown, shumingf, flove
On Thu, 30 Sep 2021 18:29:26 +0800, derek.fang@realtek.com wrote:
> From: Derek Fang <derek.fang@realtek.com>
>
> This reg is for SW reset.
> It shouldn't have default value, so remove.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default
commit: 67e068ec4596dbaac5f45669ce8373dfe61a2411
[2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug
commit: 087330c642a968be8b1b9f2df6fb87b217f17372
[3/3] ASoC: rt5682s: Revise the macro RT5682S_PLLB_SRC_MASK
commit: 853cb0be0eb2dba3e016b4f1d9fdae91065930c6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-30 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 10:29 [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default derek.fang
2021-09-30 10:29 ` [PATCH 2/3] ASoC: rt5682s: Use dev_dbg instead of pr_debug derek.fang
2021-09-30 10:29 ` [PATCH 3/3] ASoC: rt5682s: Revise the macro RT5682S_PLLB_SRC_MASK derek.fang
2021-09-30 14:58 ` [PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.