* [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc
@ 2021-09-28 18:35 Randy Dunlap
2021-09-28 18:57 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2021-09-28 18:35 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Sebastian Reichel,
Aditya Srivastava, Pavel Machek
Fix build warnings from the kernel test robot:
drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Block until pending data transfers have completed.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
v2: Drop #Cc: Kai Vehmanen <kai.vehmanen@nokia.com> [bounce]
Add Pavel's Ack.
drivers/hsi/clients/cmt_speech.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20210928.orig/drivers/hsi/clients/cmt_speech.c
+++ linux-next-20210928/drivers/hsi/clients/cmt_speech.c
@@ -827,7 +827,7 @@ static int check_buf_params(struct cs_hs
return r;
}
-/**
+/*
* Block until pending data transfers have completed.
*/
static int cs_hsi_data_sync(struct cs_hsi_iface *hi)
@@ -850,7 +850,7 @@ static int cs_hsi_data_sync(struct cs_hs
r = -ERESTARTSYS;
goto out;
}
- /**
+ /*
* prepare_to_wait must be called with hi->lock held
* so that callbacks can check for waitqueue_active()
*/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc
2021-09-28 18:35 [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc Randy Dunlap
@ 2021-09-28 18:57 ` Pavel Machek
2021-09-28 19:52 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2021-09-28 18:57 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Sebastian Reichel, Aditya Srivastava
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
Hi!
> Fix build warnings from the kernel test robot:
>
> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Block until pending data transfers have completed.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
If noone applies it, you may want to send it to akpm, he's often
helpful in pushing similar patches.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc
2021-09-28 18:57 ` Pavel Machek
@ 2021-09-28 19:52 ` Randy Dunlap
2021-09-30 17:01 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2021-09-28 19:52 UTC (permalink / raw)
To: Pavel Machek
Cc: linux-kernel, kernel test robot, Sebastian Reichel, Aditya Srivastava
On 9/28/21 11:57 AM, Pavel Machek wrote:
> Hi!
>
>> Fix build warnings from the kernel test robot:
>>
>> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>> * Block until pending data transfers have completed.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Sebastian Reichel <sre@kernel.org>
>> Cc: Aditya Srivastava <yashsri421@gmail.com>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> If noone applies it, you may want to send it to akpm, he's often
> helpful in pushing similar patches.
Yes, good idea. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc
2021-09-28 19:52 ` Randy Dunlap
@ 2021-09-30 17:01 ` Sebastian Reichel
2021-09-30 18:45 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2021-09-30 17:01 UTC (permalink / raw)
To: Randy Dunlap
Cc: Pavel Machek, linux-kernel, kernel test robot, Aditya Srivastava
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
Hi,
On Tue, Sep 28, 2021 at 12:52:03PM -0700, Randy Dunlap wrote:
> On 9/28/21 11:57 AM, Pavel Machek wrote:
> > Hi!
> >
> > > Fix build warnings from the kernel test robot:
> > >
> > > drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > * Block until pending data transfers have completed.
> > >
> > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Aditya Srivastava <yashsri421@gmail.com>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> >
> > If noone applies it, you may want to send it to akpm, he's often
> > helpful in pushing similar patches.
>
> Yes, good idea. Thanks.
Looks like I missed v1. The patch LGTM and I can apply it to the hsi tree.
If you already sent it to akpm, that's also fine. Not much is happening in
HSI nowadays and it probably will be the only patch for the next cycle.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc
2021-09-30 17:01 ` Sebastian Reichel
@ 2021-09-30 18:45 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-09-30 18:45 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Pavel Machek, linux-kernel, kernel test robot, Aditya Srivastava
On 9/30/21 10:01 AM, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Sep 28, 2021 at 12:52:03PM -0700, Randy Dunlap wrote:
>> On 9/28/21 11:57 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> Fix build warnings from the kernel test robot:
>>>>
>>>> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>>>> * Block until pending data transfers have completed.
>>>>
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Cc: Sebastian Reichel <sre@kernel.org>
>>>> Cc: Aditya Srivastava <yashsri421@gmail.com>
>>>> Acked-by: Pavel Machek <pavel@ucw.cz>
>>>
>>> If noone applies it, you may want to send it to akpm, he's often
>>> helpful in pushing similar patches.
>>
>> Yes, good idea. Thanks.
>
> Looks like I missed v1. The patch LGTM and I can apply it to the hsi tree.
> If you already sent it to akpm, that's also fine. Not much is happening in
> HSI nowadays and it probably will be the only patch for the next cycle.
You go ahead with it, please.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-30 18:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 18:35 [PATCH v2] HSI: cmt_speech: unmark comments as kernel-doc Randy Dunlap
2021-09-28 18:57 ` Pavel Machek
2021-09-28 19:52 ` Randy Dunlap
2021-09-30 17:01 ` Sebastian Reichel
2021-09-30 18:45 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.