[meta-oe][PATCH] gpsd: inherit pkgconfig

[meta-oe][PATCH] gpsd: inherit pkgconfig

[Martin Jansa]

Newer oe-core doesn't pull many default dependencies anymore:
https://lists.openembedded.org/g/openembedded-core/message/156185
add explicit dependency on pkgconfig through pkgconfig.bbclass as
we're using it here.

Fixes:
| Checking pkg-config for dbus-1... no
| Turning off dbus-export support, library not found.
| Checking pkg-config for bluez... no
| Turning off Bluetooth support, library not found.
...
| ERROR: /usr/bin/ncurses5-config should not be used, use an alternative such as pkg-config
| OSError: 'ncurses5-config --libs --cflags' exited 1:
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/gpsd-3.23/SConstruct", line 63:
|     SConscript('SConscript',
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 660:
|     return method(*args, **kw)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 597:
|     return _SConscript(self.fs, *files, **subst_kw)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 285:
|     exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/gpsd-3.23/gpsd-3.23/SConscript", line 1881:
|     cgps = env.Program('clients/cgps', ['clients/cgps.c'],
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 238:
|     return super().__call__(target, source, *args, **kw)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Util.py", line 748:
|     return self.method(*nargs, **kwargs)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Builder.py", line 653:
|     env = env.Override(env_kw)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 622:
|     env.MergeFlags(merges)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 832:
|     args = self.ParseFlags(args)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 815:
|     do_parse(arg)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 662:
|     for t in arg: do_parse(t)
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 667:
|     arg = self.backtick(arg[1:])
|   File "/jenkins/mjansa/build/ose/honister/BUILD/work/qemux86-webos-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 579:
|     raise OSError("'%s' exited %d" % (command, status))
| ERROR: scons build execution failed.

Or on different host it shows better error message:

| Checking pkg-config for dbus-1... (cached) yes
| /bin/sh: 1: pkg-config: not found
| OSError: 'PKG_CONFIG_SYSROOT_DIR="/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot" pkg-config --cflags --libs dbus-1' exited 127:
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/gpsd-3.23/SConstruct", line 63:
|     SConscript('SConscript',
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 660:
|     return method(*args, **kw)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 597:
|     return _SConscript(self.fs, *files, **subst_kw)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Script/SConscript.py", line 285:
|     exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/gpsd-3.23/gpsd-3.23/SConscript", line 1107:
|     config.env.MergeFlags(dbusflags)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 832:
|     args = self.ParseFlags(args)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 815:
|     do_parse(arg)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 662:
|     for t in arg: do_parse(t)
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 667:
|     arg = self.backtick(arg[1:])
|   File "/OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/gpsd/3.23-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/SCons/Environment.py", line 579:
|     raise OSError("'%s' exited %d" % (command, status))
| ERROR: scons build execution failed.

Not sure why this one doesn't show up on CI, I guess some SCons magic.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-navigation/gpsd/gpsd_3.23.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.bb
index aaf7429291..227ddb7848 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.bb
@@ -12,7 +12,7 @@ SRC_URI = "${SAVANNAH_GNU_MIRROR}/${BPN}/${BP}.tar.gz \
 SRC_URI[md5sum] = "b4f96cb01cbc06542b1cb66b3296078d"
 SRC_URI[sha256sum] = "522c2362a7eb2d7ac37eaa1504f12aded1c373479a87ba06cc6795974b567bbc"
 
-inherit scons update-rc.d python3-dir python3native systemd update-alternatives
+inherit scons update-rc.d python3-dir python3native systemd update-alternatives pkgconfig
 
 INITSCRIPT_PACKAGES = "gpsd-conf"
 INITSCRIPT_NAME = "gpsd"
-- 
2.32.0