All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yanling Song <songyl@ramaxel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: <martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] spraid: initial commit of Ramaxel spraid driver
Date: Fri, 1 Oct 2021 01:03:46 +0000	[thread overview]
Message-ID: <20211001010346.2478a8af@songyl> (raw)
In-Reply-To: <481d8f10-f755-29f0-58f3-9838890b0dc6@infradead.org>


Hi Randy,
Thanks for your comments. 
It is National Holiday since today and I'm on a 7-day vacation. My
response may be delayed, Sorry.
 


On Wed, 29 Sep 2021 22:36:14 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Hi,
> 
> On 9/29/21 8:47 PM, Yanling Song wrote:
> > This initial commit contains Ramaxel's spraid module.
> >   
> 
> Does "spraid" mean anything?  <something>  RAID ?

yes, it means Super RAID.

> 
> > Signed-off-by: Yanling Song <songyl@ramaxel.com>
> > ---
> >   Documentation/scsi/spraid.rst                 |   28 +
> >   .../userspace-api/ioctl/ioctl-number.rst      |    2 +
> >   MAINTAINERS                                   |    7 +
> >   drivers/scsi/Kconfig                          |    1 +
> >   drivers/scsi/Makefile                         |    1 +
> >   drivers/scsi/spraid/Kconfig                   |   11 +
> >   drivers/scsi/spraid/Makefile                  |    7 +
> >   drivers/scsi/spraid/spraid.h                  |  656 +++
> >   drivers/scsi/spraid/spraid_main.c             | 3617
> > +++++++++++++++++ 9 files changed, 4330 insertions(+)
> >   create mode 100644 Documentation/scsi/spraid.rst
> >   create mode 100644 drivers/scsi/spraid/Kconfig
> >   create mode 100644 drivers/scsi/spraid/Makefile
> >   create mode 100644 drivers/scsi/spraid/spraid.h
> >   create mode 100644 drivers/scsi/spraid/spraid_main.c
> >   
> 
> > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst
> > b/Documentation/userspace-api/ioctl/ioctl-number.rst index
> > 2e8134059c87..d93dbb680b16 100644 ---
> > a/Documentation/userspace-api/ioctl/ioctl-number.rst +++
> > b/Documentation/userspace-api/ioctl/ioctl-number.rst @@ -169,6
> > +169,8 @@ Code  Seq#    Include
> > File                                           Comments 'M'
> > 00-0F  drivers/video/fsl-diu-fb.h
> > conflict! 'N'   00-1F  drivers/usb/scanner.h 'N'   40-7F
> > drivers/block/nvme.c +'N'   41-42
> > drivers/scsi/spraid_main.c
> > conflict! +'N'   80     drivers/scsi/spraid_main.c 'O'   00-06
> > mtd/ubi-user.h                                          UBI 'P'
> > all    linux/soundcard.h
> > conflict! 'P'   60-6F
> > sound/sscape_ioctl.h                                    conflict!  
> 
> It looks like the above won't apply cleanly: the surrounding lines
> should not be indented any.

Will be fixed in the next version. 

> 
> > diff --git a/drivers/scsi/spraid/Kconfig
> > b/drivers/scsi/spraid/Kconfig new file mode 100644
> > index 000000000000..83962efaab07
> > --- /dev/null
> > +++ b/drivers/scsi/spraid/Kconfig
> > @@ -0,0 +1,11 @@
> > +#
> > +# Ramaxel driver configuration
> > +#
> > +
> > +config RAMAXEL_SPRAID
> > +	tristate "Ramaxel spraid Adapter"
> > +	depends on PCI && SCSI
> > +	depends on ARM64 || X86_64
> > +	default m  
> 
> Not "default m" unless it is needed to boot a system.

This line will be deleted in next version.

> 
> > +	help
> > +	  This driver supports Ramaxel spraid driver.  
> 
> 
> thanks.


  reply	other threads:[~2021-10-01  1:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  3:47 [PATCH] spraid: initial commit of Ramaxel spraid driver Yanling Song
2021-09-30  5:36 ` Randy Dunlap
2021-10-01  1:03   ` Yanling Song [this message]
2021-10-01  4:15 ` Christoph Hellwig
2021-10-08  9:22   ` Yanling Song
2021-10-09  3:58 ` Bart Van Assche
2021-10-09 13:32   ` Yanling Song
2021-10-10  3:52     ` Bart Van Assche
2021-10-11  8:34       ` Yanling Song
2021-10-11 19:40         ` Bart Van Assche
2021-10-12 11:10           ` Yanling Song
2021-10-11 19:54 ` Bart Van Assche
2021-10-12 14:49   ` Yanling Song
2021-10-12 16:59     ` Bart Van Assche
2021-10-13  6:50       ` Yanling Song
2021-10-13 22:00         ` Bart Van Assche
2021-10-15  5:48           ` Yanling Song
2021-10-20  0:33           ` Yanling Song
2021-10-20  3:24             ` Bart Van Assche
2021-11-03  1:43               ` Yanling Song
2021-11-05 13:02               ` Yanling Song
2021-11-05 16:13                 ` Bart Van Assche
2021-11-06  8:30                   ` Yanling Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001010346.2478a8af@songyl \
    --to=songyl@ramaxel.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.