From: Bart Van Assche <bvanassche@acm.org>
To: Yanling Song <songyl@ramaxel.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] spraid: initial commit of Ramaxel spraid driver
Date: Tue, 12 Oct 2021 09:59:30 -0700 [thread overview]
Message-ID: <6cd75c09-8374-7b9b-4ecc-3b3781cbe074@acm.org> (raw)
In-Reply-To: <20211012144906.790579d0@songyl>
On 10/12/21 7:49 AM, Yanling Song wrote:
> On Mon, 11 Oct 2021 12:54:20 -0700
> Bart Van Assche <bvanassche@acm.org> wrote:
>
>> On 9/29/21 20:47, Yanling Song wrote:
>>> +#define SPRAID_IOCTL_RESET_CMD _IOWR('N', 0x80, struct
>>> spraid_passthru_common_cmd) +#define SPRAID_IOCTL_ADMIN_CMD
>>> _IOWR('N', 0x41, struct spraid_passthru_common_cmd)
>>
>> Do these new ioctls provide any functionality that is not yet
>> provided by SG_IO + SG_SCSI_RESET_BUS?
>
> These new ioctls are developed to manage our raid controller by our
> private tools, which has no sg device. so SG_IO cannot work for our
> case.
Why won't an SG device be associated with spraid device nodes? My
understanding is that an SG device is associated with every SCSI device
if CONFIG_CHR_DEV_SG is enabled and also that a bsg device is associated
with every SCSI device if CONFIG_BLK_DEV_BSG is enabled.
Why is it that SG_IO is not sufficient? This is something that should
have been explained in the patch description.
>> Additionally, mixing driver-internal and user space definitions in a
>> single header file is not OK. Definitions of data structures and
>> ioctls that are needed by user space software should occur in a
>> header file in the directory include/uapi/scsi/.
>
> Sounds reasonable. But after checking the directory include/uapi/scsi/,
> there are only several files in it. It is expected that there should be
> many files if developers follow the rule. Do you know why?
If this rule is not followed, that will be a red flag for the SCSI
maintainer and something that will probably delay upstream acceptance of
this patch.
Bart.
next prev parent reply other threads:[~2021-10-12 16:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 3:47 [PATCH] spraid: initial commit of Ramaxel spraid driver Yanling Song
2021-09-30 5:36 ` Randy Dunlap
2021-10-01 1:03 ` Yanling Song
2021-10-01 4:15 ` Christoph Hellwig
2021-10-08 9:22 ` Yanling Song
2021-10-09 3:58 ` Bart Van Assche
2021-10-09 13:32 ` Yanling Song
2021-10-10 3:52 ` Bart Van Assche
2021-10-11 8:34 ` Yanling Song
2021-10-11 19:40 ` Bart Van Assche
2021-10-12 11:10 ` Yanling Song
2021-10-11 19:54 ` Bart Van Assche
2021-10-12 14:49 ` Yanling Song
2021-10-12 16:59 ` Bart Van Assche [this message]
2021-10-13 6:50 ` Yanling Song
2021-10-13 22:00 ` Bart Van Assche
2021-10-15 5:48 ` Yanling Song
2021-10-20 0:33 ` Yanling Song
2021-10-20 3:24 ` Bart Van Assche
2021-11-03 1:43 ` Yanling Song
2021-11-05 13:02 ` Yanling Song
2021-11-05 16:13 ` Bart Van Assche
2021-11-06 8:30 ` Yanling Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd75c09-8374-7b9b-4ecc-3b3781cbe074@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=songyl@ramaxel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.