[Buildroot] [PATCH] package/python-augeas: switch from "depends on" to "select" for augeas dep

[Buildroot] [PATCH] package/python-augeas: switch from "depends on" to "select" for augeas dep

[Thomas Petazzoni]

During the review of the lua-augeas package, it was pointed out that a
"select BR2_PACKAGE_AUGEAS" should be used instead of a "depends on
BR2_PACKAGE_AUGEAS". But, the same review pointed that python-augeas
used a "depends on BR2_PACKAGE_AUGEAS".

In order to make things consistent, let's switch to "select
BR2_PACKAGE_AUGEAS" as well for python-augeas.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/python-augeas/Config.in | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/python-augeas/Config.in b/package/python-augeas/Config.in
index 3503a83b3b..4ab2bd1b26 100644
--- a/package/python-augeas/Config.in
+++ b/package/python-augeas/Config.in
@@ -1,8 +1,14 @@
 config BR2_PACKAGE_PYTHON_AUGEAS
 	bool "python-augeas"
-	depends on BR2_PACKAGE_AUGEAS
+	depends on !BR2_arc
+	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_AUGEAS
 	select BR2_PACKAGE_PYTHON_CFFI # runtime
 	help
 	  Pure python bindings for Augeas.
 
 	  https://github.com/hercules-team/python-augeas
+
+comment "python-augeas needs a toolchain w/ wchar"
+	depends on !BR2_arc
+	depends on !BR2_USE_WCHAR
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-augeas: switch from "depends on" to "select" for augeas dep

[Yann E. MORIN]

Thomas, All,

On 2021-10-03 18:18 +0200, Thomas Petazzoni spake thusly:
> During the review of the lua-augeas package, it was pointed out that a
> "select BR2_PACKAGE_AUGEAS" should be used instead of a "depends on
> BR2_PACKAGE_AUGEAS". But, the same review pointed that python-augeas
> used a "depends on BR2_PACKAGE_AUGEAS".
> 
> In order to make things consistent, let's switch to "select
> BR2_PACKAGE_AUGEAS" as well for python-augeas.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/python-augeas/Config.in | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/package/python-augeas/Config.in b/package/python-augeas/Config.in
> index 3503a83b3b..4ab2bd1b26 100644
> --- a/package/python-augeas/Config.in
> +++ b/package/python-augeas/Config.in
> @@ -1,8 +1,14 @@
>  config BR2_PACKAGE_PYTHON_AUGEAS
>  	bool "python-augeas"
> -	depends on BR2_PACKAGE_AUGEAS
> +	depends on !BR2_arc
> +	depends on BR2_USE_WCHAR
> +	select BR2_PACKAGE_AUGEAS
>  	select BR2_PACKAGE_PYTHON_CFFI # runtime
>  	help
>  	  Pure python bindings for Augeas.
>  
>  	  https://github.com/hercules-team/python-augeas
> +
> +comment "python-augeas needs a toolchain w/ wchar"
> +	depends on !BR2_arc
> +	depends on !BR2_USE_WCHAR
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot