* [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies
@ 2021-10-01 10:34 Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Perez de Castro @ 2021-10-01 10:34 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro
This is only a runtime dependency, not a build dependency.
Based on a similar patch by James Hilliard for the wpewebkit
package.
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/webkitgtk.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 6687d7f61b..87aeffea45 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -46,7 +46,7 @@ ifeq ($(BR2_PACKAGE_WEBKITGTK_MULTIMEDIA),y)
WEBKITGTK_CONF_OPTS += \
-DENABLE_VIDEO=ON \
-DENABLE_WEB_AUDIO=ON
-WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
+WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
else
WEBKITGTK_CONF_OPTS += \
-DENABLE_VIDEO=OFF \
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies
2021-10-01 10:34 [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies Adrian Perez de Castro
@ 2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-10-03 20:15 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
Adrian, All,
On 2021-10-01 13:34 +0300, Adrian Perez de Castro spake thusly:
> This is only a runtime dependency, not a build dependency.
> Based on a similar patch by James Hilliard for the wpewebkit
> package.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/webkitgtk/webkitgtk.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 6687d7f61b..87aeffea45 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -46,7 +46,7 @@ ifeq ($(BR2_PACKAGE_WEBKITGTK_MULTIMEDIA),y)
> WEBKITGTK_CONF_OPTS += \
> -DENABLE_VIDEO=ON \
> -DENABLE_WEB_AUDIO=ON
> -WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
> else
> WEBKITGTK_CONF_OPTS += \
> -DENABLE_VIDEO=OFF \
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies
2021-10-01 10:34 [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
@ 2021-10-06 15:18 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-10-06 15:18 UTC (permalink / raw)
To: Adrian Perez de Castro; +Cc: buildroot
>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:
> This is only a runtime dependency, not a build dependency.
> Based on a similar patch by James Hilliard for the wpewebkit
> package.
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/webkitgtk.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 6687d7f61b..87aeffea45 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -46,7 +46,7 @@ ifeq ($(BR2_PACKAGE_WEBKITGTK_MULTIMEDIA),y)
> WEBKITGTK_CONF_OPTS += \
> -DENABLE_VIDEO=ON \
> -DENABLE_WEB_AUDIO=ON
> -WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
NIT: we normally add a # runtime comment to the select line in Config.in
then to make it clear why it isn't listed in _DEPENDENCIES.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-06 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 10:34 [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.