All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
	nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de,
	ojaswin98@gmail.com, amarjargal16@gmail.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] staging: vchiq_core: cleanup blank lines
Date: Mon, 4 Oct 2021 09:55:11 +0300	[thread overview]
Message-ID: <20211004065511.GC2083@kadam> (raw)
In-Reply-To: <20211003195758.36572-2-gascoar@gmail.com>

On Sun, Oct 03, 2021 at 04:57:51PM -0300, Gaston Gonzalez wrote:
> Remove unnecessary blank lines.
> 
> Reported by checkpatch.pl
> 
> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> ---

[ snip ]

> @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle,
>  	}
>  
>  	state = service->state;
> -
>  	queue = (dir == VCHIQ_BULK_TRANSMIT) ?
>  		&service->bulk_tx : &service->bulk_rx;
>  


I don't care one way or the other about the blank line, but it's
not a checkpatch warning.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
	nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de,
	ojaswin98@gmail.com, amarjargal16@gmail.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] staging: vchiq_core: cleanup blank lines
Date: Mon, 4 Oct 2021 09:55:11 +0300	[thread overview]
Message-ID: <20211004065511.GC2083@kadam> (raw)
In-Reply-To: <20211003195758.36572-2-gascoar@gmail.com>

On Sun, Oct 03, 2021 at 04:57:51PM -0300, Gaston Gonzalez wrote:
> Remove unnecessary blank lines.
> 
> Reported by checkpatch.pl
> 
> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> ---

[ snip ]

> @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle,
>  	}
>  
>  	state = service->state;
> -
>  	queue = (dir == VCHIQ_BULK_TRANSMIT) ?
>  		&service->bulk_tx : &service->bulk_rx;
>  


I don't care one way or the other about the blank line, but it's
not a checkpatch warning.

regards,
dan carpenter


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-04  6:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-03 19:57 [PATCH 0/9] staging: vchiq_core: various style cleanups Gaston Gonzalez
2021-10-03 19:57 ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 1/9] staging: vchiq_core: cleanup blank lines Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-04  6:55   ` Dan Carpenter [this message]
2021-10-04  6:55     ` Dan Carpenter
2021-10-04 19:55     ` Gaston Gonzalez
2021-10-04 19:55       ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 2/9] staging: vchiq_core: cleanup code alignment issues Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 3/9] staging: vchiq_core.h: fix CamelCase in function declaration Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 4/9] staging: vchiq_core.h: use preferred kernel types Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 5/9] staging: vchiq: drop trailing semicolon in macro definition Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 6/9] staging: vchiq_core: drop extern prefix in function declarations Gaston Gonzalez
2021-10-03 19:57   ` Gaston Gonzalez
2021-10-03 19:58 ` [PATCH 7/9] staging: vchiq_core: cleanup lines that end with '(' or '[' Gaston Gonzalez
2021-10-03 19:58   ` Gaston Gonzalez
2021-10-03 19:58 ` [PATCH 8/9] staging: vchiq_core: cleanup unnecessary blank line Gaston Gonzalez
2021-10-03 19:58   ` Gaston Gonzalez
2021-10-03 19:58 ` [PATCH 9/9] staging: vchiq_core: fix quoted strings split across lines Gaston Gonzalez
2021-10-03 19:58   ` Gaston Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004065511.GC2083@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=amarjargal16@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gascoar@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nsaenz@kernel.org \
    --cc=ojaswin98@gmail.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.