From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: qemu-devel@nongnu.org, Eric Auger <eric.auger@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors
Date: Mon, 4 Oct 2021 12:14:03 +0200 [thread overview]
Message-ID: <20211004101403.i65r26cc22a5ktqi@gator> (raw)
In-Reply-To: <20211004094408.xfftmls7h6bbypuk@gator>
On Mon, Oct 04, 2021 at 11:44:08AM +0200, Andrew Jones wrote:
> On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote:
...
> >
> > - return MACHINE(vms)->smp.cpus > redist0_capacity ? 2 : 1;
> > + return (MACHINE(vms)->smp.cpus > redist0_capacity &&
> > + vms->highmem_redists) ? 2 : 1;
>
> Wouldn't it be equivalent to just use vms->highmem here?
OK, I see in the last patch that we may disable highmem_redists
but not highmem.
In that case,
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors
Date: Mon, 4 Oct 2021 12:14:03 +0200 [thread overview]
Message-ID: <20211004101403.i65r26cc22a5ktqi@gator> (raw)
In-Reply-To: <20211004094408.xfftmls7h6bbypuk@gator>
On Mon, Oct 04, 2021 at 11:44:08AM +0200, Andrew Jones wrote:
> On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote:
...
> >
> > - return MACHINE(vms)->smp.cpus > redist0_capacity ? 2 : 1;
> > + return (MACHINE(vms)->smp.cpus > redist0_capacity &&
> > + vms->highmem_redists) ? 2 : 1;
>
> Wouldn't it be equivalent to just use vms->highmem here?
OK, I see in the last patch that we may disable highmem_redists
but not highmem.
In that case,
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
Eric Auger <eric.auger@redhat.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors
Date: Mon, 4 Oct 2021 12:14:03 +0200 [thread overview]
Message-ID: <20211004101403.i65r26cc22a5ktqi@gator> (raw)
In-Reply-To: <20211004094408.xfftmls7h6bbypuk@gator>
On Mon, Oct 04, 2021 at 11:44:08AM +0200, Andrew Jones wrote:
> On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote:
...
> >
> > - return MACHINE(vms)->smp.cpus > redist0_capacity ? 2 : 1;
> > + return (MACHINE(vms)->smp.cpus > redist0_capacity &&
> > + vms->highmem_redists) ? 2 : 1;
>
> Wouldn't it be equivalent to just use vms->highmem here?
OK, I see in the last patch that we may disable highmem_redists
but not highmem.
In that case,
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
next prev parent reply other threads:[~2021-10-04 10:14 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 16:46 [PATCH v2 0/5] target/arm: Reduced-IPA space and highmem=off fixes Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-04 9:41 ` Andrew Jones
2021-10-04 9:41 ` Andrew Jones
2021-10-04 9:41 ` Andrew Jones
2021-10-04 12:00 ` Eric Auger
2021-10-04 12:00 ` Eric Auger
2021-10-04 12:00 ` Eric Auger
2021-12-27 15:53 ` Marc Zyngier
2021-12-27 15:53 ` Marc Zyngier
2021-12-27 15:53 ` Marc Zyngier
2022-01-04 15:31 ` Eric Auger
2022-01-04 15:31 ` Eric Auger
2022-01-04 15:31 ` Eric Auger
2022-01-04 22:15 ` Marc Zyngier
2022-01-04 22:15 ` Marc Zyngier
2022-01-04 22:15 ` Marc Zyngier
2022-01-05 9:41 ` Eric Auger
2022-01-05 9:41 ` Eric Auger
2022-01-05 9:41 ` Eric Auger
2022-01-06 19:34 ` Marc Zyngier
2022-01-06 19:34 ` Marc Zyngier
2022-01-06 19:34 ` Marc Zyngier
2022-01-07 17:10 ` Eric Auger
2022-01-07 17:10 ` Eric Auger
2022-01-07 17:10 ` Eric Auger
2021-10-03 16:46 ` [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-04 9:44 ` Andrew Jones
2021-10-04 9:44 ` Andrew Jones
2021-10-04 9:44 ` Andrew Jones
2021-10-04 10:14 ` Andrew Jones [this message]
2021-10-04 10:14 ` Andrew Jones
2021-10-04 10:14 ` Andrew Jones
2021-10-03 16:46 ` [PATCH v2 3/5] hw/arm/virt: Honor highmem setting when computing the memory map Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-04 9:44 ` Andrew Jones
2021-10-04 9:44 ` Andrew Jones
2021-10-04 9:44 ` Andrew Jones
2021-10-04 12:23 ` Eric Auger
2021-10-04 12:23 ` Eric Auger
2021-10-04 12:23 ` Eric Auger
2021-12-27 16:39 ` Marc Zyngier
2021-12-27 16:39 ` Marc Zyngier
2021-12-27 16:39 ` Marc Zyngier
2021-10-03 16:46 ` [PATCH v2 4/5] hw/arm/virt: Use the PA range to compute " Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-04 10:11 ` Andrew Jones
2021-10-04 10:11 ` Andrew Jones
2021-10-04 10:11 ` Andrew Jones
2021-12-27 20:13 ` Marc Zyngier
2021-12-27 20:13 ` Marc Zyngier
2021-12-27 20:13 ` Marc Zyngier
2021-10-04 10:15 ` Andrew Jones
2021-10-04 10:15 ` Andrew Jones
2021-10-04 10:15 ` Andrew Jones
2021-10-03 16:46 ` [PATCH v2 5/5] hw/arm/virt: Disable highmem devices that don't fit in the PA range Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-03 16:46 ` Marc Zyngier
2021-10-04 10:12 ` Andrew Jones
2021-10-04 10:12 ` Andrew Jones
2021-10-04 10:12 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004101403.i65r26cc22a5ktqi@gator \
--to=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.