[PATCH] linux-yocto: add libmpc-native to DEPENDS

[PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

5.14 changed how the GCC plugins are built, which means they now
depend on both GMP and MPC to be built. We already depend on gmp-native,
so add libmpc-native aswell.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-kernel/linux/linux-yocto_5.14.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/linux-yocto_5.14.bb b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
index 0c6fbff75e..8c44c294bd 100644
--- a/meta/recipes-kernel/linux/linux-yocto_5.14.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
@@ -46,7 +46,7 @@ LINUX_VERSION ?= "5.14.6"
 
 DEPENDS += "${@bb.utils.contains('ARCH', 'x86', 'elfutils-native', '', d)}"
 DEPENDS += "openssl-native util-linux-native"
-DEPENDS += "gmp-native"
+DEPENDS += "gmp-native libmpc-native"
 
 PV = "${LINUX_VERSION}+git${SRCPV}"
 
-- 
2.25.1

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Bruce Ashfield]

On Tue, Oct 5, 2021 at 10:07 AM Ross Burton <ross@burtonini.com> wrote:
>
> 5.14 changed how the GCC plugins are built, which means they now
> depend on both GMP and MPC to be built. We already depend on gmp-native,
> so add libmpc-native aswell.

What's the symptom when the native dependency isn't around ? I'm just
wondering why none of my tests have picked this up. Is it only showing
on ARM hosts ? Something else ?

linux-yocto-dev can use this as well,  I can take care of that, if you
don't have the cycles.

I'm also factoring some of these things into kernel.bbclass, but this
makes sense in the recipe for now.

Bruce

>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-kernel/linux/linux-yocto_5.14.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-yocto_5.14.bb b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
> index 0c6fbff75e..8c44c294bd 100644
> --- a/meta/recipes-kernel/linux/linux-yocto_5.14.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
> @@ -46,7 +46,7 @@ LINUX_VERSION ?= "5.14.6"
>
>  DEPENDS += "${@bb.utils.contains('ARCH', 'x86', 'elfutils-native', '', d)}"
>  DEPENDS += "openssl-native util-linux-native"
> -DEPENDS += "gmp-native"
> +DEPENDS += "gmp-native libmpc-native"
>
>  PV = "${LINUX_VERSION}+git${SRCPV}"
>
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156645): https://lists.openembedded.org/g/openembedded-core/message/156645
> Mute This Topic: https://lists.openembedded.org/mt/86092630/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

On Wed, 6 Oct 2021 at 01:17, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
> What's the symptom when the native dependency isn't around ? I'm just
> wondering why none of my tests have picked this up. Is it only showing
> on ARM hosts ? Something else ?
>
> linux-yocto-dev can use this as well,  I can take care of that, if you
> don't have the cycles.
>
> I'm also factoring some of these things into kernel.bbclass, but this
> makes sense in the recipe for now.

This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
any of the default configurations.  meta-arm builds a few kernels with
defconfig, which does.

Ross

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

On Wed, 6 Oct 2021 at 11:10, Ross Burton <ross@burtonini.com> wrote:
> This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
> any of the default configurations.  meta-arm builds a few kernels with
> defconfig, which does.

Sorry, brain still not warmed up yet.

CONFIG_GCC_PLUGINS needs to be enabled, but the real difference is
that using the normal GCC pulls libmpc into the sysroot via implicit
dependencies.  If you use an external toolchain (like
meta-arm-toolchain) this doesn't happen, and the dependency needs to
be explicit.

Ross

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

I should have put this in the commit message, but here's the failure
when using an external toolchain:

2021-10-05 12:52:14 - INFO - | HOSTCXX
scripts/gcc-plugins/arm_ssp_per_task_plugin.so
2021-10-05 12:52:14 - INFO - | In file included from
/builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/gcc-common.h:103,
2021-10-05 12:52:14 - INFO - | from
/builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/arm_ssp_per_task_plugin.c:3:
02021-10-05 12:52:14 - INFO - |
/builds/persist/toolchains/gcc-arm-10.3-2021.07-aarch64-arm-none-linux-gnueabihf/bin/../lib/gcc/arm-none-linux-gnueabihf/10.3.1/plugin/include/builtins.h:23:10:
fatal error: mpc.h: No such file or directory
2021-10-05 12:52:14 - INFO - | #include <mpc.h>
2021-10-05 12:52:14 - INFO - | ^~~~~~~
2021-10-05 12:52:14 - INFO - | compilation terminated.

On Wed, 6 Oct 2021 at 11:12, Ross Burton <ross@burtonini.com> wrote:
>
> On Wed, 6 Oct 2021 at 11:10, Ross Burton <ross@burtonini.com> wrote:
> > This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
> > any of the default configurations.  meta-arm builds a few kernels with
> > defconfig, which does.
>
> Sorry, brain still not warmed up yet.
>
> CONFIG_GCC_PLUGINS needs to be enabled, but the real difference is
> that using the normal GCC pulls libmpc into the sysroot via implicit
> dependencies.  If you use an external toolchain (like
> meta-arm-toolchain) this doesn't happen, and the dependency needs to
> be explicit.
>
> Ross

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Bruce Ashfield]

On Wed, Oct 6, 2021 at 7:42 AM Ross Burton <ross@burtonini.com> wrote:
>
> I should have put this in the commit message, but here's the failure
> when using an external toolchain:
>
> 2021-10-05 12:52:14 - INFO - | HOSTCXX
> scripts/gcc-plugins/arm_ssp_per_task_plugin.so
> 2021-10-05 12:52:14 - INFO - | In file included from
> /builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/gcc-common.h:103,
> 2021-10-05 12:52:14 - INFO - | from
> /builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/arm_ssp_per_task_plugin.c:3:
> 02021-10-05 12:52:14 - INFO - |
> /builds/persist/toolchains/gcc-arm-10.3-2021.07-aarch64-arm-none-linux-gnueabihf/bin/../lib/gcc/arm-none-linux-gnueabihf/10.3.1/plugin/include/builtins.h:23:10:
> fatal error: mpc.h: No such file or directory
> 2021-10-05 12:52:14 - INFO - | #include <mpc.h>
> 2021-10-05 12:52:14 - INFO - | ^~~~~~~
> 2021-10-05 12:52:14 - INFO - | compilation terminated.

Aha. Yes, that does tell the story. I knew it had to be a compilation
failure, since that is how I picked up the other DEPENDS.

Did we want to tweak the commit message and add linux-yocto-dev to the
patch ? I can have go at that if you want.

Bruce

>
> On Wed, 6 Oct 2021 at 11:12, Ross Burton <ross@burtonini.com> wrote:
> >
> > On Wed, 6 Oct 2021 at 11:10, Ross Burton <ross@burtonini.com> wrote:
> > > This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
> > > any of the default configurations.  meta-arm builds a few kernels with
> > > defconfig, which does.
> >
> > Sorry, brain still not warmed up yet.
> >
> > CONFIG_GCC_PLUGINS needs to be enabled, but the real difference is
> > that using the normal GCC pulls libmpc into the sysroot via implicit
> > dependencies.  If you use an external toolchain (like
> > meta-arm-toolchain) this doesn't happen, and the dependency needs to
> > be explicit.
> >
> > Ross



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Andrey Zhizhikin]

Hello all,

On Wed, Oct 6, 2021 at 1:20 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Wed, Oct 6, 2021 at 7:42 AM Ross Burton <ross@burtonini.com> wrote:
> >
> > I should have put this in the commit message, but here's the failure
> > when using an external toolchain:
> >
> > 2021-10-05 12:52:14 - INFO - | HOSTCXX
> > scripts/gcc-plugins/arm_ssp_per_task_plugin.so
> > 2021-10-05 12:52:14 - INFO - | In file included from
> > /builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/gcc-common.h:103,
> > 2021-10-05 12:52:14 - INFO - | from
> > /builds/engineering/yocto/meta-arm/work/build/tmp/work-shared/fvp-base-arm32/kernel-source/scripts/gcc-plugins/arm_ssp_per_task_plugin.c:3:
> > 02021-10-05 12:52:14 - INFO - |
> > /builds/persist/toolchains/gcc-arm-10.3-2021.07-aarch64-arm-none-linux-gnueabihf/bin/../lib/gcc/arm-none-linux-gnueabihf/10.3.1/plugin/include/builtins.h:23:10:
> > fatal error: mpc.h: No such file or directory
> > 2021-10-05 12:52:14 - INFO - | #include <mpc.h>
> > 2021-10-05 12:52:14 - INFO - | ^~~~~~~
> > 2021-10-05 12:52:14 - INFO - | compilation terminated.
>
> Aha. Yes, that does tell the story. I knew it had to be a compilation
> failure, since that is how I picked up the other DEPENDS.

Sorry for jumping in here, I guess there is one additional issue that
would be unraveled after libmpc will be included.

What I saw long time ago (starting from v5.13.y) is that even when
both gmp and libmpc are added, following build errors are produced
from ARM32 builds when defconfig is used:
----
cc1: error: cannot load plugin
./scripts/gcc-plugins/arm_ssp_per_task_plugin.so:
./scripts/gcc-plugins/arm_ssp_per_task_plugin.so: undefined symbol:
_ZN8opt_pass14set_pass_paramEjb
cc1: error: cannot load plugin
./scripts/gcc-plugins/arm_ssp_per_task_plugin.so:
./scripts/gcc-plugins/arm_ssp_per_task_plugin.so: undefined symbol:
_ZN8opt_pass14set_pass_paramEjb
----

It seems that GCC plugins are somehow disabled in SDK GCC, but Kernel
build system checks them on the host, which does provide them. This
leads to a false identification that plugins are enabled and leads to
further build failures.

This behavior came with commit 1e860048c53e ("gcc-plugins: simplify
GCC plugin-dev capability test"), where previously build system ran an
internal script to verify if plugins are present by running compile
tests, but after this commit - it checks only if the folder containing
plugins is there. This leads to the issue that when host GCC has the
folder - plugins are enabled, but when later the compile pass is taken
- it fails since the .so is not present in the SDK sysroot.

I'd have to point out that this error only occurs for ARM32 builds,
aarch64 builds are not affected.

This has also been discussed here on the list, but I can't seem to
find a reference to it anymore.

>
> Did we want to tweak the commit message and add linux-yocto-dev to the
> patch ? I can have go at that if you want.
>
> Bruce
>
> >
> > On Wed, 6 Oct 2021 at 11:12, Ross Burton <ross@burtonini.com> wrote:
> > >
> > > On Wed, 6 Oct 2021 at 11:10, Ross Burton <ross@burtonini.com> wrote:
> > > > This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
> > > > any of the default configurations.  meta-arm builds a few kernels with
> > > > defconfig, which does.
> > >
> > > Sorry, brain still not warmed up yet.
> > >
> > > CONFIG_GCC_PLUGINS needs to be enabled, but the real difference is
> > > that using the normal GCC pulls libmpc into the sysroot via implicit
> > > dependencies.  If you use an external toolchain (like
> > > meta-arm-toolchain) this doesn't happen, and the dependency needs to
> > > be explicit.
> > >
> > > Ross
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156690): https://lists.openembedded.org/g/openembedded-core/message/156690
> Mute This Topic: https://lists.openembedded.org/mt/86092630/3617192
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [andrey.z@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


--
Regards,
Andrey.

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

On Thu, 14 Oct 2021 at 10:21, Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> It seems that GCC plugins are somehow disabled in SDK GCC, but Kernel
> build system checks them on the host, which does provide them. This
> leads to a false identification that plugins are enabled and leads to
> further build failures.
>
> This behavior came with commit 1e860048c53e ("gcc-plugins: simplify
> GCC plugin-dev capability test"), where previously build system ran an
> internal script to verify if plugins are present by running compile
> tests, but after this commit - it checks only if the folder containing
> plugins is there. This leads to the issue that when host GCC has the
> folder - plugins are enabled, but when later the compile pass is taken
> - it fails since the .so is not present in the SDK sysroot.

Urgh.

Can you provide a minimal reproducer for this?

Ross

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Khem Raj]

On 10/6/21 3:12 AM, Ross Burton wrote:
> On Wed, 6 Oct 2021 at 11:10, Ross Burton <ross@burtonini.com> wrote:
>> This depends on CONFIG_GCC_PLUGINS which I don't believe is enabled in
>> any of the default configurations.  meta-arm builds a few kernels with
>> defconfig, which does.
> 
> Sorry, brain still not warmed up yet.
> 
> CONFIG_GCC_PLUGINS needs to be enabled, but the real difference is
> that using the normal GCC pulls libmpc into the sysroot via implicit
> dependencies.  If you use an external toolchain (like
> meta-arm-toolchain) this doesn't happen, and the dependency needs to
> be explicit.
> 

Does it have to be native or target dependency ?

> Ross
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156686): https://lists.openembedded.org/g/openembedded-core/message/156686
> Mute This Topic: https://lists.openembedded.org/mt/86092630/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> Does it have to be native or target dependency ?

Native, as it builds compiler plugins for the host.

Ross

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Bruce Ashfield]

On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
>
> On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > Does it have to be native or target dependency ?
>
> Native, as it builds compiler plugins for the host.

I was out most of last week, and this was a holiday weekend here, so
I'm running behind.

I didn't notice this on master or master-next, so I've grabbed it and
made the same change to linux-yocto-dev.

I'll send them out in my next pull request.

Bruce

>
> Ross



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Alexandre Belloni]

On 12/10/2021 10:36:12-0400, Bruce Ashfield wrote:
> On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
> >
> > On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > Does it have to be native or target dependency ?
> >
> > Native, as it builds compiler plugins for the host.
> 
> I was out most of last week, and this was a holiday weekend here, so
> I'm running behind.
> 
> I didn't notice this on master or master-next, so I've grabbed it and
> made the same change to linux-yocto-dev.
> 
> I'll send them out in my next pull request.
> 

Actually, this has been in my kirkstone-next and now my master-next for
a while but not in any green a-full build yet.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Bruce Ashfield]

On Wed, Oct 13, 2021 at 5:50 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 12/10/2021 10:36:12-0400, Bruce Ashfield wrote:
> > On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
> > >
> > > On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > > Does it have to be native or target dependency ?
> > >
> > > Native, as it builds compiler plugins for the host.
> >
> > I was out most of last week, and this was a holiday weekend here, so
> > I'm running behind.
> >
> > I didn't notice this on master or master-next, so I've grabbed it and
> > made the same change to linux-yocto-dev.
> >
> > I'll send them out in my next pull request.
> >
>
> Actually, this has been in my kirkstone-next and now my master-next for
> a while but not in any green a-full build yet.

Can you point me at that branch ?

If it isn't poky master-next, or opembedded-core master-next, it might
as well not exist, since it isn't something I'm going to check.

Bruce

>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Alexandre Belloni]

On 13/10/2021 08:25:38-0400, Bruce Ashfield wrote:
> On Wed, Oct 13, 2021 at 5:50 AM Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> >
> > On 12/10/2021 10:36:12-0400, Bruce Ashfield wrote:
> > > On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
> > > >
> > > > On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > > > Does it have to be native or target dependency ?
> > > >
> > > > Native, as it builds compiler plugins for the host.
> > >
> > > I was out most of last week, and this was a holiday weekend here, so
> > > I'm running behind.
> > >
> > > I didn't notice this on master or master-next, so I've grabbed it and
> > > made the same change to linux-yocto-dev.
> > >
> > > I'll send them out in my next pull request.
> > >
> >
> > Actually, this has been in my kirkstone-next and now my master-next for
> > a while but not in any green a-full build yet.
> 
> Can you point me at that branch ?
> 
> If it isn't poky master-next, or opembedded-core master-next, it might
> as well not exist, since it isn't something I'm going to check.
> 

Sure, it is here:
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abelloni/master-next


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Alexandre Belloni]

On 13/10/2021 14:34:25+0200, Alexandre Belloni wrote:
> On 13/10/2021 08:25:38-0400, Bruce Ashfield wrote:
> > On Wed, Oct 13, 2021 at 5:50 AM Alexandre Belloni
> > <alexandre.belloni@bootlin.com> wrote:
> > >
> > > On 12/10/2021 10:36:12-0400, Bruce Ashfield wrote:
> > > > On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
> > > > >
> > > > > On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > > > > Does it have to be native or target dependency ?
> > > > >
> > > > > Native, as it builds compiler plugins for the host.
> > > >
> > > > I was out most of last week, and this was a holiday weekend here, so
> > > > I'm running behind.
> > > >
> > > > I didn't notice this on master or master-next, so I've grabbed it and
> > > > made the same change to linux-yocto-dev.
> > > >
> > > > I'll send them out in my next pull request.
> > > >
> > >
> > > Actually, this has been in my kirkstone-next and now my master-next for
> > > a while but not in any green a-full build yet.
> > 
> > Can you point me at that branch ?
> > 
> > If it isn't poky master-next, or opembedded-core master-next, it might
> > as well not exist, since it isn't something I'm going to check.
> > 
> 
> Sure, it is here:
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abelloni/master-next
> 

BTW, it is perfectly fine if you include again it in your next PR.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] linux-yocto: add libmpc-native to DEPENDS

[Bruce Ashfield]

On Wed, Oct 13, 2021 at 8:36 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 13/10/2021 14:34:25+0200, Alexandre Belloni wrote:
> > On 13/10/2021 08:25:38-0400, Bruce Ashfield wrote:
> > > On Wed, Oct 13, 2021 at 5:50 AM Alexandre Belloni
> > > <alexandre.belloni@bootlin.com> wrote:
> > > >
> > > > On 12/10/2021 10:36:12-0400, Bruce Ashfield wrote:
> > > > > On Thu, Oct 7, 2021 at 6:13 AM Ross Burton <ross@burtonini.com> wrote:
> > > > > >
> > > > > > On Wed, 6 Oct 2021 at 18:59, Khem Raj <raj.khem@gmail.com> wrote:
> > > > > > > Does it have to be native or target dependency ?
> > > > > >
> > > > > > Native, as it builds compiler plugins for the host.
> > > > >
> > > > > I was out most of last week, and this was a holiday weekend here, so
> > > > > I'm running behind.
> > > > >
> > > > > I didn't notice this on master or master-next, so I've grabbed it and
> > > > > made the same change to linux-yocto-dev.
> > > > >
> > > > > I'll send them out in my next pull request.
> > > > >
> > > >
> > > > Actually, this has been in my kirkstone-next and now my master-next for
> > > > a while but not in any green a-full build yet.
> > >
> > > Can you point me at that branch ?
> > >
> > > If it isn't poky master-next, or opembedded-core master-next, it might
> > > as well not exist, since it isn't something I'm going to check.
> > >
> >
> > Sure, it is here:
> > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abelloni/master-next
> >
>
> BTW, it is perfectly fine if you include again it in your next PR.

Thanks. I'll write it down, and hopefully remember to check your branch as well!

I'll keep it locally, and when I update against master I'll double
check if it is still pending. But it can flow through via your branch,
no concerns about that.

Bruce



>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

[PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

From: Ross Burton <ross@burtonini.com>

5.10.85 changed how the GCC plugins are built, which means they now
depend on both GMP and MPC to be built. We already depend on gmp-native,
so add libmpc-native aswell.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-kernel/linux/linux-yocto_5.10.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/linux-yocto_5.10.bb b/meta/recipes-kernel/linux/linux-yocto_5.10.bb
index c62157d850..bbb25f7393 100644
--- a/meta/recipes-kernel/linux/linux-yocto_5.10.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_5.10.bb
@@ -36,7 +36,7 @@ LINUX_VERSION ?= "5.10.87"
 
 DEPENDS += "${@bb.utils.contains('ARCH', 'x86', 'elfutils-native', '', d)}"
 DEPENDS += "openssl-native util-linux-native"
-DEPENDS += "gmp-native"
+DEPENDS += "gmp-native libmpc-native"
 
 PV = "${LINUX_VERSION}+git${SRCPV}"
 
-- 
2.25.1

[PATCH] linux-yocto: add libmpc-native to DEPENDS

[Ross Burton]

5.14 changed how the GCC plugins are built, which means they now
depend on both GMP and MPC to be built. We already depend on gmp-native,
so add libmpc-native aswell.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-kernel/linux/linux-yocto_5.14.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/linux-yocto_5.14.bb b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
index 0c6fbff75e..8c44c294bd 100644
--- a/meta/recipes-kernel/linux/linux-yocto_5.14.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_5.14.bb
@@ -46,7 +46,7 @@ LINUX_VERSION ?= "5.14.6"
 
 DEPENDS += "${@bb.utils.contains('ARCH', 'x86', 'elfutils-native', '', d)}"
 DEPENDS += "openssl-native util-linux-native"
-DEPENDS += "gmp-native"
+DEPENDS += "gmp-native libmpc-native"
 
 PV = "${LINUX_VERSION}+git${SRCPV}"
 
-- 
2.25.1