[PATCH] btrfs-progs: fix comments in cmd_filesystem_show

[PATCH] btrfs-progs: fix comments in cmd_filesystem_show

[Anand Jain]

I had to go back to find what BTRFS_ARG_REG is, add a comment for that.

And, search_umounted_fs_uuids() is also to find the seed device, so bring
the related comment above it.

No functional changes.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 cmds/filesystem.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/cmds/filesystem.c b/cmds/filesystem.c
index 4f123d25320f..2a5ca8ddd4f9 100644
--- a/cmds/filesystem.c
+++ b/cmds/filesystem.c
@@ -753,6 +753,7 @@ static int cmd_filesystem_show(const struct cmd_struct *cmd,
 devs_only:
 	if (type == BTRFS_ARG_REG) {
 		/*
+		 * Given input (search) is regular file.
 		 * We don't close the fs_info because it will free the device,
 		 * this is not a long-running process so it's fine
 		 */
@@ -769,16 +770,17 @@ devs_only:
 		return 1;
 	}
 
+	/*
+	 * The seed/sprout mappings are not detected yet, do mapping build for
+	 * all umounted fs. But first, copy all unmounted UUIDs only to
+	 * all_uuids.
+	 */
 	ret = search_umounted_fs_uuids(&all_uuids, search, &found);
 	if (ret < 0) {
 		error("searching target device returned error %d", ret);
 		return 1;
 	}
 
-	/*
-	 * The seed/sprout mapping are not detected yet,
-	 * do mapping build for all umounted fs
-	 */
 	ret = map_seed_devices(&all_uuids);
 	if (ret) {
 		error("mapping seed devices returned error %d", ret);
-- 
2.31.1

Re: [PATCH] btrfs-progs: fix comments in cmd_filesystem_show

[David Sterba]

On Thu, Sep 30, 2021 at 08:18:55PM +0800, Anand Jain wrote:
> I had to go back to find what BTRFS_ARG_REG is, add a comment for that.
> 
> And, search_umounted_fs_uuids() is also to find the seed device, so bring
> the related comment above it.
> 
> No functional changes.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>

Added to devel, thanks.