* [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf @ 2021-10-04 5:40 Zbigniew Kempczyński 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() Zbigniew Kempczyński ` (3 more replies) 0 siblings, 4 replies; 10+ messages in thread From: Zbigniew Kempczyński @ 2021-10-04 5:40 UTC (permalink / raw) To: igt-dev; +Cc: Zbigniew Kempczyński, Petri Latvala, Ashutosh Dixit In intel_buf size not always was equal to buffer size, even if intel_buf_bo_size() which returns that field would suggest. Clean the mess - from now on buf->size contains real buffer size (requested one) and buf->bo_size underlying gem bo size. Cc: Petri Latvala <petri.latvala@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> Zbigniew Kempczyński (2): lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() lib/intel_bufops: Store gem bo size lib/intel_aux_pgtable.c | 2 +- lib/intel_bufops.c | 33 +++++++++++++++++------------- lib/intel_bufops.h | 3 +++ tests/i915/api_intel_bb.c | 6 +++--- tests/i915/gem_render_copy.c | 14 ++++++------- tests/i915/gem_set_tiling_vs_blt.c | 2 +- 6 files changed, 34 insertions(+), 26 deletions(-) -- 2.26.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() 2021-10-04 5:40 [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf Zbigniew Kempczyński @ 2021-10-04 5:40 ` Zbigniew Kempczyński 2021-10-04 23:09 ` Dixit, Ashutosh 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size Zbigniew Kempczyński ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Zbigniew Kempczyński @ 2021-10-04 5:40 UTC (permalink / raw) To: igt-dev; +Cc: Zbigniew Kempczyński, Petri Latvala, Ashutosh Dixit To avoid confusion with intel_buf_bo_size() which for some buffers can return size not equal to underlying gem bo size rename it to intel_buf_size(). Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> --- lib/intel_aux_pgtable.c | 2 +- lib/intel_batchbuffer.c | 4 ++-- lib/intel_bufops.c | 10 +++++----- lib/intel_bufops.h | 2 +- tests/i915/api_intel_bb.c | 22 +++++++++++----------- tests/i915/gem_render_copy.c | 14 +++++++------- tests/i915/gem_set_tiling_vs_blt.c | 2 +- 7 files changed, 28 insertions(+), 28 deletions(-) diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c index fcc337b8d..6346053de 100644 --- a/lib/intel_aux_pgtable.c +++ b/lib/intel_aux_pgtable.c @@ -97,7 +97,7 @@ pgt_table_count(int address_bits, struct intel_buf **bufs, int buf_count) /* We require bufs to be sorted. */ igt_assert(i == 0 || buf->addr.offset >= bufs[i - 1]->addr.offset + - intel_buf_bo_size(bufs[i - 1])); + intel_buf_size(bufs[i - 1])); start = ALIGN_DOWN(buf->addr.offset, 1UL << address_bits); /* Avoid double counting for overlapping aligned bufs. */ diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index e3e649ca3..5f41eefdb 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -2016,7 +2016,7 @@ __intel_bb_add_intel_buf(struct intel_bb *ibb, struct intel_buf *buf, } } - obj = intel_bb_add_object(ibb, buf->handle, intel_buf_bo_size(buf), + obj = intel_bb_add_object(ibb, buf->handle, intel_buf_size(buf), buf->addr.offset, alignment, write); buf->addr.offset = obj->offset; @@ -2056,7 +2056,7 @@ bool intel_bb_remove_intel_buf(struct intel_bb *ibb, struct intel_buf *buf) removed = intel_bb_remove_object(ibb, buf->handle, buf->addr.offset, - intel_buf_bo_size(buf)); + intel_buf_size(buf)); if (removed) { buf->addr.offset = INTEL_BUF_INVALID_ADDRESS; buf->ibb = NULL; diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c index 52794c1ac..7199723bb 100644 --- a/lib/intel_bufops.c +++ b/lib/intel_bufops.c @@ -1096,10 +1096,10 @@ void intel_buf_print(const struct intel_buf *buf) { igt_info("[name: %s]\n", buf->name); igt_info("[%u]: w: %u, h: %u, stride: %u, size: %" PRIx64 - ", bo-size: %" PRIx64 ", bpp: %u, tiling: %u, compress: %u\n", + ", buf-size: %" PRIx64 ", bpp: %u, tiling: %u, compress: %u\n", buf->handle, intel_buf_width(buf), intel_buf_height(buf), buf->surface[0].stride, buf->surface[0].size, - intel_buf_bo_size(buf), buf->bpp, + intel_buf_size(buf), buf->bpp, buf->tiling, buf->compression); igt_info(" ccs <offset: %u, stride: %u, w: %u, h: %u> cc <offset: %u>\n", buf->ccs[0].offset, @@ -1113,7 +1113,7 @@ void intel_buf_print(const struct intel_buf *buf) void intel_buf_dump(const struct intel_buf *buf, const char *filename) { int i915 = buf_ops_get_fd(buf->bops); - uint64_t size = intel_buf_bo_size(buf); + uint64_t size = intel_buf_size(buf); FILE *out; void *ptr; @@ -1141,7 +1141,7 @@ static void __intel_buf_write_to_png(struct buf_ops *bops, int format, width, height, stride, offset; int gen = bops->intel_gen; - igt_assert_eq(posix_memalign(&linear, 16, intel_buf_bo_size(buf)), 0); + igt_assert_eq(posix_memalign(&linear, 16, intel_buf_size(buf)), 0); format = write_ccs ? CAIRO_FORMAT_A8 : CAIRO_FORMAT_RGB24; width = write_ccs ? intel_buf_ccs_width(gen, buf) : intel_buf_width(buf); @@ -1302,7 +1302,7 @@ static void idempotency_selftest(struct buf_ops *bops, uint32_t tiling) buf_ops_set_software_tiling(bops, tiling, false); } -uint64_t intel_buf_bo_size(const struct intel_buf *buf) +uint64_t intel_buf_size(const struct intel_buf *buf) { return buf->size; } diff --git a/lib/intel_bufops.h b/lib/intel_bufops.h index 54f2ce45e..e09b21b2a 100644 --- a/lib/intel_bufops.h +++ b/lib/intel_bufops.h @@ -97,7 +97,7 @@ intel_buf_ccs_height(int gen, const struct intel_buf *buf) return DIV_ROUND_UP(intel_buf_height(buf), 512) * 32; } -uint64_t intel_buf_bo_size(const struct intel_buf *buf); +uint64_t intel_buf_size(const struct intel_buf *buf); struct buf_ops *buf_ops_create(int fd); struct buf_ops *buf_ops_create_with_selftest(int fd); diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c index 74cb18417..492cedefd 100644 --- a/tests/i915/api_intel_bb.c +++ b/tests/i915/api_intel_bb.c @@ -1055,11 +1055,11 @@ static void offset_control(struct buf_ops *bops) dst1 = create_buf(bops, WIDTH, HEIGHT, COLOR_00); dst2 = create_buf(bops, WIDTH, HEIGHT, COLOR_77); - intel_bb_add_object(ibb, src->handle, intel_buf_bo_size(src), + intel_bb_add_object(ibb, src->handle, intel_buf_size(src), src->addr.offset, 0, false); - intel_bb_add_object(ibb, dst1->handle, intel_buf_bo_size(dst1), + intel_bb_add_object(ibb, dst1->handle, intel_buf_size(dst1), dst1->addr.offset, 0, true); - intel_bb_add_object(ibb, dst2->handle, intel_buf_bo_size(dst2), + intel_bb_add_object(ibb, dst2->handle, intel_buf_size(dst2), dst2->addr.offset, 0, true); intel_bb_out(ibb, MI_BATCH_BUFFER_END); @@ -1080,13 +1080,13 @@ static void offset_control(struct buf_ops *bops) intel_bb_reset(ibb, true); dst3 = create_buf(bops, WIDTH, HEIGHT, COLOR_33); - intel_bb_add_object(ibb, dst3->handle, intel_buf_bo_size(dst3), + intel_bb_add_object(ibb, dst3->handle, intel_buf_size(dst3), dst3->addr.offset, 0, true); - intel_bb_add_object(ibb, src->handle, intel_buf_bo_size(src), + intel_bb_add_object(ibb, src->handle, intel_buf_size(src), src->addr.offset, 0, false); - intel_bb_add_object(ibb, dst1->handle, intel_buf_bo_size(dst1), + intel_bb_add_object(ibb, dst1->handle, intel_buf_size(dst1), dst1->addr.offset, 0, true); - intel_bb_add_object(ibb, dst2->handle, intel_buf_bo_size(dst2), + intel_bb_add_object(ibb, dst2->handle, intel_buf_size(dst2), dst2->addr.offset, 0, true); intel_bb_out(ibb, MI_BATCH_BUFFER_END); @@ -1140,7 +1140,7 @@ static void delta_check(struct buf_ops *bops) buf = create_buf(bops, 0x1000, 0x10, COLOR_CC); buf->addr.offset = 0xfffff000; - intel_bb_add_object(ibb, buf->handle, intel_buf_bo_size(buf), + intel_bb_add_object(ibb, buf->handle, intel_buf_size(buf), buf->addr.offset, 0, false); intel_bb_out(ibb, MI_STORE_DWORD_IMM); @@ -1166,7 +1166,7 @@ static void delta_check(struct buf_ops *bops) gem_munmap(ptr, ibb->size); ptr = gem_mmap__device_coherent(i915, buf->handle, 0, - intel_buf_bo_size(buf), PROT_READ); + intel_buf_size(buf), PROT_READ); val = ptr[0x2000 / sizeof(uint32_t)]; gem_munmap(ptr, ibb->size); @@ -1299,7 +1299,7 @@ static uint32_t count_compressed(int gen, struct intel_buf *buf) int i915 = buf_ops_get_fd(buf->bops); int ccs_size = intel_buf_ccs_width(gen, buf) * intel_buf_ccs_height(gen, buf); uint8_t *ptr = gem_mmap__device_coherent(i915, buf->handle, 0, - intel_buf_bo_size(buf), + intel_buf_size(buf), PROT_READ); uint32_t compressed = 0; int i; @@ -1308,7 +1308,7 @@ static uint32_t count_compressed(int gen, struct intel_buf *buf) if (ptr[buf->ccs[0].offset + i]) compressed++; - munmap(ptr, intel_buf_bo_size(buf)); + munmap(ptr, intel_buf_size(buf)); return compressed; } diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c index 3aac1628a..d485e3415 100644 --- a/tests/i915/gem_render_copy.c +++ b/tests/i915/gem_render_copy.c @@ -103,11 +103,11 @@ static void *linear_copy_ccs(data_t *data, struct intel_buf *buf) unsigned int gen = intel_gen(data->devid); int ccs_size = intel_buf_ccs_width(gen, buf) * intel_buf_ccs_height(gen, buf); - int bo_size = intel_buf_bo_size(buf); + int buf_size = intel_buf_size(buf); ccs_data = alloc_aligned(ccs_size); - linear = alloc_aligned(bo_size); - memset(linear, 0, bo_size); + linear = alloc_aligned(buf_size); + memset(linear, 0, buf_size); intel_buf_to_linear(data->bops, buf, linear); igt_memcpy_from_wc(ccs_data, linear + buf->ccs[0].offset, ccs_size); @@ -185,7 +185,7 @@ scratch_buf_copy(data_t *data, igt_assert_eq(intel_buf_width(dst), intel_buf_width(src)); igt_assert_eq(intel_buf_height(dst), intel_buf_height(src)); - igt_assert_eq(intel_buf_bo_size(dst), intel_buf_bo_size(src)); + igt_assert_eq(intel_buf_size(dst), intel_buf_size(src)); igt_assert_eq(dst->bpp, src->bpp); w = min(w, width - sx); @@ -194,8 +194,8 @@ scratch_buf_copy(data_t *data, h = min(h, height - sy); h = min(h, height - dy); - linear_dst = alloc_aligned(intel_buf_bo_size(dst)); - linear_src = alloc_aligned(intel_buf_bo_size(src)); + linear_dst = alloc_aligned(intel_buf_size(dst)); + linear_src = alloc_aligned(intel_buf_size(src)); intel_buf_to_linear(data->bops, src, linear_src); intel_buf_to_linear(data->bops, dst, linear_dst); @@ -319,7 +319,7 @@ dump_intel_buf_to_file(data_t *data, struct intel_buf *buf, const char *filename { FILE *out; void *ptr; - uint32_t size = intel_buf_bo_size(buf); + uint32_t size = intel_buf_size(buf); gem_set_domain(data->drm_fd, buf->handle, I915_GEM_DOMAIN_CPU, 0); diff --git a/tests/i915/gem_set_tiling_vs_blt.c b/tests/i915/gem_set_tiling_vs_blt.c index ff600f942..bf274be98 100644 --- a/tests/i915/gem_set_tiling_vs_blt.c +++ b/tests/i915/gem_set_tiling_vs_blt.c @@ -126,7 +126,7 @@ static void do_test(struct buf_ops *bops, uint32_t tiling, unsigned stride, intel_buf_init_using_handle(bops, test_buf->handle, test_buf, TEST_WIDTH(stride), TEST_HEIGHT(stride), 32, 0, tiling, I915_COMPRESSION_NONE); - igt_assert_eq_u32(intel_buf_bo_size(test_buf), TEST_SIZE); + igt_assert_eq_u32(intel_buf_size(test_buf), TEST_SIZE); intel_buf_set_ownership(test_buf, true); intel_bb_add_intel_buf(ibb, test_buf, false); -- 2.26.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() Zbigniew Kempczyński @ 2021-10-04 23:09 ` Dixit, Ashutosh 0 siblings, 0 replies; 10+ messages in thread From: Dixit, Ashutosh @ 2021-10-04 23:09 UTC (permalink / raw) To: Zbigniew Kempczyński; +Cc: igt-dev, Petri Latvala On Sun, 03 Oct 2021 22:40:55 -0700, Zbigniew Kempczyński wrote: > > To avoid confusion with intel_buf_bo_size() which for some buffers > can return size not equal to underlying gem bo size rename it to > intel_buf_size(). This patch is a simple change so: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size 2021-10-04 5:40 [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf Zbigniew Kempczyński 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() Zbigniew Kempczyński @ 2021-10-04 5:40 ` Zbigniew Kempczyński 2021-10-04 23:20 ` Dixit, Ashutosh 2021-10-04 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Clean buffer and bo size in intel_buf Patchwork 2021-10-04 15:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 1 reply; 10+ messages in thread From: Zbigniew Kempczyński @ 2021-10-04 5:40 UTC (permalink / raw) To: igt-dev; +Cc: Zbigniew Kempczyński, Petri Latvala, Ashutosh Dixit intel_buf is keeping its size which may differ to underlying gem bo size. Introduce keeping bo_size field which is used along with softpin mode - like in intel_bb. Patch also should remove previous discrepancy where intel_buf_bo_size() returned requested (not gem bo size). From now on user has an access to: 1. raw buffer size - intel_buf_size() - function returns how buffer data really takes in the memory 2. gem bo buffer size - intel_buf_bo_size() - function returns how big underlying gem object is Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> --- lib/intel_batchbuffer.c | 4 ++-- lib/intel_bufops.c | 27 ++++++++++++++++----------- lib/intel_bufops.h | 3 +++ tests/i915/api_intel_bb.c | 16 ++++++++-------- 4 files changed, 29 insertions(+), 21 deletions(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 5f41eefdb..e3e649ca3 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -2016,7 +2016,7 @@ __intel_bb_add_intel_buf(struct intel_bb *ibb, struct intel_buf *buf, } } - obj = intel_bb_add_object(ibb, buf->handle, intel_buf_size(buf), + obj = intel_bb_add_object(ibb, buf->handle, intel_buf_bo_size(buf), buf->addr.offset, alignment, write); buf->addr.offset = obj->offset; @@ -2056,7 +2056,7 @@ bool intel_bb_remove_intel_buf(struct intel_bb *ibb, struct intel_buf *buf) removed = intel_bb_remove_object(ibb, buf->handle, buf->addr.offset, - intel_buf_size(buf)); + intel_buf_bo_size(buf)); if (removed) { buf->addr.offset = INTEL_BUF_INVALID_ADDRESS; buf->ibb = NULL; diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c index 7199723bb..80c5bb80b 100644 --- a/lib/intel_bufops.c +++ b/lib/intel_bufops.c @@ -813,17 +813,16 @@ static void __intel_buf_init(struct buf_ops *bops, size = bo_size; } - /* Store real bo size to avoid mistakes in calculating it again */ + /* Store buffer size to avoid mistakes in calculating it again */ buf->size = size; + buf->handle = handle; - if (handle) - buf->handle = handle; - else { - if (!__gem_create_in_memory_regions(bops->fd, &handle, &size, region)) - buf->handle = handle; - else - buf->handle = gem_create(bops->fd, size); - } + if (!handle) + if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) + igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); + + /* Store gem bo size */ + buf->bo_size = size; set_hw_tiled(bops, buf); } @@ -1096,10 +1095,11 @@ void intel_buf_print(const struct intel_buf *buf) { igt_info("[name: %s]\n", buf->name); igt_info("[%u]: w: %u, h: %u, stride: %u, size: %" PRIx64 - ", buf-size: %" PRIx64 ", bpp: %u, tiling: %u, compress: %u\n", + ", buf-size: %" PRIx64 ", bo-size: %" PRIx64 + ", bpp: %u, tiling: %u, compress: %u\n", buf->handle, intel_buf_width(buf), intel_buf_height(buf), buf->surface[0].stride, buf->surface[0].size, - intel_buf_size(buf), buf->bpp, + intel_buf_size(buf), intel_buf_bo_size(buf), buf->bpp, buf->tiling, buf->compression); igt_info(" ccs <offset: %u, stride: %u, w: %u, h: %u> cc <offset: %u>\n", buf->ccs[0].offset, @@ -1307,6 +1307,11 @@ uint64_t intel_buf_size(const struct intel_buf *buf) return buf->size; } +uint64_t intel_buf_bo_size(const struct intel_buf *buf) +{ + return buf->bo_size; +} + static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency) { struct buf_ops *bops = calloc(1, sizeof(*bops)); diff --git a/lib/intel_bufops.h b/lib/intel_bufops.h index e09b21b2a..8148750f8 100644 --- a/lib/intel_bufops.h +++ b/lib/intel_bufops.h @@ -42,6 +42,8 @@ struct intel_buf { uint32_t ctx; } addr; + uint64_t bo_size; + /* Tracking */ struct intel_bb *ibb; struct igt_list_head link; @@ -98,6 +100,7 @@ intel_buf_ccs_height(int gen, const struct intel_buf *buf) } uint64_t intel_buf_size(const struct intel_buf *buf); +uint64_t intel_buf_bo_size(const struct intel_buf *buf); struct buf_ops *buf_ops_create(int fd); struct buf_ops *buf_ops_create_with_selftest(int fd); diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c index 492cedefd..293720b4b 100644 --- a/tests/i915/api_intel_bb.c +++ b/tests/i915/api_intel_bb.c @@ -1055,11 +1055,11 @@ static void offset_control(struct buf_ops *bops) dst1 = create_buf(bops, WIDTH, HEIGHT, COLOR_00); dst2 = create_buf(bops, WIDTH, HEIGHT, COLOR_77); - intel_bb_add_object(ibb, src->handle, intel_buf_size(src), + intel_bb_add_object(ibb, src->handle, intel_buf_bo_size(src), src->addr.offset, 0, false); - intel_bb_add_object(ibb, dst1->handle, intel_buf_size(dst1), + intel_bb_add_object(ibb, dst1->handle, intel_buf_bo_size(dst1), dst1->addr.offset, 0, true); - intel_bb_add_object(ibb, dst2->handle, intel_buf_size(dst2), + intel_bb_add_object(ibb, dst2->handle, intel_buf_bo_size(dst2), dst2->addr.offset, 0, true); intel_bb_out(ibb, MI_BATCH_BUFFER_END); @@ -1080,13 +1080,13 @@ static void offset_control(struct buf_ops *bops) intel_bb_reset(ibb, true); dst3 = create_buf(bops, WIDTH, HEIGHT, COLOR_33); - intel_bb_add_object(ibb, dst3->handle, intel_buf_size(dst3), + intel_bb_add_object(ibb, dst3->handle, intel_buf_bo_size(dst3), dst3->addr.offset, 0, true); - intel_bb_add_object(ibb, src->handle, intel_buf_size(src), + intel_bb_add_object(ibb, src->handle, intel_buf_bo_size(src), src->addr.offset, 0, false); - intel_bb_add_object(ibb, dst1->handle, intel_buf_size(dst1), + intel_bb_add_object(ibb, dst1->handle, intel_buf_bo_size(dst1), dst1->addr.offset, 0, true); - intel_bb_add_object(ibb, dst2->handle, intel_buf_size(dst2), + intel_bb_add_object(ibb, dst2->handle, intel_buf_bo_size(dst2), dst2->addr.offset, 0, true); intel_bb_out(ibb, MI_BATCH_BUFFER_END); @@ -1140,7 +1140,7 @@ static void delta_check(struct buf_ops *bops) buf = create_buf(bops, 0x1000, 0x10, COLOR_CC); buf->addr.offset = 0xfffff000; - intel_bb_add_object(ibb, buf->handle, intel_buf_size(buf), + intel_bb_add_object(ibb, buf->handle, intel_buf_bo_size(buf), buf->addr.offset, 0, false); intel_bb_out(ibb, MI_STORE_DWORD_IMM); -- 2.26.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size Zbigniew Kempczyński @ 2021-10-04 23:20 ` Dixit, Ashutosh 2021-10-05 6:52 ` Zbigniew Kempczyński 0 siblings, 1 reply; 10+ messages in thread From: Dixit, Ashutosh @ 2021-10-04 23:20 UTC (permalink / raw) To: Zbigniew Kempczyński; +Cc: igt-dev, Petri Latvala On Sun, 03 Oct 2021 22:40:56 -0700, Zbigniew Kempczyński wrote: > > intel_buf is keeping its size which may differ to underlying gem bo size. > Introduce keeping bo_size field which is used along with softpin mode > - like in intel_bb. > > Patch also should remove previous discrepancy where intel_buf_bo_size() > returned requested (not gem bo size). > > From now on user has an access to: > 1. raw buffer size - intel_buf_size() - function returns how buffer data > really takes in the memory Not sure what we mean by this since intel_buf_size() can return 0 even with a non-zero handle. See below. > 2. gem bo buffer size - intel_buf_bo_size() - function returns how big > underlying gem object is > diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c > index 7199723bb..80c5bb80b 100644 > --- a/lib/intel_bufops.c > +++ b/lib/intel_bufops.c > @@ -813,17 +813,16 @@ static void __intel_buf_init(struct buf_ops *bops, > size = bo_size; > } > > - /* Store real bo size to avoid mistakes in calculating it again */ > + /* Store buffer size to avoid mistakes in calculating it again */ > buf->size = size; > + buf->handle = handle; > > - if (handle) > - buf->handle = handle; > - else { > - if (!__gem_create_in_memory_regions(bops->fd, &handle, &size, region)) > - buf->handle = handle; > - else > - buf->handle = gem_create(bops->fd, size); > - } > + if (!handle) > + if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) > + igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); > + > + /* Store gem bo size */ > + buf->bo_size = size; The code after the above changes is like this: if (bo_size > 0) { igt_assert(bo_size >= size); size = bo_size; } /* Store buffer size to avoid mistakes in calculating it again */ buf->size = size; buf->handle = handle; if (!handle) if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); /* Store gem bo size */ buf->bo_size = size; The function is called with: a. handle == 0 or != 0 b. bo_size == 0 or != 0 As seen in __intel_buf_init callers: *** lib/intel_bufops.c: __intel_buf_init[728] static void __intel_buf_init(struct buf_ops *bops, intel_buf_init[851] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, intel_buf_init_in_region[868] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, intel_buf_init_using_handle[927] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, intel_buf_create_using_handle_and_size[1013] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, So when handle != 0 and bo_size == 0, we end with both buf->size == buf->bo_size == 0. When handle == 0 and bo_size == 0, we end up with buf->size == 0 and buf->bo_size != 0. So this is not a new issue, maybe it's ok, but I just wanted to check with you if you think all these scenarios work out ok even after introducing separate buf->size and buf->bo_size. Thanks. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size 2021-10-04 23:20 ` Dixit, Ashutosh @ 2021-10-05 6:52 ` Zbigniew Kempczyński 2021-10-05 17:51 ` Dixit, Ashutosh 0 siblings, 1 reply; 10+ messages in thread From: Zbigniew Kempczyński @ 2021-10-05 6:52 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: igt-dev, Petri Latvala On Mon, Oct 04, 2021 at 04:20:24PM -0700, Dixit, Ashutosh wrote: > On Sun, 03 Oct 2021 22:40:56 -0700, Zbigniew Kempczyński wrote: > > > > intel_buf is keeping its size which may differ to underlying gem bo size. > > Introduce keeping bo_size field which is used along with softpin mode > > - like in intel_bb. > > > > Patch also should remove previous discrepancy where intel_buf_bo_size() > > returned requested (not gem bo size). > > > > From now on user has an access to: > > 1. raw buffer size - intel_buf_size() - function returns how buffer data > > really takes in the memory > > Not sure what we mean by this since intel_buf_size() can return 0 even with > a non-zero handle. See below. > > > 2. gem bo buffer size - intel_buf_bo_size() - function returns how big > > underlying gem object is > > > diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c > > index 7199723bb..80c5bb80b 100644 > > --- a/lib/intel_bufops.c > > +++ b/lib/intel_bufops.c > > @@ -813,17 +813,16 @@ static void __intel_buf_init(struct buf_ops *bops, > > size = bo_size; > > } > > > > - /* Store real bo size to avoid mistakes in calculating it again */ > > + /* Store buffer size to avoid mistakes in calculating it again */ > > buf->size = size; > > + buf->handle = handle; > > > > - if (handle) > > - buf->handle = handle; > > - else { > > - if (!__gem_create_in_memory_regions(bops->fd, &handle, &size, region)) > > - buf->handle = handle; > > - else > > - buf->handle = gem_create(bops->fd, size); > > - } > > + if (!handle) > > + if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) > > + igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); > > + > > + /* Store gem bo size */ > > + buf->bo_size = size; > > The code after the above changes is like this: > > if (bo_size > 0) { > igt_assert(bo_size >= size); > size = bo_size; > } > > /* Store buffer size to avoid mistakes in calculating it again */ > buf->size = size; > buf->handle = handle; > > if (!handle) > if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) > igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); > > /* Store gem bo size */ > buf->bo_size = size; > > The function is called with: > > a. handle == 0 or != 0 > b. bo_size == 0 or != 0 > > As seen in __intel_buf_init callers: > > *** lib/intel_bufops.c: > __intel_buf_init[728] static void __intel_buf_init(struct buf_ops *bops, > intel_buf_init[851] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, > intel_buf_init_in_region[868] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, > intel_buf_init_using_handle[927] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, > intel_buf_create_using_handle_and_size[1013] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, > > So when handle != 0 and bo_size == 0, we end with both buf->size == buf->bo_size == 0. But we're overwriting size only when bo_size > 0: if (bo_size > 0) { igt_assert(bo_size >= size); size = bo_size; } > When handle == 0 and bo_size == 0, we end up with buf->size == 0 and buf->bo_size != 0. Regardless handle we got size > 0 always. It comes from if (compression) { ... size = buf->ccs[0].offset + aux_width * aux_height; } else { ... size = buf->surface[0].stride * ALIGN(height, align_h); } or if (bo_size > 0) { igt_assert(bo_size >= size); size = bo_size; } Asserts on the beginning guarantees we got size > 0: igt_assert(width > 0 && height > 0); igt_assert(bpp == 8 || bpp == 16 || bpp == 32 || bpp == 64); So initialization buf->size = size; won't be 0 here. > > So this is not a new issue, maybe it's ok, but I just wanted to check with > you if you think all these scenarios work out ok even after introducing > separate buf->size and buf->bo_size. Thanks. Thank you're carefully looking at the code. Please go over it one more time and verify what I've written. Maybe I just don't see something obvious... -- Zbigniew ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size 2021-10-05 6:52 ` Zbigniew Kempczyński @ 2021-10-05 17:51 ` Dixit, Ashutosh 2021-10-05 18:05 ` Zbigniew Kempczyński 0 siblings, 1 reply; 10+ messages in thread From: Dixit, Ashutosh @ 2021-10-05 17:51 UTC (permalink / raw) To: Zbigniew Kempczyński; +Cc: igt-dev, Petri Latvala On Mon, 04 Oct 2021 23:52:18 -0700, Zbigniew Kempczyński wrote: > > On Mon, Oct 04, 2021 at 04:20:24PM -0700, Dixit, Ashutosh wrote: > > On Sun, 03 Oct 2021 22:40:56 -0700, Zbigniew Kempczyński wrote: > > > > > > intel_buf is keeping its size which may differ to underlying gem bo size. > > > Introduce keeping bo_size field which is used along with softpin mode > > > - like in intel_bb. > > > > > > Patch also should remove previous discrepancy where intel_buf_bo_size() > > > returned requested (not gem bo size). > > > > > > From now on user has an access to: > > > 1. raw buffer size - intel_buf_size() - function returns how buffer data > > > really takes in the memory > > > > Not sure what we mean by this since intel_buf_size() can return 0 even with > > a non-zero handle. See below. > > > > > 2. gem bo buffer size - intel_buf_bo_size() - function returns how big > > > underlying gem object is > > > > > diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c > > > index 7199723bb..80c5bb80b 100644 > > > --- a/lib/intel_bufops.c > > > +++ b/lib/intel_bufops.c > > > @@ -813,17 +813,16 @@ static void __intel_buf_init(struct buf_ops *bops, > > > size = bo_size; > > > } > > > > > > - /* Store real bo size to avoid mistakes in calculating it again */ > > > + /* Store buffer size to avoid mistakes in calculating it again */ > > > buf->size = size; > > > + buf->handle = handle; > > > > > > - if (handle) > > > - buf->handle = handle; > > > - else { > > > - if (!__gem_create_in_memory_regions(bops->fd, &handle, &size, region)) > > > - buf->handle = handle; > > > - else > > > - buf->handle = gem_create(bops->fd, size); > > > - } > > > + if (!handle) > > > + if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) > > > + igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); > > > + > > > + /* Store gem bo size */ > > > + buf->bo_size = size; > > > > The code after the above changes is like this: > > > > if (bo_size > 0) { > > igt_assert(bo_size >= size); > > size = bo_size; > > } > > > > /* Store buffer size to avoid mistakes in calculating it again */ > > buf->size = size; > > buf->handle = handle; > > > > if (!handle) > > if (__gem_create_in_memory_regions(bops->fd, &buf->handle, &size, region)) > > igt_assert_eq(__gem_create(bops->fd, &size, &buf->handle), 0); > > > > /* Store gem bo size */ > > buf->bo_size = size; > > > > The function is called with: > > > > a. handle == 0 or != 0 > > b. bo_size == 0 or != 0 > > > > As seen in __intel_buf_init callers: > > > > *** lib/intel_bufops.c: > > __intel_buf_init[728] static void __intel_buf_init(struct buf_ops *bops, > > intel_buf_init[851] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, > > intel_buf_init_in_region[868] __intel_buf_init(bops, 0, buf, width, height, bpp, alignment, > > intel_buf_init_using_handle[927] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, > > intel_buf_create_using_handle_and_size[1013] __intel_buf_init(bops, handle, buf, width, height, bpp, alignment, > > > > So when handle != 0 and bo_size == 0, we end with both buf->size == buf->bo_size == 0. > > But we're overwriting size only when bo_size > 0: > > if (bo_size > 0) { > igt_assert(bo_size >= size); > size = bo_size; > } > > > When handle == 0 and bo_size == 0, we end up with buf->size == 0 and buf->bo_size != 0. > > Regardless handle we got size > 0 always. It comes from > > if (compression) { > ... > size = buf->ccs[0].offset + aux_width * aux_height; > } else { > ... > size = buf->surface[0].stride * ALIGN(height, align_h); > } > > or > > if (bo_size > 0) { > igt_assert(bo_size >= size); > size = bo_size; > } > > Asserts on the beginning guarantees we got size > 0: > > igt_assert(width > 0 && height > 0); > igt_assert(bpp == 8 || bpp == 16 || bpp == 32 || bpp == 64); > > So initialization > > buf->size = size; > > won't be 0 here. > > > > > So this is not a new issue, maybe it's ok, but I just wanted to check with > > you if you think all these scenarios work out ok even after introducing > > separate buf->size and buf->bo_size. Thanks. > > Thank you're carefully looking at the code. Please go over it one more time > and verify what I've written. Maybe I just don't see something obvious... Sorry of course you are right, I completely missed size is being set as you indicate above. So this is also: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size 2021-10-05 17:51 ` Dixit, Ashutosh @ 2021-10-05 18:05 ` Zbigniew Kempczyński 0 siblings, 0 replies; 10+ messages in thread From: Zbigniew Kempczyński @ 2021-10-05 18:05 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: igt-dev, Petri Latvala On Tue, Oct 05, 2021 at 10:51:46AM -0700, Dixit, Ashutosh wrote: <cut> > > > > > > So this is not a new issue, maybe it's ok, but I just wanted to check with > > > you if you think all these scenarios work out ok even after introducing > > > separate buf->size and buf->bo_size. Thanks. > > > > Thank you're carefully looking at the code. Please go over it one more time > > and verify what I've written. Maybe I just don't see something obvious... > > Sorry of course you are right, I completely missed size is being set as you > indicate above. So this is also: > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Thanks for the review, series pushed. -- Zbigniew ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Clean buffer and bo size in intel_buf 2021-10-04 5:40 [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf Zbigniew Kempczyński 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() Zbigniew Kempczyński 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size Zbigniew Kempczyński @ 2021-10-04 12:59 ` Patchwork 2021-10-04 15:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2021-10-04 12:59 UTC (permalink / raw) To: Zbigniew Kempczyński; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 5475 bytes --] == Series Details == Series: Clean buffer and bo size in intel_buf URL : https://patchwork.freedesktop.org/series/95388/ State : success == Summary == CI Bug Log - changes from IGT_6229 -> IGTPW_6277 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/index.html Known issues ------------ Here are the changes found in IGTPW_6277 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@nop-compute0: - fi-ilk-650: NOTRUN -> [SKIP][1] ([fdo#109271]) +35 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-ilk-650/igt@amdgpu/amd_cs_nop@nop-compute0.html * igt@amdgpu/amd_cs_nop@sync-fork-compute0: - fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html * igt@core_hotunplug@unbind-rebind: - fi-bdw-samus: NOTRUN -> [WARN][3] ([i915#3718]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-bdw-samus/igt@core_hotunplug@unbind-rebind.html * igt@kms_chamelium@dp-hpd-fast: - fi-ilk-650: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-ilk-650/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_chamelium@hdmi-edid-read: - fi-bdw-samus: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-bdw-samus/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-bdw-samus: NOTRUN -> [SKIP][6] ([fdo#109271]) +29 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-bdw-samus/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@prime_vgem@basic-userptr: - fi-pnv-d510: NOTRUN -> [SKIP][7] ([fdo#109271]) +48 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-pnv-d510/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@gem_exec_parallel@engines@userptr: - fi-pnv-d510: [INCOMPLETE][8] ([i915#299]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html * igt@gem_exec_suspend@basic-s3: - fi-bdw-samus: [INCOMPLETE][10] ([i915#146] / [i915#4173]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-bdw-samus/igt@gem_exec_suspend@basic-s3.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-bdw-samus/igt@gem_exec_suspend@basic-s3.html - fi-tgl-1115g4: [FAIL][12] ([i915#1888]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@hangcheck: - fi-snb-2600: [INCOMPLETE][14] ([i915#3921]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-snb-2600/igt@i915_selftest@live@hangcheck.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-snb-2600/igt@i915_selftest@live@hangcheck.html * igt@kms_chamelium@hdmi-edid-read: - fi-kbl-7500u: [FAIL][16] ([i915#3449]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [DMESG-WARN][18] ([i915#95]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299 [i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449 [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#4173]: https://gitlab.freedesktop.org/drm/intel/issues/4173 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (33 -> 33) ------------------------------ Additional (1): fi-ilk-650 Missing (1): fi-bsw-cyan Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6229 -> IGTPW_6277 CI-20190529: 20190529 CI_DRM_10681: fe9b639a95a08713c8ee4ef110ce6a6388c9f9f2 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_6277: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/index.html IGT_6229: dff598c339a2da647f15c86d0015e16378c7ea9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/index.html [-- Attachment #2: Type: text/html, Size: 6790 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Clean buffer and bo size in intel_buf 2021-10-04 5:40 [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf Zbigniew Kempczyński ` (2 preceding siblings ...) 2021-10-04 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Clean buffer and bo size in intel_buf Patchwork @ 2021-10-04 15:45 ` Patchwork 3 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2021-10-04 15:45 UTC (permalink / raw) To: Zbigniew Kempczyński; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 30255 bytes --] == Series Details == Series: Clean buffer and bo size in intel_buf URL : https://patchwork.freedesktop.org/series/95388/ State : success == Summary == CI Bug Log - changes from IGT_6229_full -> IGTPW_6277_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_6277_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_6277_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_6277_full: ### IGT changes ### #### Warnings #### * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [SKIP][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html Known issues ------------ Here are the changes found in IGTPW_6277_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +5 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb7/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_eio@in-flight-contexts-1us: - shard-tglb: [PASS][4] -> [TIMEOUT][5] ([i915#3063]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_eio@unwedge-stress: - shard-snb: NOTRUN -> [FAIL][6] ([i915#3354]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: NOTRUN -> [FAIL][7] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-none@rcs0: - shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk9/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: NOTRUN -> [FAIL][10] ([i915#2842]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [PASS][11] -> [SKIP][12] ([fdo#109271]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html - shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: NOTRUN -> [FAIL][15] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-iclb: NOTRUN -> [FAIL][16] ([i915#2849]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109313]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html - shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109313]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb3/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_exec_schedule@semaphore-codependency: - shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +458 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb6/igt@gem_exec_schedule@semaphore-codependency.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: NOTRUN -> [DMESG-WARN][20] ([i915#180]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl6/igt@gem_exec_suspend@basic-s3.html * igt@gem_exec_whisper@basic-normal-all: - shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#118] / [i915#95]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk8/igt@gem_exec_whisper@basic-normal-all.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk9/igt@gem_exec_whisper@basic-normal-all.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][23] -> [SKIP][24] ([i915#2190]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb5/igt@gem_huc_copy@huc-copy.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb7/igt@gem_huc_copy@huc-copy.html - shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#2190]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl3/igt@gem_huc_copy@huc-copy.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][26] -> [FAIL][27] ([i915#644]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][28] ([i915#2658]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl2/igt@gem_pread@exhaustion.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][29] ([i915#768]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb6/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: NOTRUN -> [DMESG-WARN][30] ([i915#180]) +1 similar issue [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl7/igt@gem_workarounds@suspend-resume-context.html * igt@gen3_render_linear_blits: - shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109289]) +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb3/igt@gen3_render_linear_blits.html * igt@gen3_render_mixed_blits: - shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109289]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@gen3_render_mixed_blits.html * igt@gen9_exec_parse@bb-chained: - shard-tglb: NOTRUN -> [SKIP][33] ([i915#2856]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@gen9_exec_parse@bb-chained.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: NOTRUN -> [FAIL][34] ([i915#454]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html - shard-tglb: NOTRUN -> [FAIL][35] ([i915#454]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb8/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-tglb: NOTRUN -> [WARN][36] ([i915#2681] / [i915#2684]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb6/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109293] / [fdo#109506]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb8/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html - shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109506] / [i915#2411]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb1/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][39] -> [INCOMPLETE][40] ([i915#3921]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-snb6/igt@i915_selftest@live@hangcheck.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-iclb: NOTRUN -> [SKIP][41] ([i915#1769]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb2/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_big_fb@linear-32bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111614]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb6/igt@kms_big_fb@linear-32bpp-rotate-270.html * igt@kms_big_fb@x-tiled-16bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110725] / [fdo#111614]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb7/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip: - shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3777]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][45] ([fdo#110723]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb6/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip: - shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3777]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html * igt@kms_big_joiner@2x-modeset: - shard-iclb: NOTRUN -> [SKIP][47] ([i915#2705]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb3/igt@kms_big_joiner@2x-modeset.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][48] ([i915#3689] / [i915#3886]) +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][49] ([i915#3689]) +13 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs.html * igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk2/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html - shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278] / [i915#3886]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886]) +13 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3886]) +6 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl1/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@dp-hpd-fast: - shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +6 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk8/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_chamelium@hdmi-audio: - shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +6 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb4/igt@kms_chamelium@hdmi-audio.html * igt@kms_chamelium@vga-edid-read: - shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +20 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl7/igt@kms_chamelium@vga-edid-read.html * igt@kms_chamelium@vga-hpd-without-ddc: - shard-snb: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +19 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb7/igt@kms_chamelium@vga-hpd-without-ddc.html * igt@kms_color@pipe-d-ctm-blue-to-red: - shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#1149]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb8/igt@kms_color@pipe-d-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-a-degamma: - shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +15 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl1/igt@kms_color_chamelium@pipe-a-degamma.html * igt@kms_color_chamelium@pipe-b-ctm-limited-range: - shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +9 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb8/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html * igt@kms_color_chamelium@pipe-d-ctm-blue-to-red: - shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb7/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html * igt@kms_concurrent@pipe-d: - shard-tglb: NOTRUN -> [FAIL][62] ([i915#1385]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb3/igt@kms_concurrent@pipe-d.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-iclb: NOTRUN -> [SKIP][63] ([i915#3116]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@kms_content_protection@dp-mst-lic-type-0.html - shard-tglb: NOTRUN -> [SKIP][64] ([i915#3116]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb6/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][65] ([i915#1319]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl1/igt@kms_content_protection@legacy.html * igt@kms_content_protection@lic: - shard-tglb: NOTRUN -> [SKIP][66] ([fdo#111828]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278] / [fdo#109279]) +2 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][68] -> [DMESG-WARN][69] ([i915#180]) +6 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html - shard-tglb: [PASS][70] -> [INCOMPLETE][71] ([i915#2411] / [i915#2828] / [i915#456]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-32x10-random: - shard-tglb: NOTRUN -> [SKIP][72] ([i915#3359]) +3 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html * igt@kms_cursor_crc@pipe-c-cursor-32x32-random: - shard-tglb: NOTRUN -> [SKIP][73] ([i915#3319]) +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-random.html * igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen: - shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271]) +182 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl1/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109279] / [i915#3359]) +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html * igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge: - shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109278]) +24 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb2/igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge.html * igt@kms_cursor_legacy@cursora-vs-flipb-atomic: - shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109274] / [fdo#109278]) +4 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb8/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111825]) +36 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a: - shard-tglb: NOTRUN -> [SKIP][79] ([i915#3788]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html * igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2: - shard-glk: [PASS][80] -> [FAIL][81] ([i915#79]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible: - shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109274]) +6 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb7/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [PASS][83] -> [DMESG-WARN][84] ([i915#180]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-tglb: NOTRUN -> [SKIP][85] ([i915#2587]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc: - shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109280]) +17 similar issues [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533]) +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html - shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265]) +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-glk: NOTRUN -> [FAIL][90] ([i915#265]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html - shard-apl: NOTRUN -> [FAIL][91] ([i915#265]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html - shard-kbl: NOTRUN -> [FAIL][92] ([i915#265]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: NOTRUN -> [FAIL][93] ([fdo#108145] / [i915#265]) +3 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-glk: NOTRUN -> [FAIL][94] ([fdo#108145] / [i915#265]) +1 similar issue [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_cursor@pipe-d-viewport-size-256: - shard-glk: NOTRUN -> [SKIP][95] ([fdo#109271]) +75 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk6/igt@kms_plane_cursor@pipe-d-viewport-size-256.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: NOTRUN -> [SKIP][96] ([i915#3536]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_plane_lowres@pipe-b-tiling-y: - shard-tglb: NOTRUN -> [SKIP][97] ([i915#3536]) +2 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb6/igt@kms_plane_lowres@pipe-b-tiling-y.html * igt@kms_plane_multiple@atomic-pipe-a-tiling-x: - shard-glk: [PASS][98] -> [FAIL][99] ([i915#1888]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk5/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk5/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-glk: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#658]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +5 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: - shard-kbl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#658]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html - shard-tglb: NOTRUN -> [SKIP][103] ([i915#2920]) +1 similar issue [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109441]) +3 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_psr@psr2_sprite_mmap_cpu: - shard-tglb: NOTRUN -> [FAIL][105] ([i915#132] / [i915#3467]) +3 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb2/igt@kms_psr@psr2_sprite_mmap_cpu.html * igt@kms_psr@psr2_sprite_plane_onoff: - shard-iclb: [PASS][106] -> [SKIP][107] ([fdo#109441]) +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb5/igt@kms_psr@psr2_sprite_plane_onoff.html * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0: - shard-tglb: NOTRUN -> [SKIP][108] ([fdo#111615]) +4 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][109] ([i915#31]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-snb5/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-d-ts-continuation-idle: - shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271]) +281 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl2/igt@kms_vblank@pipe-d-ts-continuation-idle.html * igt@kms_writeback@writeback-fb-id: - shard-glk: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2437]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk9/igt@kms_writeback@writeback-fb-id.html - shard-tglb: NOTRUN -> [SKIP][112] ([i915#2437]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb5/igt@kms_writeback@writeback-fb-id.html * igt@kms_writeback@writeback-pixel-formats: - shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2437]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl2/igt@kms_writeback@writeback-pixel-formats.html - shard-apl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2437]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl8/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-c-source-rg: - shard-iclb: NOTRUN -> [SKIP][115] ([i915#2530]) +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb5/igt@nouveau_crc@pipe-c-source-rg.html - shard-tglb: NOTRUN -> [SKIP][116] ([i915#2530]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb1/igt@nouveau_crc@pipe-c-source-rg.html * igt@perf_pmu@event-wait@rcs0: - shard-tglb: NOTRUN -> [SKIP][117] ([fdo#112283]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb1/igt@perf_pmu@event-wait@rcs0.html * igt@prime_nv_pcopy@test3_5: - shard-tglb: NOTRUN -> [SKIP][118] ([fdo#109291]) +2 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb3/igt@prime_nv_pcopy@test3_5.html * igt@sysfs_clients@fair-3: - shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@sysfs_clients@fair-3.html * igt@sysfs_clients@recycle-many: - shard-apl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994]) +3 similar issues [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-apl7/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@gem_eio@unwedge-stress: - shard-iclb: [TIMEOUT][121] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][122] [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-iclb5/igt@gem_eio@unwedge-stress.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-iclb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [FAIL][123] ([i915#2842]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html - shard-glk: [FAIL][125] ([i915#2842]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk7/igt@gem_exec_fair@basic-pace@rcs0.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk2/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-tglb: [FAIL][127] ([i915#2842]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-tglb1/igt@gem_exec_fair@basic-pace@vecs0.html * igt@kms_addfb_basic@addfb25-y-tiled-legacy: - shard-kbl: [DMESG-WARN][129] ([i915#62] / [i915#92]) -> [PASS][130] +12 similar issues [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-kbl6/igt@kms_addfb_basic@addfb25-y-tiled-legacy.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-kbl3/igt@kms_addfb_basic@addfb25-y-tiled-legacy.html * igt@kms_big_fb@x-tiled-32bpp-rotate-0: - shard-glk: [DMESG-WARN][131] ([i915#118] / [i915#95]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk9/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque: - shard-glk: [FAIL][133] ([i915#3444]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-glk8/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/shard-glk9/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html - shard-tglb: [FAIL][135] ([i915#2124] / [i915#4024]) -> [PASS][136] [135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6229/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html [136]: https://intel-gfx-ci.01.org/ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6277/index.html [-- Attachment #2: Type: text/html, Size: 33895 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-05 18:06 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-04 5:40 [igt-dev] [PATCH i-g-t 0/2] Clean buffer and bo size in intel_buf Zbigniew Kempczyński 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 1/2] lib/intel_bufops: Rename intel_buf_bo_size() -> intel_buf_size() Zbigniew Kempczyński 2021-10-04 23:09 ` Dixit, Ashutosh 2021-10-04 5:40 ` [igt-dev] [PATCH i-g-t 2/2] lib/intel_bufops: Store gem bo size Zbigniew Kempczyński 2021-10-04 23:20 ` Dixit, Ashutosh 2021-10-05 6:52 ` Zbigniew Kempczyński 2021-10-05 17:51 ` Dixit, Ashutosh 2021-10-05 18:05 ` Zbigniew Kempczyński 2021-10-04 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Clean buffer and bo size in intel_buf Patchwork 2021-10-04 15:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.