[Buildroot] [PATCH 1/1] package/python-urwid: depend on python3

[Buildroot] [PATCH 1/1] package/python-urwid: depend on python3

[Asaf Kahlon]

Although the package claims to support both python2 and python3,
there are some places which contain python3-only code (mainly
asyncio-related).
We can try to tweak some of the files in order to make it work with
python2, but it doesn't worth the effort since python2 isn't maintained
for a long time.

Update the reverse recursive dependencies accordingly.

Fixes:
 - http://autobuild.buildroot.net/results/356c6b09566c6020dc320eb89da791581571cb7f/

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 package/python-configshell-fb/Config.in | 4 ++--
 package/python-urwid/Config.in          | 1 +
 package/targetcli-fb/Config.in          | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/python-configshell-fb/Config.in b/package/python-configshell-fb/Config.in
index 90a295fc8d..a0326e9150 100644
--- a/package/python-configshell-fb/Config.in
+++ b/package/python-configshell-fb/Config.in
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
 	bool "python-configshell-fb"
+	depends on BR2_PACKAGE_PYTHON3 # python-urwid
 	select BR2_PACKAGE_PYTHON_PYPARSING
-	select BR2_PACKAGE_PYTHON3_READLINE if BR2_PACKAGE_PYTHON3
-	select BR2_PACKAGE_PYTHON_READLINE if BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON3_READLINE
 	select BR2_PACKAGE_PYTHON_SIX
 	select BR2_PACKAGE_PYTHON_URWID
 	help
diff --git a/package/python-urwid/Config.in b/package/python-urwid/Config.in
index f584a9258d..8fd2cac694 100644
--- a/package/python-urwid/Config.in
+++ b/package/python-urwid/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_URWID
 	bool "python-urwid"
+	depends on BR2_PACAKGE_PYTHON3
 	help
 	  Urwid is a console user interface library for Python
 
diff --git a/package/targetcli-fb/Config.in b/package/targetcli-fb/Config.in
index 24ff3145f6..04c6a1ac09 100644
--- a/package/targetcli-fb/Config.in
+++ b/package/targetcli-fb/Config.in
@@ -1,9 +1,9 @@
 comment "targetcli-fb depends on Python"
-	depends on !BR2_PACKAGE_PYTHON && !BR2_PACKAGE_PYTHON3
+	depends on !BR2_PACKAGE_PYTHON3
 
 config BR2_PACKAGE_TARGETCLI_FB
 	bool "targetcli-fb"
-	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+	depends on BR2_PACKAGE_PYTHON3 # python-configshell-fb
 	select BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
 	select BR2_PACKAGE_PYTHON_RTSLIB_FB
 	select BR2_PACKAGE_PYTHON_SIX
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/python-urwid: depend on python3

[Arnout Vandecappelle]

On 06/10/2021 18:33, Asaf Kahlon wrote:
> Although the package claims to support both python2 and python3,
> there are some places which contain python3-only code (mainly
> asyncio-related).
> We can try to tweak some of the files in order to make it work with
> python2, but it doesn't worth the effort since python2 isn't maintained
> for a long time.
> 
> Update the reverse recursive dependencies accordingly.
> 
> Fixes:
>   - http://autobuild.buildroot.net/results/356c6b09566c6020dc320eb89da791581571cb7f/
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/python-configshell-fb/Config.in | 4 ++--
>   package/python-urwid/Config.in          | 1 +
>   package/targetcli-fb/Config.in          | 4 ++--
>   3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/python-configshell-fb/Config.in b/package/python-configshell-fb/Config.in
> index 90a295fc8d..a0326e9150 100644
> --- a/package/python-configshell-fb/Config.in
> +++ b/package/python-configshell-fb/Config.in
> @@ -1,8 +1,8 @@
>   config BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
>   	bool "python-configshell-fb"
> +	depends on BR2_PACKAGE_PYTHON3 # python-urwid
>   	select BR2_PACKAGE_PYTHON_PYPARSING
> -	select BR2_PACKAGE_PYTHON3_READLINE if BR2_PACKAGE_PYTHON3
> -	select BR2_PACKAGE_PYTHON_READLINE if BR2_PACKAGE_PYTHON
> +	select BR2_PACKAGE_PYTHON3_READLINE
>   	select BR2_PACKAGE_PYTHON_SIX
>   	select BR2_PACKAGE_PYTHON_URWID
>   	help
> diff --git a/package/python-urwid/Config.in b/package/python-urwid/Config.in
> index f584a9258d..8fd2cac694 100644
> --- a/package/python-urwid/Config.in
> +++ b/package/python-urwid/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_PYTHON_URWID
>   	bool "python-urwid"
> +	depends on BR2_PACAKGE_PYTHON3
>   	help
>   	  Urwid is a console user interface library for Python
>   
> diff --git a/package/targetcli-fb/Config.in b/package/targetcli-fb/Config.in
> index 24ff3145f6..04c6a1ac09 100644
> --- a/package/targetcli-fb/Config.in
> +++ b/package/targetcli-fb/Config.in
> @@ -1,9 +1,9 @@
>   comment "targetcli-fb depends on Python"
> -	depends on !BR2_PACKAGE_PYTHON && !BR2_PACKAGE_PYTHON3
> +	depends on !BR2_PACKAGE_PYTHON3
>   
>   config BR2_PACKAGE_TARGETCLI_FB
>   	bool "targetcli-fb"
> -	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> +	depends on BR2_PACKAGE_PYTHON3 # python-configshell-fb
>   	select BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
>   	select BR2_PACKAGE_PYTHON_RTSLIB_FB
>   	select BR2_PACKAGE_PYTHON_SIX
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot