From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Krzysztof Opasiak <k.opasiak@samsung.com>, Mark Greer <mgreer@animalcreek.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [linux-nfc] [RESEND PATCH v2 5/7] nfc: st21nfca: drop unneeded debug prints Date: Thu, 7 Oct 2021 15:30:19 +0200 [thread overview] Message-ID: <20211007133021.32704-6-krzysztof.kozlowski@canonical.com> (raw) In-Reply-To: <20211007133021.32704-1-krzysztof.kozlowski@canonical.com> ftrace is a preferred and standard way to debug entering and exiting functions so drop useless debug prints. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/nfc/st21nfca/i2c.c | 4 ---- drivers/nfc/st21nfca/se.c | 4 ---- 2 files changed, 8 deletions(-) diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index 279d88128b2e..f126ce96a7df 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -421,7 +421,6 @@ static int st21nfca_hci_i2c_read(struct st21nfca_i2c_phy *phy, static irqreturn_t st21nfca_hci_irq_thread_fn(int irq, void *phy_id) { struct st21nfca_i2c_phy *phy = phy_id; - struct i2c_client *client; int r; @@ -430,9 +429,6 @@ static irqreturn_t st21nfca_hci_irq_thread_fn(int irq, void *phy_id) return IRQ_NONE; } - client = phy->i2c_dev; - dev_dbg(&client->dev, "IRQ\n"); - if (phy->hard_fault != 0) return IRQ_HANDLED; diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index c8bdf078d111..a43fc4117fa5 100644 --- a/drivers/nfc/st21nfca/se.c +++ b/drivers/nfc/st21nfca/se.c @@ -257,8 +257,6 @@ static void st21nfca_se_wt_timeout(struct timer_list *t) struct st21nfca_hci_info *info = from_timer(info, t, se_info.bwi_timer); - pr_debug("\n"); - info->se_info.bwi_active = false; if (!info->se_info.xch_error) { @@ -278,8 +276,6 @@ static void st21nfca_se_activation_timeout(struct timer_list *t) struct st21nfca_hci_info *info = from_timer(info, t, se_info.se_active_timer); - pr_debug("\n"); - info->se_info.se_active = false; complete(&info->se_info.req_completion); -- 2.30.2 _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
WARNING: multiple messages have this Message-ID
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Krzysztof Opasiak <k.opasiak@samsung.com>, Mark Greer <mgreer@animalcreek.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [RESEND PATCH v2 5/7] nfc: st21nfca: drop unneeded debug prints Date: Thu, 7 Oct 2021 15:30:19 +0200 [thread overview] Message-ID: <20211007133021.32704-6-krzysztof.kozlowski@canonical.com> (raw) In-Reply-To: <20211007133021.32704-1-krzysztof.kozlowski@canonical.com> ftrace is a preferred and standard way to debug entering and exiting functions so drop useless debug prints. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/nfc/st21nfca/i2c.c | 4 ---- drivers/nfc/st21nfca/se.c | 4 ---- 2 files changed, 8 deletions(-) diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index 279d88128b2e..f126ce96a7df 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -421,7 +421,6 @@ static int st21nfca_hci_i2c_read(struct st21nfca_i2c_phy *phy, static irqreturn_t st21nfca_hci_irq_thread_fn(int irq, void *phy_id) { struct st21nfca_i2c_phy *phy = phy_id; - struct i2c_client *client; int r; @@ -430,9 +429,6 @@ static irqreturn_t st21nfca_hci_irq_thread_fn(int irq, void *phy_id) return IRQ_NONE; } - client = phy->i2c_dev; - dev_dbg(&client->dev, "IRQ\n"); - if (phy->hard_fault != 0) return IRQ_HANDLED; diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index c8bdf078d111..a43fc4117fa5 100644 --- a/drivers/nfc/st21nfca/se.c +++ b/drivers/nfc/st21nfca/se.c @@ -257,8 +257,6 @@ static void st21nfca_se_wt_timeout(struct timer_list *t) struct st21nfca_hci_info *info = from_timer(info, t, se_info.bwi_timer); - pr_debug("\n"); - info->se_info.bwi_active = false; if (!info->se_info.xch_error) { @@ -278,8 +276,6 @@ static void st21nfca_se_activation_timeout(struct timer_list *t) struct st21nfca_hci_info *info = from_timer(info, t, se_info.se_active_timer); - pr_debug("\n"); - info->se_info.se_active = false; complete(&info->se_info.req_completion); -- 2.30.2
next prev parent reply other threads:[~2021-10-07 13:38 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-07 13:30 [RESEND PATCH v2 0/7] nfc: minor printk cleanup Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-07 13:30 ` [RESEND PATCH v2 1/7] nfc: drop unneeded debug prints Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-07 13:30 ` [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-08 10:33 ` Joe Perches 2021-10-08 10:46 ` Krzysztof Kozlowski 2021-10-08 10:46 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-08 10:54 ` Joe Perches 2021-10-07 13:30 ` [RESEND PATCH v2 3/7] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-07 13:30 ` [RESEND PATCH v2 4/7] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-07 13:30 ` Krzysztof Kozlowski [this message] 2021-10-07 13:30 ` [RESEND PATCH v2 5/7] nfc: st21nfca: " Krzysztof Kozlowski 2021-10-07 13:30 ` [RESEND PATCH v2 6/7] nfc: trf7970a: " Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-07 13:30 ` [RESEND PATCH v2 7/7] nfc: microread: " Krzysztof Kozlowski 2021-10-07 13:30 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-08 10:16 ` [RESEND PATCH v2 0/7] nfc: minor printk cleanup David Miller 2021-10-08 10:18 ` Krzysztof Kozlowski 2021-10-08 10:18 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-10 11:36 ` Krzysztof Kozlowski 2021-10-10 11:36 ` [linux-nfc] " Krzysztof Kozlowski 2021-10-11 13:03 ` Jakub Kicinski 2021-10-11 13:33 ` Krzysztof Kozlowski 2021-10-11 13:33 ` [linux-nfc] " Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211007133021.32704-6-krzysztof.kozlowski@canonical.com \ --to=krzysztof.kozlowski@canonical.com \ --cc=davem@davemloft.net \ --cc=k.opasiak@samsung.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfc@lists.01.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mgreer@animalcreek.com \ --cc=netdev@vger.kernel.org \ --subject='Re: [linux-nfc] [RESEND PATCH v2 5/7] nfc: st21nfca: drop unneeded debug prints' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.