All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gnupg: Add gpg status output to debug logging
@ 2021-10-07 16:58 Kees Cook
  2021-10-07 18:10 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2021-10-07 16:58 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: Kees Cook, tools

There wasn't an easy way to see how a failure was being determined by
GPG, so add the entire GPG status output to the debug log.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 patatt/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/patatt/__init__.py b/patatt/__init__.py
index 2e33bce209e2..6f4591973751 100644
--- a/patatt/__init__.py
+++ b/patatt/__init__.py
@@ -371,6 +371,7 @@ class DevsigHeader:
         signtime = ''
         signkey = ''
 
+        logger.debug('GNUPG status:\n\t%s' % ("\n\t".join(status.decode().strip().split('\n'))))
         gs_matches = re.search(rb'^\[GNUPG:] GOODSIG ([0-9A-F]+)\s+(.*)$', status, flags=re.M)
         if gs_matches:
             good = True
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnupg: Add gpg status output to debug logging
  2021-10-07 16:58 [PATCH] gnupg: Add gpg status output to debug logging Kees Cook
@ 2021-10-07 18:10 ` Konstantin Ryabitsev
  0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Ryabitsev @ 2021-10-07 18:10 UTC (permalink / raw)
  To: Kees Cook; +Cc: tools

On Thu, 7 Oct 2021 09:58:01 -0700, Kees Cook wrote:
> There wasn't an easy way to see how a failure was being determined by
> GPG, so add the entire GPG status output to the debug log.
> 
> 

Applied with minor stylistic changes to both main and stable-0.4.y,
thanks!

[1/1] gnupg: Add gpg status output to debug logging
      commit: a7ec0c10429bb1e14591e33c08baf3aee28c26dd

Best regards,
-- 
Konstantin Ryabitsev <konstantin@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-07 18:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 16:58 [PATCH] gnupg: Add gpg status output to debug logging Kees Cook
2021-10-07 18:10 ` Konstantin Ryabitsev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.