* [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()
@ 2021-10-08 11:20 Shunsuke Mie
2021-10-08 12:09 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Shunsuke Mie @ 2021-10-08 11:20 UTC (permalink / raw)
To: Sumit Semwal
Cc: mie, Christian König, linux-media, dri-devel, linaro-mm-sig,
linux-kernel
A comment for the dma_buf_vmap/vunmap() is not catching up a
corresponding implementation.
Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
---
drivers/dma-buf/dma-buf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index beb504a92d60..7b619998f03a 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
*
* Interfaces::
*
- * void \*dma_buf_vmap(struct dma_buf \*dmabuf)
- * void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
+ * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
+ * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
*
* The vmap call can fail if there is no vmap support in the exporter, or if
* it runs out of vmalloc space. Note that the dma-buf layer keeps a reference
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()
2021-10-08 11:20 [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap() Shunsuke Mie
@ 2021-10-08 12:09 ` Christian König
2021-10-13 12:28 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2021-10-08 12:09 UTC (permalink / raw)
To: Shunsuke Mie, Sumit Semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 08.10.21 um 13:20 schrieb Shunsuke Mie:
> A comment for the dma_buf_vmap/vunmap() is not catching up a
> corresponding implementation.
>
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/dma-buf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index beb504a92d60..7b619998f03a 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
> *
> * Interfaces::
> *
> - * void \*dma_buf_vmap(struct dma_buf \*dmabuf)
> - * void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
> + * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> + * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> *
> * The vmap call can fail if there is no vmap support in the exporter, or if
> * it runs out of vmalloc space. Note that the dma-buf layer keeps a reference
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()
2021-10-08 12:09 ` Christian König
@ 2021-10-13 12:28 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2021-10-13 12:28 UTC (permalink / raw)
To: Christian König
Cc: Shunsuke Mie, Sumit Semwal, linux-media, dri-devel,
linaro-mm-sig, linux-kernel
On Fri, Oct 08, 2021 at 02:09:41PM +0200, Christian König wrote:
> Am 08.10.21 um 13:20 schrieb Shunsuke Mie:
> > A comment for the dma_buf_vmap/vunmap() is not catching up a
> > corresponding implementation.
> >
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
You're also pushing?
-Daniel
>
> > ---
> > drivers/dma-buf/dma-buf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> > index beb504a92d60..7b619998f03a 100644
> > --- a/drivers/dma-buf/dma-buf.c
> > +++ b/drivers/dma-buf/dma-buf.c
> > @@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
> > *
> > * Interfaces::
> > *
> > - * void \*dma_buf_vmap(struct dma_buf \*dmabuf)
> > - * void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
> > + * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > + * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > *
> > * The vmap call can fail if there is no vmap support in the exporter, or if
> > * it runs out of vmalloc space. Note that the dma-buf layer keeps a reference
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-13 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 11:20 [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap() Shunsuke Mie
2021-10-08 12:09 ` Christian König
2021-10-13 12:28 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.