From: Miquel Raynal <miquel.raynal@bootlin.com> To: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, <linux-mtd@lists.infradead.org> Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>, Xiangsheng Hou <Xiangsheng.Hou@mediatek.com>, Boris Brezillon <bbrezillon@kernel.org>, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, jaimeliao@mxic.com.tw, juliensu@mxic.com.tw, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [RFC PATCH 00/10] Macronix ECC engine Date: Fri, 8 Oct 2021 18:22:18 +0200 [thread overview] Message-ID: <20211008162228.1753083-1-miquel.raynal@bootlin.com> (raw) Hello all, This series is not 100% stable yet but I believe it should be sent out in order to help other people trying to use the ECC framework with a SPI controller. Basically, Macronix ECC engine can be used as an external engine (takes the data, proceeds to the calculations, writes back the ECC bytes) or as a pipelined engine doing on-the-fly calculations (which is very common in the raw NAND world). In the device tree, the ECC engine should be described as a separated DT node. Then: * external case: the flash node should provide a nand-ecc-engine property pointing to the ECC engine node. * pipelined case: the flash node should provide a nand-ecc-engine property pointing to the SPI controller, itself with another nand-ecc-engine property pointing at the ECC engine node. I will resubmit this later when I will be done validating the hardware and the driver. Cheers, Miquèl Mason Yang (1): mtd: spinand: macronix: Use random program load Miquel Raynal (9): mtd: spinand: Fix comment dt-bindings: vendor-prefixes: Update Macronix prefix dt-bindings: mtd: Describe Macronix NAND ECC engine mtd: nand: ecc: Add infrastructure to support hardware engines mtd: nand: mxic-ecc: Add Macronix external ECC engine support mtd: nand: mxic-ecc: Support SPI pipelined mode spi: mxic: Fix the transmit path spi: mxic: Add support for direct mapping spi: mxic: Add support for pipelined ECC operations .../bindings/mtd/mxic,nand-ecc-engine.yaml | 78 ++ .../devicetree/bindings/vendor-prefixes.yaml | 3 + drivers/mtd/nand/Kconfig | 6 + drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/core.c | 10 +- drivers/mtd/nand/ecc-mxic.c | 797 ++++++++++++++++++ drivers/mtd/nand/ecc.c | 89 ++ drivers/mtd/nand/spi/core.c | 2 +- drivers/mtd/nand/spi/macronix.c | 2 +- drivers/spi/spi-mxic.c | 309 ++++++- include/linux/mtd/nand-ecc-mxic.h | 36 + include/linux/mtd/nand.h | 11 + 12 files changed, 1296 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/mtd/mxic,nand-ecc-engine.yaml create mode 100644 drivers/mtd/nand/ecc-mxic.c create mode 100644 include/linux/mtd/nand-ecc-mxic.h -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, <linux-mtd@lists.infradead.org> Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>, Xiangsheng Hou <Xiangsheng.Hou@mediatek.com>, Boris Brezillon <bbrezillon@kernel.org>, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, jaimeliao@mxic.com.tw, juliensu@mxic.com.tw, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [RFC PATCH 00/10] Macronix ECC engine Date: Fri, 8 Oct 2021 18:22:18 +0200 [thread overview] Message-ID: <20211008162228.1753083-1-miquel.raynal@bootlin.com> (raw) Hello all, This series is not 100% stable yet but I believe it should be sent out in order to help other people trying to use the ECC framework with a SPI controller. Basically, Macronix ECC engine can be used as an external engine (takes the data, proceeds to the calculations, writes back the ECC bytes) or as a pipelined engine doing on-the-fly calculations (which is very common in the raw NAND world). In the device tree, the ECC engine should be described as a separated DT node. Then: * external case: the flash node should provide a nand-ecc-engine property pointing to the ECC engine node. * pipelined case: the flash node should provide a nand-ecc-engine property pointing to the SPI controller, itself with another nand-ecc-engine property pointing at the ECC engine node. I will resubmit this later when I will be done validating the hardware and the driver. Cheers, Miquèl Mason Yang (1): mtd: spinand: macronix: Use random program load Miquel Raynal (9): mtd: spinand: Fix comment dt-bindings: vendor-prefixes: Update Macronix prefix dt-bindings: mtd: Describe Macronix NAND ECC engine mtd: nand: ecc: Add infrastructure to support hardware engines mtd: nand: mxic-ecc: Add Macronix external ECC engine support mtd: nand: mxic-ecc: Support SPI pipelined mode spi: mxic: Fix the transmit path spi: mxic: Add support for direct mapping spi: mxic: Add support for pipelined ECC operations .../bindings/mtd/mxic,nand-ecc-engine.yaml | 78 ++ .../devicetree/bindings/vendor-prefixes.yaml | 3 + drivers/mtd/nand/Kconfig | 6 + drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/core.c | 10 +- drivers/mtd/nand/ecc-mxic.c | 797 ++++++++++++++++++ drivers/mtd/nand/ecc.c | 89 ++ drivers/mtd/nand/spi/core.c | 2 +- drivers/mtd/nand/spi/macronix.c | 2 +- drivers/spi/spi-mxic.c | 309 ++++++- include/linux/mtd/nand-ecc-mxic.h | 36 + include/linux/mtd/nand.h | 11 + 12 files changed, 1296 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/mtd/mxic,nand-ecc-engine.yaml create mode 100644 drivers/mtd/nand/ecc-mxic.c create mode 100644 include/linux/mtd/nand-ecc-mxic.h -- 2.27.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2021-10-08 16:22 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-08 16:22 Miquel Raynal [this message] 2021-10-08 16:22 ` [RFC PATCH 00/10] Macronix ECC engine Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 01/10] mtd: spinand: Fix comment Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 02/10] mtd: spinand: macronix: Use random program load Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 03/10] dt-bindings: vendor-prefixes: Update Macronix prefix Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 21:47 ` Rob Herring 2021-10-08 21:47 ` Rob Herring 2021-10-18 1:42 ` 回信: " jaimeliao 2021-10-18 1:42 ` jaimeliao 2021-10-08 16:22 ` [RFC PATCH 04/10] dt-bindings: mtd: Describe Macronix NAND ECC engine Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 19:48 ` Rob Herring 2021-10-08 19:48 ` Rob Herring 2021-10-08 16:22 ` [RFC PATCH 05/10] mtd: nand: ecc: Add infrastructure to support hardware engines Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 06/10] mtd: nand: mxic-ecc: Add Macronix external ECC engine support Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-13 9:15 ` xiangsheng.hou 2021-10-15 9:37 ` Miquel Raynal 2021-10-15 9:37 ` Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 07/10] mtd: nand: mxic-ecc: Support SPI pipelined mode Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-08 16:22 ` [RFC PATCH 08/10] spi: mxic: Fix the transmit path Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal [not found] ` <OF11A0CCB6.4C81ABAD-ON4825876D.00256D6A-4825876D.00256F7A@LocalDomain> 2021-10-13 7:04 ` 回信: " zhengxunli 2021-10-13 7:04 ` zhengxunli 2021-10-08 16:22 ` [RFC PATCH 09/10] spi: mxic: Add support for direct mapping Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal 2021-10-12 7:14 ` 回信: " jaimeliao 2021-10-12 7:14 ` jaimeliao 2021-10-15 8:29 ` Miquel Raynal 2021-10-15 8:29 ` Miquel Raynal [not found] ` <OF86339F0C.88E145E3-ON4825876D.002567AA-4825876D.002569D9@LocalDomain> 2021-10-13 7:23 ` zhengxunli 2021-10-13 7:23 ` zhengxunli 2021-10-08 16:22 ` [RFC PATCH 10/10] spi: mxic: Add support for pipelined ECC operations Miquel Raynal 2021-10-08 16:22 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211008162228.1753083-1-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=Xiangsheng.Hou@mediatek.com \ --cc=bbrezillon@kernel.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jaimeliao@mxic.com.tw \ --cc=juliensu@mxic.com.tw \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.