* [PATCH v3 1/3] dyndbg: make dyndbg a known cli param
2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney
@ 2021-09-20 20:54 ` Andrew Halaney
2021-09-22 18:23 ` jim.cromie
2021-09-20 20:54 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Andrew Halaney
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Andrew Halaney @ 2021-09-20 20:54 UTC (permalink / raw)
To: Jason Baron, Jim Cromie; +Cc: Andrew Halaney, linux-kernel
Right now dyndbg shows up as an unknown parameter if used on boot:
Unknown command line parameters: dyndbg=+p
That's because it is unknown, it doesn't sit in the __param
section, so the processing done to warn users supplying an unknown
parameter doesn't think it is legitimate.
Install a dummy handler to register it. dynamic debug needs to search
the whole command line for modules listed that are currently builtin,
so there's no real work to be done in this callback.
Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
lib/dynamic_debug.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index cb5abb42c16a..84c16309cc63 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -761,6 +761,18 @@ static __init int ddebug_setup_query(char *str)
__setup("ddebug_query=", ddebug_setup_query);
+/*
+ * Install a noop handler to make dyndbg look like a normal kernel cli param.
+ * This avoids warnings about dyndbg being an unknown cli param when supplied
+ * by a user.
+ */
+static __init int dyndbg_setup(char *str)
+{
+ return 1;
+}
+
+__setup("dyndbg=", dyndbg_setup);
+
/*
* File_ops->write method for <debugfs>/dynamic_debug/control. Gathers the
* command text from userspace, parses and executes it.
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 1/3] dyndbg: make dyndbg a known cli param
2021-09-20 20:54 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Andrew Halaney
@ 2021-09-22 18:23 ` jim.cromie
0 siblings, 0 replies; 12+ messages in thread
From: jim.cromie @ 2021-09-22 18:23 UTC (permalink / raw)
To: Andrew Halaney; +Cc: Jason Baron, LKML
On Mon, Sep 20, 2021 at 2:55 PM Andrew Halaney <ahalaney@redhat.com> wrote:
>
> Right now dyndbg shows up as an unknown parameter if used on boot:
>
> Unknown command line parameters: dyndbg=+p
>
> That's because it is unknown, it doesn't sit in the __param
> section, so the processing done to warn users supplying an unknown
> parameter doesn't think it is legitimate.
>
> Install a dummy handler to register it. dynamic debug needs to search
> the whole command line for modules listed that are currently builtin,
> so there's no real work to be done in this callback.
>
> Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
I just validated that this does NOT block or short circuit bare
dyndbg= processing,
[ 0.981166] dyndbg: dyndbg="+fl"
[ 0.981281] dyndbg: query 0: "+fl"
[ 0.981836] dyndbg: split into words: "+fl"
[ 0.982281] dyndbg: op='+'
[ 0.982861] dyndbg: flags=0xc
[ 0.983281] dyndbg: *flagsp=0xc *maskp=0xffffffff
[ 0.984044] dyndbg: parsed: func="" file="" module="" format="" lineno=0-0
[ 0.984298] dyndbg: changed arch/x86/pci/irq.c:1312
[irq]pcibios_fixup_irqs =fl
[ 0.985284] dyndbg: changed arch/x86/pci/irq.c:1259
[irq]pcibios_lookup_irq =fl
[ 0.986281] dyndbg: changed arch/x86/pci/irq.c:1229
[irq]pcibios_lookup_irq =fl
you have my T-B
> ---
> lib/dynamic_debug.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index cb5abb42c16a..84c16309cc63 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -761,6 +761,18 @@ static __init int ddebug_setup_query(char *str)
>
> __setup("ddebug_query=", ddebug_setup_query);
>
> +/*
> + * Install a noop handler to make dyndbg look like a normal kernel cli param.
> + * This avoids warnings about dyndbg being an unknown cli param when supplied
> + * by a user.
> + */
> +static __init int dyndbg_setup(char *str)
> +{
> + return 1;
> +}
> +
> +__setup("dyndbg=", dyndbg_setup);
> +
> /*
> * File_ops->write method for <debugfs>/dynamic_debug/control. Gathers the
> * command text from userspace, parses and executes it.
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param
2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney
2021-09-20 20:54 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Andrew Halaney
@ 2021-09-20 20:54 ` Andrew Halaney
2021-09-20 20:54 ` [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples Andrew Halaney
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Andrew Halaney @ 2021-09-20 20:54 UTC (permalink / raw)
To: Jason Baron, Jonathan Corbet, Jim Cromie
Cc: Andrew Halaney, linux-doc, linux-kernel
This param has been deprecated for a very long time now, let's rip it
out.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
.../admin-guide/dynamic-debug-howto.rst | 6 ++---
.../admin-guide/kernel-parameters.txt | 5 ----
lib/dynamic_debug.c | 25 -------------------
3 files changed, 2 insertions(+), 34 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index b119b8277b3e..d0911e7cc271 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -249,8 +249,7 @@ Debug messages during Boot Process
To activate debug messages for core code and built-in modules during
the boot process, even before userspace and debugfs exists, use
-``dyndbg="QUERY"``, ``module.dyndbg="QUERY"``, or ``ddebug_query="QUERY"``
-(``ddebug_query`` is obsoleted by ``dyndbg``, and deprecated). QUERY follows
+``dyndbg="QUERY"`` or ``module.dyndbg="QUERY"``. QUERY follows
the syntax described above, but must not exceed 1023 characters. Your
bootloader may impose lower limits.
@@ -270,8 +269,7 @@ this boot parameter for debugging purposes.
If ``foo`` module is not built-in, ``foo.dyndbg`` will still be processed at
boot time, without effect, but will be reprocessed when module is
-loaded later. ``ddebug_query=`` and bare ``dyndbg=`` are only processed at
-boot.
+loaded later. Bare ``dyndbg=`` is only processed at boot.
Debug Messages at Module Initialization Time
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 91ba391f9b32..9c0c57d1ca78 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -841,11 +841,6 @@
Format: <port#>,<type>
See also Documentation/input/devices/joystick-parport.rst
- ddebug_query= [KNL,DYNAMIC_DEBUG] Enable debug messages at early boot
- time. See
- Documentation/admin-guide/dynamic-debug-howto.rst for
- details. Deprecated, see dyndbg.
-
debug [KNL] Enable kernel debugging (events log level).
debug_boot_weak_hash
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 84c16309cc63..130ce0eb550d 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -746,21 +746,6 @@ EXPORT_SYMBOL(__dynamic_ibdev_dbg);
#endif
-#define DDEBUG_STRING_SIZE 1024
-static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE];
-
-static __init int ddebug_setup_query(char *str)
-{
- if (strlen(str) >= DDEBUG_STRING_SIZE) {
- pr_warn("ddebug boot param string too large\n");
- return 0;
- }
- strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE);
- return 1;
-}
-
-__setup("ddebug_query=", ddebug_setup_query);
-
/*
* Install a noop handler to make dyndbg look like a normal kernel cli param.
* This avoids warnings about dyndbg being an unknown cli param when supplied
@@ -1133,16 +1118,6 @@ static int __init dynamic_debug_init(void)
entries, modct, (int)((modct * sizeof(struct ddebug_table)) >> 10),
(int)((entries * sizeof(struct _ddebug)) >> 10));
- /* apply ddebug_query boot param, dont unload tables on err */
- if (ddebug_setup_string[0] != '\0') {
- pr_warn("ddebug_query param name is deprecated, change it to dyndbg\n");
- ret = ddebug_exec_queries(ddebug_setup_string, NULL);
- if (ret < 0)
- pr_warn("Invalid ddebug boot param %s\n",
- ddebug_setup_string);
- else
- pr_info("%d changes by ddebug_query\n", ret);
- }
/* now that ddebug tables are loaded, process all boot args
* again to find and activate queries given in dyndbg params.
* While this has already been done for known boot params, it
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples
2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney
2021-09-20 20:54 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Andrew Halaney
2021-09-20 20:54 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Andrew Halaney
@ 2021-09-20 20:54 ` Andrew Halaney
2021-09-22 18:04 ` [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron
2021-10-08 15:58 ` Jason Baron
4 siblings, 0 replies; 12+ messages in thread
From: Andrew Halaney @ 2021-09-20 20:54 UTC (permalink / raw)
To: Jason Baron, Jonathan Corbet, Jim Cromie
Cc: Andrew Halaney, linux-doc, linux-kernel
Jim pointed out that using $module.dyndbg= is always a more flexible
choice for using dynamic debug on the command line. The $module.dyndbg
style is checked at boot and handles if $module is a builtin. If it is
actually a loadable module, it is handled again later when the module is
loaded.
If you just use dyndbg="module $module +p" dynamic debug is only enabled
when $module is a builtin.
It was recommended to illustrate wildcard usage as well.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Suggested-by: Jim Cromie <jim.cromie@gmail.com>
---
Documentation/admin-guide/dynamic-debug-howto.rst | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index d0911e7cc271..ae264aab42b6 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -357,7 +357,10 @@ Examples
Kernel command line: ...
// see whats going on in dyndbg=value processing
dynamic_debug.verbose=1
- // enable pr_debugs in 2 builtins, #cmt is stripped
- dyndbg="module params +p #cmt ; module sys +p"
+ // enable pr_debugs in the btrfs module (can be builtin or loadable)
+ btrfs.dyndbg="+p"
+ // enable pr_debugs in all files under init/
+ // and the function parse_one, #cmt is stripped
+ dyndbg="file init/* +p #cmt ; func parse_one +p"
// enable pr_debugs in 2 functions in a module loaded later
pc87360.dyndbg="func pc87360_init_device +p; func pc87360_find +p"
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney
` (2 preceding siblings ...)
2021-09-20 20:54 ` [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples Andrew Halaney
@ 2021-09-22 18:04 ` Jason Baron
2021-10-08 15:58 ` Jason Baron
4 siblings, 0 replies; 12+ messages in thread
From: Jason Baron @ 2021-09-22 18:04 UTC (permalink / raw)
To: Andrew Halaney, Jonathan Corbet, Jim Cromie; +Cc: linux-doc, linux-kernel
Hi Andrew,
Series looks good to me.
Acked-by: Jason Baron <jbaron@akamai.com>
Thanks,
-Jason
On 9/20/21 4:54 PM, Andrew Halaney wrote:
> Hi,
>
> Here is round 3 of some trivial dynamic debug improvements.
>
> v2 -> v3:
> * Use a more clear example in the cli param examples
>
> v1 -> v2:
> * Use different example when showing misleading error message
> * Justify dynamic debug scanning the whole command line
> * Add patch removing ddebug_query
> * Add patch improving cli param examples for dyndbg/$module.dyndbg
>
> v2: https://urldefense.com/v3/__https://lore.kernel.org/all/20210913222440.731329-1-ahalaney@redhat.com/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzi_clWo1Q$
> v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20210909161755.61743-1-ahalaney@redhat.com/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzhcL6__NA$
>
> Andrew Halaney (3):
> dyndbg: make dyndbg a known cli param
> dyndbg: Remove support for ddebug_query param
> Documentation: dyndbg: Improve cli param examples
>
> .../admin-guide/dynamic-debug-howto.rst | 13 ++++-----
> .../admin-guide/kernel-parameters.txt | 5 ----
> lib/dynamic_debug.c | 27 +++++--------------
> 3 files changed, 14 insertions(+), 31 deletions(-)
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney
` (3 preceding siblings ...)
2021-09-22 18:04 ` [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron
@ 2021-10-08 15:58 ` Jason Baron
2021-10-08 16:01 ` Greg Kroah-Hartman
4 siblings, 1 reply; 12+ messages in thread
From: Jason Baron @ 2021-10-08 15:58 UTC (permalink / raw)
To: Andrew Halaney, Jonathan Corbet, Jim Cromie, Greg Kroah-Hartman
Cc: linux-doc, linux-kernel
Adding Greg to this (should have added him earlier)
Greg, if you are ok with this series, we'd like to have it added
to -next.
Thanks,
-Jason
On 9/20/21 4:54 PM, Andrew Halaney wrote:
> Hi,
>
> Here is round 3 of some trivial dynamic debug improvements.
>
> v2 -> v3:
> * Use a more clear example in the cli param examples
>
> v1 -> v2:
> * Use different example when showing misleading error message
> * Justify dynamic debug scanning the whole command line
> * Add patch removing ddebug_query
> * Add patch improving cli param examples for dyndbg/$module.dyndbg
>
> v2: https://urldefense.com/v3/__https://lore.kernel.org/all/20210913222440.731329-1-ahalaney@redhat.com/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzi_clWo1Q$
> v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20210909161755.61743-1-ahalaney@redhat.com/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzhcL6__NA$
>
> Andrew Halaney (3):
> dyndbg: make dyndbg a known cli param
> dyndbg: Remove support for ddebug_query param
> Documentation: dyndbg: Improve cli param examples
>
> .../admin-guide/dynamic-debug-howto.rst | 13 ++++-----
> .../admin-guide/kernel-parameters.txt | 5 ----
> lib/dynamic_debug.c | 27 +++++--------------
> 3 files changed, 14 insertions(+), 31 deletions(-)
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-10-08 15:58 ` Jason Baron
@ 2021-10-08 16:01 ` Greg Kroah-Hartman
2021-10-08 16:27 ` Andrew Halaney
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-08 16:01 UTC (permalink / raw)
To: Jason Baron
Cc: Andrew Halaney, Jonathan Corbet, Jim Cromie, linux-doc, linux-kernel
On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> Adding Greg to this (should have added him earlier)
>
> Greg, if you are ok with this series, we'd like to have it added
> to -next.
What series?
Have a pointer to it? It would help if it was actually sent to me if
people want it applied...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-10-08 16:01 ` Greg Kroah-Hartman
@ 2021-10-08 16:27 ` Andrew Halaney
2021-10-13 11:35 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Andrew Halaney @ 2021-10-08 16:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jason Baron, Jonathan Corbet, Jim Cromie, linux-doc, linux-kernel
On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> > Adding Greg to this (should have added him earlier)
> >
> > Greg, if you are ok with this series, we'd like to have it added
> > to -next.
>
> What series?
>
> Have a pointer to it? It would help if it was actually sent to me if
> people want it applied...
>
> thanks,
>
> greg k-h
>
Sorry Greg, that's probably my bad.. still getting used to the kernel's
workflow.
Here's the lore link: https://lore.kernel.org/all/20210920205444.20068-1-ahalaney@redhat.com/
Did I do something silly when sending the patches? I basically
just added everyone manually when using git send-email.
I found who to add via:
ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
Jason Baron <jbaron@akamai.com> (maintainer:DYNAMIC DEBUG)
Martin Kepplinger <martink@posteo.de> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
Andrew Halaney <ahalaney@redhat.com> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
"Paul E. McKenney" <paulmck@kernel.org> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
Thomas Gleixner <tglx@linutronix.de> (commit_signer:11/89=12%)
Andrew Morton <akpm@linux-foundation.org> (commit_signer:11/89=12%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:8/89=9%,removed_lines:13/137=9%)
Will Deacon <will@kernel.org> (commit_signer:7/89=8%)
"Maciej W. Rozycki" <macro@orcam.me.uk> (added_lines:90/527=17%)
Muchun Song <songmuchun@bytedance.com> (added_lines:28/527=5%)
Viresh Kumar <viresh.kumar@linaro.org> (removed_lines:14/137=10%)
Robin Murphy <robin.murphy@arm.com> (removed_lines:13/137=9%)
Randy Dunlap <rdunlap@infradead.org> (removed_lines:10/137=7%)
Lu Baolu <baolu.lu@linux.intel.com> (removed_lines:10/137=7%)
linux-doc@vger.kernel.org (open list:DOCUMENTATION)
linux-kernel@vger.kernel.org (open list)
per patch, and I just hit the maintainers and the lists specified
since I figured the commit_signers don't care. Did I goof up?
Thanks,
Andrew
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-10-08 16:27 ` Andrew Halaney
@ 2021-10-13 11:35 ` Greg Kroah-Hartman
2021-10-13 13:54 ` Jason Baron
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-13 11:35 UTC (permalink / raw)
To: Andrew Halaney
Cc: Jason Baron, Jonathan Corbet, Jim Cromie, linux-doc, linux-kernel
On Fri, Oct 08, 2021 at 11:27:07AM -0500, Andrew Halaney wrote:
> On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> > > Adding Greg to this (should have added him earlier)
> > >
> > > Greg, if you are ok with this series, we'd like to have it added
> > > to -next.
> >
> > What series?
> >
> > Have a pointer to it? It would help if it was actually sent to me if
> > people want it applied...
> >
> > thanks,
> >
> > greg k-h
> >
>
> Sorry Greg, that's probably my bad.. still getting used to the kernel's
> workflow.
>
> Here's the lore link: https://lore.kernel.org/all/20210920205444.20068-1-ahalaney@redhat.com/
>
> Did I do something silly when sending the patches? I basically
> just added everyone manually when using git send-email.
>
> I found who to add via:
>
> ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
> Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
> Jason Baron <jbaron@akamai.com> (maintainer:DYNAMIC DEBUG)
> Martin Kepplinger <martink@posteo.de> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
> Andrew Halaney <ahalaney@redhat.com> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
> "Paul E. McKenney" <paulmck@kernel.org> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
> Thomas Gleixner <tglx@linutronix.de> (commit_signer:11/89=12%)
> Andrew Morton <akpm@linux-foundation.org> (commit_signer:11/89=12%)
> Peter Zijlstra <peterz@infradead.org> (commit_signer:8/89=9%,removed_lines:13/137=9%)
> Will Deacon <will@kernel.org> (commit_signer:7/89=8%)
> "Maciej W. Rozycki" <macro@orcam.me.uk> (added_lines:90/527=17%)
> Muchun Song <songmuchun@bytedance.com> (added_lines:28/527=5%)
> Viresh Kumar <viresh.kumar@linaro.org> (removed_lines:14/137=10%)
> Robin Murphy <robin.murphy@arm.com> (removed_lines:13/137=9%)
> Randy Dunlap <rdunlap@infradead.org> (removed_lines:10/137=7%)
> Lu Baolu <baolu.lu@linux.intel.com> (removed_lines:10/137=7%)
> linux-doc@vger.kernel.org (open list:DOCUMENTATION)
> linux-kernel@vger.kernel.org (open list)
>
>
> per patch, and I just hit the maintainers and the lists specified
> since I figured the commit_signers don't care. Did I goof up?
No, that's all correct. It's up to the maintainers to then route your
patches to the proper tree.
If they want me to take them, great, I'll be glad to do so, but I need
them to send them to me :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/3] Trivial dynamic debug fixups
2021-10-13 11:35 ` Greg Kroah-Hartman
@ 2021-10-13 13:54 ` Jason Baron
0 siblings, 0 replies; 12+ messages in thread
From: Jason Baron @ 2021-10-13 13:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Andrew Halaney
Cc: Jonathan Corbet, Jim Cromie, linux-doc, linux-kernel
On 10/13/21 7:35 AM, Greg Kroah-Hartman wrote:
> On Fri, Oct 08, 2021 at 11:27:07AM -0500, Andrew Halaney wrote:
>> On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
>>> On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
>>>> Adding Greg to this (should have added him earlier)
>>>>
>>>> Greg, if you are ok with this series, we'd like to have it added
>>>> to -next.
>>>
>>> What series?
>>>
>>> Have a pointer to it? It would help if it was actually sent to me if
>>> people want it applied...
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Sorry Greg, that's probably my bad.. still getting used to the kernel's
>> workflow.
>>
>> Here's the lore link: https://urldefense.com/v3/__https://lore.kernel.org/all/20210920205444.20068-1-ahalaney@redhat.com/__;!!GjvTz_vk!A7QQa1yGOtgSmhzn52NLhZuRbLxxMCyl17_8RiqsehjeAG2AAsYl7bgWgK15Pw$
>>
>> Did I do something silly when sending the patches? I basically
>> just added everyone manually when using git send-email.
>>
>> I found who to add via:
>>
>> ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
>> Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
>> Jason Baron <jbaron@akamai.com> (maintainer:DYNAMIC DEBUG)
>> Martin Kepplinger <martink@posteo.de> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
>> Andrew Halaney <ahalaney@redhat.com> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
>> "Paul E. McKenney" <paulmck@kernel.org> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
>> Thomas Gleixner <tglx@linutronix.de> (commit_signer:11/89=12%)
>> Andrew Morton <akpm@linux-foundation.org> (commit_signer:11/89=12%)
>> Peter Zijlstra <peterz@infradead.org> (commit_signer:8/89=9%,removed_lines:13/137=9%)
>> Will Deacon <will@kernel.org> (commit_signer:7/89=8%)
>> "Maciej W. Rozycki" <macro@orcam.me.uk> (added_lines:90/527=17%)
>> Muchun Song <songmuchun@bytedance.com> (added_lines:28/527=5%)
>> Viresh Kumar <viresh.kumar@linaro.org> (removed_lines:14/137=10%)
>> Robin Murphy <robin.murphy@arm.com> (removed_lines:13/137=9%)
>> Randy Dunlap <rdunlap@infradead.org> (removed_lines:10/137=7%)
>> Lu Baolu <baolu.lu@linux.intel.com> (removed_lines:10/137=7%)
>> linux-doc@vger.kernel.org (open list:DOCUMENTATION)
>> linux-kernel@vger.kernel.org (open list)
>>
>>
>> per patch, and I just hit the maintainers and the lists specified
>> since I figured the commit_signers don't care. Did I goof up?
>
> No, that's all correct. It's up to the maintainers to then route your
> patches to the proper tree.
>
> If they want me to take them, great, I'll be glad to do so, but I need
> them to send them to me :)
Ok, I will re-send the series to Greg.
Thanks,
-Jason
^ permalink raw reply [flat|nested] 12+ messages in thread