[lpieralisi-pci:pci/qcom 2/3] drivers/pci/controller/dwc/pcie-qcom-ep.c:548:2-9: line 548 is redundant because platform_get_irq() already prints an error

[lpieralisi-pci:pci/qcom 2/3] drivers/pci/controller/dwc/pcie-qcom-ep.c:548:2-9: line 548 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: linux-kernel(a)vger.kernel.org
TO: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
CC: Siddartha Mohanadoss <smohanad@codeaurora.org>
CC: Rob Herring <robh@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/qcom
head:   b969e621b12d4f2519e8018fec39efe7f38fbae5
commit: c206ae06ea1bc20b825e47d9d942ba19cbf74f13 [2/3] PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
config: powerpc64-randconfig-c023-20211008 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-qcom-ep.c:548:2-9: line 548 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34335 bytes --]

[PATCH] PCI: qcom-ep: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: linux-kernel(a)vger.kernel.org
TO: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
CC: Siddartha Mohanadoss <smohanad@codeaurora.org>
CC: Rob Herring <robh@kernel.org>
CC: Stanimir Varbanov <svarbanov@mm-sol.com>
CC: "Krzysztof Wilczyński" <kw@linux.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: linux-pci(a)vger.kernel.org
CC: linux-arm-msm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/pci/controller/dwc/pcie-qcom-ep.c:548:2-9: line 548 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

CC: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/qcom
head:   b969e621b12d4f2519e8018fec39efe7f38fbae5
commit: c206ae06ea1bc20b825e47d9d942ba19cbf74f13 [2/3] PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago

Please take the patch only if it's a positive warning. Thanks!

 pcie-qcom-ep.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
+++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
@@ -545,7 +545,6 @@ static int qcom_pcie_ep_enable_irq_resou
 
 	irq = platform_get_irq_byname(pdev, "global");
 	if (irq < 0) {
-		dev_err(&pdev->dev, "Failed to get Global IRQ\n");
 		return irq;
 	}