All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Subject: [arm:clearfog 12/13] drivers/pci/pcie/portdrv_core.c:325 pcie_port_device_register() warn: inconsistent indenting
Date: Sun, 10 Oct 2021 00:30:43 +0800	[thread overview]
Message-ID: <202110100037.qKVl4k5L-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2833 bytes --]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git clearfog
head:   418f3b57d929bb560d0e65fbb43f50ac8a5e9521
commit: bfdadde3de8aace53903de79bbcd1533e8382746 [12/13] mvebu/clearfog pcie updates
config: x86_64-randconfig-m001-20211009 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/pci/pcie/portdrv_core.c:325 pcie_port_device_register() warn: inconsistent indenting

Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:338 pcie_port_device_register() warn: inconsistent indenting

vim +325 drivers/pci/pcie/portdrv_core.c

   305	
   306	/**
   307	 * pcie_port_device_register - register PCI Express port
   308	 * @dev: PCI Express port to register
   309	 *
   310	 * Allocate the port extension structure and register services associated with
   311	 * the port.
   312	 */
   313	int pcie_port_device_register(struct pci_dev *dev)
   314	{
   315		int status, capabilities, i, nr_service;
   316		int irqs[PCIE_PORT_DEVICE_MAXSERVICES];
   317	
   318		/* Enable PCI Express port device */
   319		status = pci_enable_device(dev);
   320		if (status)
   321			return status;
   322	
   323		/* Get and check PCI Express port services */
   324		capabilities = get_port_device_capability(dev);
 > 325	dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
   326		if (!capabilities)
   327			return 0;
   328	
   329		pci_set_master(dev);
   330		/*
   331		 * Initialize service irqs. Don't use service devices that
   332		 * require interrupts if there is no way to generate them.
   333		 * However, some drivers may have a polling mode (e.g. pciehp_poll_mode)
   334		 * that can be used in the absence of irqs.  Allow them to determine
   335		 * if that is to be used.
   336		 */
   337		status = pcie_init_service_irqs(dev, irqs, capabilities);
   338	dev_info(&dev->dev, "init_service_irqs: %d\n", status);
   339		if (status) {
   340			capabilities &= PCIE_PORT_SERVICE_HP;
   341			if (!capabilities)
   342				goto error_disable;
   343		}
   344	
   345		/* Allocate child services if any */
   346		status = -ENODEV;
   347		nr_service = 0;
   348		for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
   349			int service = 1 << i;
   350			if (!(capabilities & service))
   351				continue;
   352			if (!pcie_device_init(dev, service, irqs[i]))
   353				nr_service++;
   354		}
   355		if (!nr_service)
   356			goto error_cleanup_irqs;
   357	
   358		return 0;
   359	
   360	error_cleanup_irqs:
   361		pci_free_irq_vectors(dev);
   362	error_disable:
   363		pci_disable_device(dev);
   364		return status;
   365	}
   366	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28055 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [arm:clearfog 12/13] drivers/pci/pcie/portdrv_core.c:325 pcie_port_device_register() warn: inconsistent indenting
Date: Sun, 10 Oct 2021 00:30:43 +0800	[thread overview]
Message-ID: <202110100037.qKVl4k5L-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2916 bytes --]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git clearfog
head:   418f3b57d929bb560d0e65fbb43f50ac8a5e9521
commit: bfdadde3de8aace53903de79bbcd1533e8382746 [12/13] mvebu/clearfog pcie updates
config: x86_64-randconfig-m001-20211009 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/pci/pcie/portdrv_core.c:325 pcie_port_device_register() warn: inconsistent indenting

Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:338 pcie_port_device_register() warn: inconsistent indenting

vim +325 drivers/pci/pcie/portdrv_core.c

   305	
   306	/**
   307	 * pcie_port_device_register - register PCI Express port
   308	 * @dev: PCI Express port to register
   309	 *
   310	 * Allocate the port extension structure and register services associated with
   311	 * the port.
   312	 */
   313	int pcie_port_device_register(struct pci_dev *dev)
   314	{
   315		int status, capabilities, i, nr_service;
   316		int irqs[PCIE_PORT_DEVICE_MAXSERVICES];
   317	
   318		/* Enable PCI Express port device */
   319		status = pci_enable_device(dev);
   320		if (status)
   321			return status;
   322	
   323		/* Get and check PCI Express port services */
   324		capabilities = get_port_device_capability(dev);
 > 325	dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
   326		if (!capabilities)
   327			return 0;
   328	
   329		pci_set_master(dev);
   330		/*
   331		 * Initialize service irqs. Don't use service devices that
   332		 * require interrupts if there is no way to generate them.
   333		 * However, some drivers may have a polling mode (e.g. pciehp_poll_mode)
   334		 * that can be used in the absence of irqs.  Allow them to determine
   335		 * if that is to be used.
   336		 */
   337		status = pcie_init_service_irqs(dev, irqs, capabilities);
   338	dev_info(&dev->dev, "init_service_irqs: %d\n", status);
   339		if (status) {
   340			capabilities &= PCIE_PORT_SERVICE_HP;
   341			if (!capabilities)
   342				goto error_disable;
   343		}
   344	
   345		/* Allocate child services if any */
   346		status = -ENODEV;
   347		nr_service = 0;
   348		for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
   349			int service = 1 << i;
   350			if (!(capabilities & service))
   351				continue;
   352			if (!pcie_device_init(dev, service, irqs[i]))
   353				nr_service++;
   354		}
   355		if (!nr_service)
   356			goto error_cleanup_irqs;
   357	
   358		return 0;
   359	
   360	error_cleanup_irqs:
   361		pci_free_irq_vectors(dev);
   362	error_disable:
   363		pci_disable_device(dev);
   364		return status;
   365	}
   366	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28055 bytes --]

             reply	other threads:[~2021-10-09 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 16:30 kernel test robot [this message]
2021-10-09 16:30 ` [arm:clearfog 12/13] drivers/pci/pcie/portdrv_core.c:325 pcie_port_device_register() warn: inconsistent indenting kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-06-03 16:08 kernel test robot
2021-06-03 16:08 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110100037.qKVl4k5L-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.