Re: [PATCH v5 2/2] hwmon: (nct7802) Make temperature/voltage sensors configurable

From: kernel test robot <lkp@intel.com>
To: Oskar Senft <osk@google.com>, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, Oskar Senft <osk@google.com>
Subject: Re: [PATCH v5 2/2] hwmon: (nct7802) Make temperature/voltage sensors configurable
Date: Sun, 10 Oct 2021 06:40:49 +0800	[thread overview]
Message-ID: <202110100634.0dqXanQ0-lkp@intel.com> (raw)
In-Reply-To: <20211009185257.2230013-2-osk@google.com>

[-- Attachment #1: Type: text/plain, Size: 2704 bytes --]

Hi Oskar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on robh/for-next v5.15-rc4 next-20211008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oskar-Senft/dt-bindings-hwmon-Add-nct7802-bindings/20211010-025416
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d4f58d8c83ce0406595cce4816db4bad37c19920
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oskar-Senft/dt-bindings-hwmon-Add-nct7802-bindings/20211010-025416
        git checkout d4f58d8c83ce0406595cce4816db4bad37c19920
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/nct7802.c: In function 'nct7802_configure_channels':
>> drivers/hwmon/nct7802.c:1146:14: error: unused variable 'found_channel_config' [-Werror=unused-variable]
    1146 |         bool found_channel_config = false;
         |              ^~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/found_channel_config +1146 drivers/hwmon/nct7802.c

  1142	
  1143	static int nct7802_configure_channels(struct device *dev,
  1144					      struct nct7802_data *data)
  1145	{
> 1146		bool found_channel_config = false;
  1147		u8 mode_mask = 0, mode_val = 0;
  1148		struct device_node *node;
  1149		int err;
  1150	
  1151		/* Enable local temperature sensor by default */
  1152		mode_val |= MODE_LTD_EN;
  1153		mode_mask |= MODE_LTD_EN;
  1154	
  1155		if (dev->of_node) {
  1156			for_each_child_of_node(dev->of_node, node) {
  1157				err = nct7802_get_channel_config(dev, node, &mode_mask,
  1158								 &mode_val);
  1159				if (err)
  1160					return err;
  1161			}
  1162		}
  1163	
  1164		return regmap_update_bits(data->regmap, REG_MODE, mode_mask, mode_val);
  1165	}
  1166	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74080 bytes --]