All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: mripard@kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: sun50i-de2: Adjust printing error message
Date: Sun, 10 Oct 2021 18:19:46 +0100	[thread overview]
Message-ID: <20211010181848.7b0ac8d4@slackpad.fritz.box> (raw)
In-Reply-To: <20211010071812.145178-1-jernej.skrabec@gmail.com>

On Sun, 10 Oct 2021 09:18:12 +0200
Jernej Skrabec <jernej.skrabec@gmail.com> wrote:

> SRAM driver often returns -EPROBE_DEFER and thus this bus driver often
> prints error message, even if it probes successfully later. This is
> confusing for users and they often think that something is wrong.
> 
> Use dev_err_probe() helper for printing error message. It handles
> -EPROBE_DEFER automatically.

Ah, many thanks for just fixing this, it was indeed confusing people.
And thanks for pointing to this useful helper!

Would this actually be a candidate for stable?

> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  drivers/bus/sun50i-de2.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/sun50i-de2.c b/drivers/bus/sun50i-de2.c
> index 672518741f86..414f29cdedf0 100644
> --- a/drivers/bus/sun50i-de2.c
> +++ b/drivers/bus/sun50i-de2.c
> @@ -15,10 +15,9 @@ static int sun50i_de2_bus_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	ret = sunxi_sram_claim(&pdev->dev);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Error couldn't map SRAM to device\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
> +				     "Couldn't map SRAM to device\n");
>  
>  	of_platform_populate(np, NULL, NULL, &pdev->dev);
>  


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: mripard@kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: sun50i-de2: Adjust printing error message
Date: Sun, 10 Oct 2021 18:19:46 +0100	[thread overview]
Message-ID: <20211010181848.7b0ac8d4@slackpad.fritz.box> (raw)
In-Reply-To: <20211010071812.145178-1-jernej.skrabec@gmail.com>

On Sun, 10 Oct 2021 09:18:12 +0200
Jernej Skrabec <jernej.skrabec@gmail.com> wrote:

> SRAM driver often returns -EPROBE_DEFER and thus this bus driver often
> prints error message, even if it probes successfully later. This is
> confusing for users and they often think that something is wrong.
> 
> Use dev_err_probe() helper for printing error message. It handles
> -EPROBE_DEFER automatically.

Ah, many thanks for just fixing this, it was indeed confusing people.
And thanks for pointing to this useful helper!

Would this actually be a candidate for stable?

> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  drivers/bus/sun50i-de2.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/sun50i-de2.c b/drivers/bus/sun50i-de2.c
> index 672518741f86..414f29cdedf0 100644
> --- a/drivers/bus/sun50i-de2.c
> +++ b/drivers/bus/sun50i-de2.c
> @@ -15,10 +15,9 @@ static int sun50i_de2_bus_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	ret = sunxi_sram_claim(&pdev->dev);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Error couldn't map SRAM to device\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
> +				     "Couldn't map SRAM to device\n");
>  
>  	of_platform_populate(np, NULL, NULL, &pdev->dev);
>  


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-10 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10  7:18 [PATCH] bus: sun50i-de2: Adjust printing error message Jernej Skrabec
2021-10-10  7:18 ` Jernej Skrabec
2021-10-10 17:19 ` Andre Przywara [this message]
2021-10-10 17:19   ` Andre Przywara
2021-10-13 12:49 ` (subset) " Maxime Ripard
2021-10-13 12:49   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211010181848.7b0ac8d4@slackpad.fritz.box \
    --to=andre.przywara@arm.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.