All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, thanneeru.srinivasulu@intel.com
Subject: [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures
Date: Mon, 11 Oct 2021 20:51:04 +0530	[thread overview]
Message-ID: <20211011152106.3424810-3-thanneeru.srinivasulu@intel.com> (raw)
In-Reply-To: <20211011152106.3424810-1-thanneeru.srinivasulu@intel.com>

Replace DRM_ERROR with i915_probe_error to report early HuC failures.

Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
index ff4b6869b80b..ff0f5b9130c9 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
@@ -179,7 +179,7 @@ int intel_huc_auth(struct intel_huc *huc)
 	ret = intel_guc_auth_huc(guc,
 				 intel_guc_ggtt_offset(guc, huc->rsa_data));
 	if (ret) {
-		DRM_ERROR("HuC: GuC did not ack Auth request %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: GuC did not ack Auth request %d\n", ret);
 		goto fail;
 	}
 
@@ -190,7 +190,7 @@ int intel_huc_auth(struct intel_huc *huc)
 					huc->status.value,
 					2, 50, NULL);
 	if (ret) {
-		DRM_ERROR("HuC: Firmware not verified %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: Firmware not verified %d\n", ret);
 		goto fail;
 	}
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, thanneeru.srinivasulu@intel.com
Subject: [Intel-gfx] [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures
Date: Mon, 11 Oct 2021 20:51:04 +0530	[thread overview]
Message-ID: <20211011152106.3424810-3-thanneeru.srinivasulu@intel.com> (raw)
In-Reply-To: <20211011152106.3424810-1-thanneeru.srinivasulu@intel.com>

Replace DRM_ERROR with i915_probe_error to report early HuC failures.

Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
index ff4b6869b80b..ff0f5b9130c9 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
@@ -179,7 +179,7 @@ int intel_huc_auth(struct intel_huc *huc)
 	ret = intel_guc_auth_huc(guc,
 				 intel_guc_ggtt_offset(guc, huc->rsa_data));
 	if (ret) {
-		DRM_ERROR("HuC: GuC did not ack Auth request %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: GuC did not ack Auth request %d\n", ret);
 		goto fail;
 	}
 
@@ -190,7 +190,7 @@ int intel_huc_auth(struct intel_huc *huc)
 					huc->status.value,
 					2, 50, NULL);
 	if (ret) {
-		DRM_ERROR("HuC: Firmware not verified %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: Firmware not verified %d\n", ret);
 		goto fail;
 	}
 
-- 
2.25.1


  parent reply	other threads:[~2021-10-11 15:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 15:21 [PATCH 0/4] drm/i915/guc: Inject probe errors for MMIO send, CT send Thanneeru Srinivasulu
2021-10-11 15:21 ` [Intel-gfx] " Thanneeru Srinivasulu
2021-10-11 15:21 ` [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures Thanneeru Srinivasulu
2021-10-11 15:21   ` [Intel-gfx] " Thanneeru Srinivasulu
2021-10-11 18:10   ` Matthew Brost
2021-10-11 18:10     ` [Intel-gfx] " Matthew Brost
2021-10-12 16:16     ` Jani Nikula
2021-10-12 16:19       ` Jani Nikula
2021-10-12 16:43       ` Michal Wajdeczko
2021-10-11 15:21 ` Thanneeru Srinivasulu [this message]
2021-10-11 15:21   ` [Intel-gfx] [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures Thanneeru Srinivasulu
2021-10-11 18:13   ` Matthew Brost
2021-10-11 18:13     ` [Intel-gfx] " Matthew Brost
2021-10-11 15:21 ` [PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send Thanneeru Srinivasulu
2021-10-11 15:21   ` [Intel-gfx] " Thanneeru Srinivasulu
2021-10-11 18:09   ` Matthew Brost
2021-10-11 18:09     ` [Intel-gfx] " Matthew Brost
2021-10-11 15:21 ` [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send Thanneeru Srinivasulu
2021-10-11 15:21   ` [Intel-gfx] " Thanneeru Srinivasulu
2021-10-11 18:00   ` Matthew Brost
2021-10-11 18:00     ` [Intel-gfx] " Matthew Brost
2021-10-12 15:12     ` Michal Wajdeczko
2021-10-12 15:12       ` [Intel-gfx] " Michal Wajdeczko
2021-10-11 17:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Inject probe errors for MMIO send, " Patchwork
2021-10-11 20:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011152106.3424810-3-thanneeru.srinivasulu@intel.com \
    --to=thanneeru.srinivasulu@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.