[sashal-stable:pending-5.14 130/144] drivers/scsi/elx/efct/efct_scsi.c:47:2-8: preceding lock on line 41

[sashal-stable:pending-5.14 130/144] drivers/scsi/elx/efct/efct_scsi.c:47:2-8: preceding lock on line 41

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5420 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Sasha Levin <sashal@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-5.14
head:   b7fc3fc75d0f1978b7b8c6492cd73ea2396007a1
commit: 59039324b73785f01f6e9b53a4dda2a6510d13a9 [130/144] scsi: elx: efct: Delete stray unlock statement
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
config: powerpc64-randconfig-c024-20211011 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/scsi/elx/efct/efct_scsi.c:47:2-8: preceding lock on line 41

vim +47 drivers/scsi/elx/efct/efct_scsi.c

3e6414003bf9ac James Smart   2021-06-01  14  
3e6414003bf9ac James Smart   2021-06-01  15  #define scsi_io_printf(io, fmt, ...) \
3e6414003bf9ac James Smart   2021-06-01  16  	efc_log_debug(io->efct, "[%s]" SCSI_IOFMT fmt, \
3e6414003bf9ac James Smart   2021-06-01  17  		io->node->display_name, io->instance_index,\
3e6414003bf9ac James Smart   2021-06-01  18  		io->init_task_tag, io->tgt_task_tag, io->hw_tag, ##__VA_ARGS__)
3e6414003bf9ac James Smart   2021-06-01  19  
3e6414003bf9ac James Smart   2021-06-01  20  #define EFCT_LOG_ENABLE_SCSI_TRACE(efct)                \
3e6414003bf9ac James Smart   2021-06-01  21  		(((efct) != NULL) ? (((efct)->logmask & (1U << 2)) != 0) : 0)
3e6414003bf9ac James Smart   2021-06-01  22  
3e6414003bf9ac James Smart   2021-06-01  23  #define scsi_io_trace(io, fmt, ...) \
3e6414003bf9ac James Smart   2021-06-01  24  	do { \
3e6414003bf9ac James Smart   2021-06-01  25  		if (EFCT_LOG_ENABLE_SCSI_TRACE(io->efct)) \
3e6414003bf9ac James Smart   2021-06-01  26  			scsi_io_printf(io, fmt, ##__VA_ARGS__); \
3e6414003bf9ac James Smart   2021-06-01  27  	} while (0)
3e6414003bf9ac James Smart   2021-06-01  28  
3e6414003bf9ac James Smart   2021-06-01  29  struct efct_io *
3e6414003bf9ac James Smart   2021-06-01  30  efct_scsi_io_alloc(struct efct_node *node)
3e6414003bf9ac James Smart   2021-06-01  31  {
3e6414003bf9ac James Smart   2021-06-01  32  	struct efct *efct;
3e6414003bf9ac James Smart   2021-06-01  33  	struct efct_xport *xport;
3e6414003bf9ac James Smart   2021-06-01  34  	struct efct_io *io;
59039324b73785 Dan Carpenter 2021-10-04  35  	unsigned long flags;
3e6414003bf9ac James Smart   2021-06-01  36  
3e6414003bf9ac James Smart   2021-06-01  37  	efct = node->efct;
3e6414003bf9ac James Smart   2021-06-01  38  
3e6414003bf9ac James Smart   2021-06-01  39  	xport = efct->xport;
3e6414003bf9ac James Smart   2021-06-01  40  
3e6414003bf9ac James Smart   2021-06-01 @41  	spin_lock_irqsave(&node->active_ios_lock, flags);
3e6414003bf9ac James Smart   2021-06-01  42  
3e6414003bf9ac James Smart   2021-06-01  43  	io = efct_io_pool_io_alloc(efct->xport->io_pool);
3e6414003bf9ac James Smart   2021-06-01  44  	if (!io) {
3e6414003bf9ac James Smart   2021-06-01  45  		efc_log_err(efct, "IO alloc Failed\n");
3e6414003bf9ac James Smart   2021-06-01  46  		atomic_add_return(1, &xport->io_alloc_failed_count);
3e6414003bf9ac James Smart   2021-06-01 @47  		return NULL;
3e6414003bf9ac James Smart   2021-06-01  48  	}
3e6414003bf9ac James Smart   2021-06-01  49  
3e6414003bf9ac James Smart   2021-06-01  50  	/* initialize refcount */
3e6414003bf9ac James Smart   2021-06-01  51  	kref_init(&io->ref);
3e6414003bf9ac James Smart   2021-06-01  52  	io->release = _efct_scsi_io_free;
3e6414003bf9ac James Smart   2021-06-01  53  
3e6414003bf9ac James Smart   2021-06-01  54  	/* set generic fields */
3e6414003bf9ac James Smart   2021-06-01  55  	io->efct = efct;
3e6414003bf9ac James Smart   2021-06-01  56  	io->node = node;
3e6414003bf9ac James Smart   2021-06-01  57  	kref_get(&node->ref);
3e6414003bf9ac James Smart   2021-06-01  58  
3e6414003bf9ac James Smart   2021-06-01  59  	/* set type and name */
3e6414003bf9ac James Smart   2021-06-01  60  	io->io_type = EFCT_IO_TYPE_IO;
3e6414003bf9ac James Smart   2021-06-01  61  	io->display_name = "scsi_io";
3e6414003bf9ac James Smart   2021-06-01  62  
3e6414003bf9ac James Smart   2021-06-01  63  	io->cmd_ini = false;
3e6414003bf9ac James Smart   2021-06-01  64  	io->cmd_tgt = true;
3e6414003bf9ac James Smart   2021-06-01  65  
3e6414003bf9ac James Smart   2021-06-01  66  	/* Add to node's active_ios list */
3e6414003bf9ac James Smart   2021-06-01  67  	INIT_LIST_HEAD(&io->list_entry);
3e6414003bf9ac James Smart   2021-06-01  68  	list_add(&io->list_entry, &node->active_ios);
3e6414003bf9ac James Smart   2021-06-01  69  
3e6414003bf9ac James Smart   2021-06-01  70  	spin_unlock_irqrestore(&node->active_ios_lock, flags);
3e6414003bf9ac James Smart   2021-06-01  71  
3e6414003bf9ac James Smart   2021-06-01  72  	return io;
3e6414003bf9ac James Smart   2021-06-01  73  }
3e6414003bf9ac James Smart   2021-06-01  74  

:::::: The code at line 47 was first introduced by commit
:::::: 3e6414003bf9acd3b7e20474f950779fafb658d5 scsi: elx: efct: SCSI I/O handling routines

:::::: TO: James Smart <jsmart2021@gmail.com>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44024 bytes --]