* [PATCH v2] f2fs: fix to use WHINT_MODE
[not found] <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7>
@ 2021-09-30 0:59 ` Keoseong Park
0 siblings, 0 replies; 6+ messages in thread
From: Keoseong Park @ 2021-09-30 0:59 UTC (permalink / raw)
To: jaegeuk, chao
Cc: linux-f2fs-devel, linux-kernel, tanghuan, changfengnan,
Daejun Park, Jinyoung CHOI, Sung-Jun Park
Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
it cannot be set to NR_CURSEG_TYPE(8).
That is, whint_mode is always off.
Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
Cc: Chao Yu <chao@kernel.org>
Reported-by: Huan Tang <tanghuan@vivo.com>
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
v1 -> v2:
* Merge Signed-off and Reported tags for the same fix patch.
fs/f2fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 78ebc306ee2b..86eeb019cc52 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
/* Not pass down write hints if the number of active logs is lesser
* than NR_CURSEG_PERSIST_TYPE.
*/
- if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
+ if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE
@ 2021-09-30 0:59 ` Keoseong Park
0 siblings, 0 replies; 6+ messages in thread
From: Keoseong Park @ 2021-09-30 0:59 UTC (permalink / raw)
To: jaegeuk, chao
Cc: changfengnan, Sung-Jun Park, Jinyoung CHOI, linux-kernel,
tanghuan, linux-f2fs-devel
Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
it cannot be set to NR_CURSEG_TYPE(8).
That is, whint_mode is always off.
Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
Cc: Chao Yu <chao@kernel.org>
Reported-by: Huan Tang <tanghuan@vivo.com>
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
v1 -> v2:
* Merge Signed-off and Reported tags for the same fix patch.
fs/f2fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 78ebc306ee2b..86eeb019cc52 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
/* Not pass down write hints if the number of active logs is lesser
* than NR_CURSEG_PERSIST_TYPE.
*/
- if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
+ if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
--
2.17.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] f2fs: fix to use WHINT_MODE
2021-09-30 0:59 ` [f2fs-dev] " Keoseong Park
@ 2021-10-09 4:24 ` Chao Yu
-1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2021-10-09 4:24 UTC (permalink / raw)
To: keosung.park, jaegeuk
Cc: linux-f2fs-devel, linux-kernel, tanghuan, changfengnan,
Daejun Park, Jinyoung CHOI, Sung-Jun Park
On 2021/9/30 8:59, Keoseong Park wrote:
> Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
> it cannot be set to NR_CURSEG_TYPE(8).
> That is, whint_mode is always off.
>
> Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
>
Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
> Cc: Chao Yu <chao@kernel.org>
> Reported-by: Huan Tang <tanghuan@vivo.com>
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE
@ 2021-10-09 4:24 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2021-10-09 4:24 UTC (permalink / raw)
To: keosung.park, jaegeuk
Cc: changfengnan, Sung-Jun Park, Jinyoung CHOI, linux-kernel,
tanghuan, linux-f2fs-devel
On 2021/9/30 8:59, Keoseong Park wrote:
> Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
> it cannot be set to NR_CURSEG_TYPE(8).
> That is, whint_mode is always off.
>
> Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
>
Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
> Cc: Chao Yu <chao@kernel.org>
> Reported-by: Huan Tang <tanghuan@vivo.com>
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Re: [PATCH v2] f2fs: fix to use WHINT_MODE
[not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8>
@ 2021-10-12 2:16 ` Keoseong Park
0 siblings, 0 replies; 6+ messages in thread
From: Keoseong Park @ 2021-10-12 2:16 UTC (permalink / raw)
To: Chao Yu, Keoseong Park, jaegeuk
Cc: linux-f2fs-devel, linux-kernel, tanghuan, changfengnan,
Daejun Park, Jinyoung CHOI, Sung-Jun Park
Hi Chao,
>On 2021/9/30 8:59, Keoseong Park wrote:
>> Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
>> it cannot be set to NR_CURSEG_TYPE(8).
>> That is, whint_mode is always off.
>>
>> Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
>>
>
>Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
>
>> Cc: Chao Yu <chao@kernel.org>
>> Reported-by: Huan Tang <tanghuan@vivo.com>
>> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
>> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
>
>Reviewed-by: Chao Yu <chao@kernel.org>
Thank you for your review.
Best Regards,
Keoseong
>
>Thanks,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE
@ 2021-10-12 2:16 ` Keoseong Park
0 siblings, 0 replies; 6+ messages in thread
From: Keoseong Park @ 2021-10-12 2:16 UTC (permalink / raw)
To: Chao Yu, Keoseong Park, jaegeuk
Cc: changfengnan, Sung-Jun Park, Jinyoung CHOI, linux-kernel,
tanghuan, linux-f2fs-devel
Hi Chao,
>On 2021/9/30 8:59, Keoseong Park wrote:
>> Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
>> it cannot be set to NR_CURSEG_TYPE(8).
>> That is, whint_mode is always off.
>>
>> Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.
>>
>
>Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
>
>> Cc: Chao Yu <chao@kernel.org>
>> Reported-by: Huan Tang <tanghuan@vivo.com>
>> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
>> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
>
>Reviewed-by: Chao Yu <chao@kernel.org>
Thank you for your review.
Best Regards,
Keoseong
>
>Thanks,
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-12 2:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7>
2021-09-30 0:59 ` [PATCH v2] f2fs: fix to use WHINT_MODE Keoseong Park
2021-09-30 0:59 ` [f2fs-dev] " Keoseong Park
2021-10-09 4:24 ` Chao Yu
2021-10-09 4:24 ` [f2fs-dev] " Chao Yu
[not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8>
2021-10-12 2:16 ` Keoseong Park
2021-10-12 2:16 ` [f2fs-dev] " Keoseong Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.