* [PATCH] libtraceevent: Fix for print_field
@ 2021-09-20 18:37 Ian Rogers
2021-09-27 21:17 ` Ian Rogers
2021-10-12 18:24 ` Steven Rostedt
0 siblings, 2 replies; 4+ messages in thread
From: Ian Rogers @ 2021-09-20 18:37 UTC (permalink / raw)
To: linux-trace-devel, Tzvetomir Stoyanov, Steven Rostedt; +Cc: Ian Rogers
Correct a typo in an operator which resolves a clang warning:
src/event-parse.c:5408:41: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]
if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
^
Signed-off-by: Ian Rogers <irogers@google.com>
---
src/event-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/event-parse.c b/src/event-parse.c
index 8057fb5..7063758 100644
--- a/src/event-parse.c
+++ b/src/event-parse.c
@@ -5405,7 +5405,7 @@ void static inline print_field(struct trace_seq *s, void *data,
if (!parse || event->flags & TEP_EVENT_FL_FAILED)
goto out;
- if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
+ if (field->flags & (TEP_FIELD_IS_ARRAY | TEP_FIELD_IS_STRING))
goto out;
start_parse = parse;
--
2.33.0.464.g1972c5931b-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libtraceevent: Fix for print_field
2021-09-20 18:37 [PATCH] libtraceevent: Fix for print_field Ian Rogers
@ 2021-09-27 21:17 ` Ian Rogers
2021-09-27 22:02 ` Steven Rostedt
2021-10-12 18:24 ` Steven Rostedt
1 sibling, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2021-09-27 21:17 UTC (permalink / raw)
To: linux-trace-devel, Tzvetomir Stoyanov, Steven Rostedt
On Mon, Sep 20, 2021 at 11:37 AM Ian Rogers <irogers@google.com> wrote:
>
> Correct a typo in an operator which resolves a clang warning:
>
> src/event-parse.c:5408:41: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]
> if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
> ^
> Signed-off-by: Ian Rogers <irogers@google.com>
Ping. Thanks,
Ian
> ---
> src/event-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/event-parse.c b/src/event-parse.c
> index 8057fb5..7063758 100644
> --- a/src/event-parse.c
> +++ b/src/event-parse.c
> @@ -5405,7 +5405,7 @@ void static inline print_field(struct trace_seq *s, void *data,
> if (!parse || event->flags & TEP_EVENT_FL_FAILED)
> goto out;
>
> - if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
> + if (field->flags & (TEP_FIELD_IS_ARRAY | TEP_FIELD_IS_STRING))
> goto out;
>
> start_parse = parse;
> --
> 2.33.0.464.g1972c5931b-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libtraceevent: Fix for print_field
2021-09-20 18:37 [PATCH] libtraceevent: Fix for print_field Ian Rogers
2021-09-27 21:17 ` Ian Rogers
@ 2021-10-12 18:24 ` Steven Rostedt
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2021-10-12 18:24 UTC (permalink / raw)
To: Ian Rogers; +Cc: linux-trace-devel, Tzvetomir Stoyanov
On Mon, 20 Sep 2021 11:37:15 -0700
Ian Rogers <irogers@google.com> wrote:
> Correct a typo in an operator which resolves a clang warning:
>
> src/event-parse.c:5408:41: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]
> if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
> ^
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> src/event-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/event-parse.c b/src/event-parse.c
> index 8057fb5..7063758 100644
> --- a/src/event-parse.c
> +++ b/src/event-parse.c
> @@ -5405,7 +5405,7 @@ void static inline print_field(struct trace_seq *s, void *data,
> if (!parse || event->flags & TEP_EVENT_FL_FAILED)
> goto out;
>
> - if (field->flags & (TEP_FIELD_IS_ARRAY || TEP_FIELD_IS_STRING))
> + if (field->flags & (TEP_FIELD_IS_ARRAY | TEP_FIELD_IS_STRING))
Bah, I should have caught this in my review.
Another example of the usefulness of clang errors.
Applied, thanks Ian!
-- Steve
> goto out;
>
> start_parse = parse;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-12 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 18:37 [PATCH] libtraceevent: Fix for print_field Ian Rogers
2021-09-27 21:17 ` Ian Rogers
2021-09-27 22:02 ` Steven Rostedt
2021-10-12 18:24 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.