From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 22/23] target/tricore: Drop check for singlestep_enabled
Date: Tue, 12 Oct 2021 09:21:58 -0700 [thread overview]
Message-ID: <20211012162159.471406-23-richard.henderson@linaro.org> (raw)
In-Reply-To: <20211012162159.471406-1-richard.henderson@linaro.org>
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/tricore/helper.h | 1 -
target/tricore/op_helper.c | 7 -------
target/tricore/translate.c | 14 +-------------
3 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/target/tricore/helper.h b/target/tricore/helper.h
index 78176aa17a..b64780c37d 100644
--- a/target/tricore/helper.h
+++ b/target/tricore/helper.h
@@ -153,4 +153,3 @@ DEF_HELPER_2(psw_write, void, env, i32)
DEF_HELPER_1(psw_read, i32, env)
/* Exceptions */
DEF_HELPER_3(raise_exception_sync, noreturn, env, i32, i32)
-DEF_HELPER_2(qemu_excp, noreturn, env, i32)
diff --git a/target/tricore/op_helper.c b/target/tricore/op_helper.c
index 32c2bc1699..9476d10d00 100644
--- a/target/tricore/op_helper.c
+++ b/target/tricore/op_helper.c
@@ -107,13 +107,6 @@ static void raise_exception_sync_helper(CPUTriCoreState *env, uint32_t class,
raise_exception_sync_internal(env, class, tin, pc, 0);
}
-void helper_qemu_excp(CPUTriCoreState *env, uint32_t excp)
-{
- CPUState *cs = env_cpu(env);
- cs->exception_index = excp;
- cpu_loop_exit(cs);
-}
-
/* Addressing mode helper */
static uint16_t reverse16(uint16_t val)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index a0cc0f1cb3..07084407cb 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -3225,14 +3225,6 @@ static inline void gen_save_pc(target_ulong pc)
tcg_gen_movi_tl(cpu_PC, pc);
}
-static void generate_qemu_excp(DisasContext *ctx, int excp)
-{
- TCGv_i32 tmp = tcg_const_i32(excp);
- gen_helper_qemu_excp(cpu_env, tmp);
- ctx->base.is_jmp = DISAS_NORETURN;
- tcg_temp_free(tmp);
-}
-
static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
{
if (translator_use_goto_tb(&ctx->base, dest)) {
@@ -3241,11 +3233,7 @@ static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
tcg_gen_exit_tb(ctx->base.tb, n);
} else {
gen_save_pc(dest);
- if (ctx->base.singlestep_enabled) {
- generate_qemu_excp(ctx, EXCP_DEBUG);
- } else {
- tcg_gen_lookup_and_goto_ptr();
- }
+ tcg_gen_lookup_and_goto_ptr();
}
}
--
2.25.1
next prev parent reply other threads:[~2021-10-12 16:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:21 [PATCH v2 00/23] tcg: singlestep reorg Richard Henderson
2021-10-12 16:21 ` [PATCH v2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec Richard Henderson
2021-10-12 16:21 ` [PATCH v2 02/23] target/alpha: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 22:32 ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 03/23] target/avr: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 04/23] target/cris: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 05/23] target/hexagon: " Richard Henderson
2021-10-12 22:30 ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 06/23] target/arm: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 07/23] target/hppa: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 08/23] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt Richard Henderson
2021-10-12 16:21 ` [PATCH v2 09/23] target/i386: Drop check for singlestep_enabled Richard Henderson
2021-10-12 16:21 ` [PATCH v2 10/23] target/m68k: Drop checks " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP Richard Henderson
2021-10-12 16:21 ` [PATCH v2 12/23] target/microblaze: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 16:21 ` [PATCH v2 13/23] target/mips: Fix single stepping Richard Henderson
2021-10-12 22:26 ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 14/23] target/mips: Drop exit checks for singlestep_enabled Richard Henderson
2021-10-12 16:21 ` [PATCH v2 15/23] target/openrisc: Drop " Richard Henderson
2021-10-12 22:32 ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 16/23] target/ppc: Drop exit " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 17/23] target/riscv: Remove dead code after exception Richard Henderson
2021-10-12 21:35 ` Alistair Francis
2021-10-12 16:21 ` [PATCH v2 18/23] target/riscv: Remove exit_tb and lookup_and_goto_ptr Richard Henderson
2021-10-12 21:34 ` Alistair Francis
2021-10-12 16:21 ` [PATCH v2 19/23] target/rx: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 22:28 ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 20/23] target/s390x: Drop check " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 21/23] target/sh4: " Richard Henderson
2021-10-12 16:21 ` Richard Henderson [this message]
2021-10-12 22:29 ` [PATCH v2 22/23] target/tricore: " Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 23/23] target/xtensa: " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012162159.471406-23-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.