All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 08/23] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt
Date: Tue, 12 Oct 2021 09:21:44 -0700	[thread overview]
Message-ID: <20211012162159.471406-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20211012162159.471406-1-richard.henderson@linaro.org>

We were using singlestep_enabled as a proxy for whether
translator_use_goto_tb would always return false.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/i386/tcg/translate.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index a46be75b00..c8d919bc3f 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -8556,6 +8556,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
     DisasContext *dc = container_of(dcbase, DisasContext, base);
     CPUX86State *env = cpu->env_ptr;
     uint32_t flags = dc->base.tb->flags;
+    uint32_t cflags = tb_cflags(dc->base.tb);
     int cpl = (flags >> HF_CPL_SHIFT) & 3;
     int iopl = (flags >> IOPL_SHIFT) & 3;
 
@@ -8593,14 +8594,14 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
     dc->cpuid_ext3_features = env->features[FEAT_8000_0001_ECX];
     dc->cpuid_7_0_ebx_features = env->features[FEAT_7_0_EBX];
     dc->cpuid_xsave_features = env->features[FEAT_XSAVE];
-    dc->jmp_opt = !(dc->base.singlestep_enabled ||
+    dc->jmp_opt = !((cflags & CF_NO_GOTO_TB) ||
                     (flags & (HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
     /*
      * If jmp_opt, we want to handle each string instruction individually.
      * For icount also disable repz optimization so that each iteration
      * is accounted separately.
      */
-    dc->repz_opt = !dc->jmp_opt && !(tb_cflags(dc->base.tb) & CF_USE_ICOUNT);
+    dc->repz_opt = !dc->jmp_opt && !(cflags & CF_USE_ICOUNT);
 
     dc->T0 = tcg_temp_new();
     dc->T1 = tcg_temp_new();
-- 
2.25.1



  parent reply	other threads:[~2021-10-12 16:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 16:21 [PATCH v2 00/23] tcg: singlestep reorg Richard Henderson
2021-10-12 16:21 ` [PATCH v2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec Richard Henderson
2021-10-12 16:21 ` [PATCH v2 02/23] target/alpha: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 22:32   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 03/23] target/avr: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 04/23] target/cris: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 05/23] target/hexagon: " Richard Henderson
2021-10-12 22:30   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 06/23] target/arm: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 07/23] target/hppa: " Richard Henderson
2021-10-12 16:21 ` Richard Henderson [this message]
2021-10-12 16:21 ` [PATCH v2 09/23] target/i386: Drop check " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 10/23] target/m68k: Drop checks " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP Richard Henderson
2021-10-12 16:21 ` [PATCH v2 12/23] target/microblaze: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 16:21 ` [PATCH v2 13/23] target/mips: Fix single stepping Richard Henderson
2021-10-12 22:26   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 14/23] target/mips: Drop exit checks for singlestep_enabled Richard Henderson
2021-10-12 16:21 ` [PATCH v2 15/23] target/openrisc: Drop " Richard Henderson
2021-10-12 22:32   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 16/23] target/ppc: Drop exit " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 17/23] target/riscv: Remove dead code after exception Richard Henderson
2021-10-12 21:35   ` Alistair Francis
2021-10-12 16:21 ` [PATCH v2 18/23] target/riscv: Remove exit_tb and lookup_and_goto_ptr Richard Henderson
2021-10-12 21:34   ` Alistair Francis
2021-10-12 16:21 ` [PATCH v2 19/23] target/rx: Drop checks for singlestep_enabled Richard Henderson
2021-10-12 22:28   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 20/23] target/s390x: Drop check " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 21/23] target/sh4: " Richard Henderson
2021-10-12 16:21 ` [PATCH v2 22/23] target/tricore: " Richard Henderson
2021-10-12 22:29   ` Philippe Mathieu-Daudé
2021-10-12 16:21 ` [PATCH v2 23/23] target/xtensa: " Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012162159.471406-9-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.