All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, kasan-dev@googlegroups.com,
	Vlastimil Babka <vbabka@suse.cz>,
	Dmitry Vyukov <dvyukov@google.com>,
	Marco Elver <elver@google.com>,
	Vijayanand Jitta <vjitta@codeaurora.org>
Subject: [RFC PATCH] lib/stackdepot: stack_depot_init_mutex can be static
Date: Wed, 13 Oct 2021 05:52:33 +0800	[thread overview]
Message-ID: <20211012215233.GA41525@800d2291961c> (raw)
In-Reply-To: <20211012090621.1357-1-vbabka@suse.cz>

lib/stackdepot.c:150:1: warning: symbol 'stack_depot_init_mutex' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 stackdepot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 9bb5333bf02f61..89b67aef9b320b 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -147,7 +147,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
-DEFINE_MUTEX(stack_depot_init_mutex);
+static DEFINE_MUTEX(stack_depot_init_mutex);
 static bool stack_depot_disable;
 static struct stack_record **stack_table;
 

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, kasan-dev@googlegroups.com,
	Vlastimil Babka <vbabka@suse.cz>,
	Dmitry Vyukov <dvyukov@google.com>,
	Marco Elver <elver@google.com>,
	Vijayanand Jitta <vjitta@codeaurora.org>
Subject: [Intel-gfx] [RFC PATCH] lib/stackdepot: stack_depot_init_mutex can be static
Date: Wed, 13 Oct 2021 05:52:33 +0800	[thread overview]
Message-ID: <20211012215233.GA41525@800d2291961c> (raw)
In-Reply-To: <20211012090621.1357-1-vbabka@suse.cz>

lib/stackdepot.c:150:1: warning: symbol 'stack_depot_init_mutex' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 stackdepot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 9bb5333bf02f61..89b67aef9b320b 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -147,7 +147,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
-DEFINE_MUTEX(stack_depot_init_mutex);
+static DEFINE_MUTEX(stack_depot_init_mutex);
 static bool stack_depot_disable;
 static struct stack_record **stack_table;
 

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] lib/stackdepot: stack_depot_init_mutex can be static
Date: Wed, 13 Oct 2021 05:52:33 +0800	[thread overview]
Message-ID: <20211012215233.GA41525@800d2291961c> (raw)
In-Reply-To: <20211012090621.1357-1-vbabka@suse.cz>

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

lib/stackdepot.c:150:1: warning: symbol 'stack_depot_init_mutex' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 stackdepot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 9bb5333bf02f61..89b67aef9b320b 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -147,7 +147,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 
-DEFINE_MUTEX(stack_depot_init_mutex);
+static DEFINE_MUTEX(stack_depot_init_mutex);
 static bool stack_depot_disable;
 static struct stack_record **stack_table;
 

  parent reply	other threads:[~2021-10-12 21:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  9:06 [PATCH v2] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() Vlastimil Babka
2021-10-12  9:06 ` [Intel-gfx] " Vlastimil Babka
2021-10-12  9:57 ` Marco Elver
2021-10-12  9:57   ` [Intel-gfx] " Marco Elver
2021-10-12 11:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2) Patchwork
2021-10-12 12:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-12 18:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-12 21:52 ` [PATCH v2] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() kernel test robot
2021-10-12 21:52   ` kernel test robot
2021-10-12 21:52   ` [Intel-gfx] " kernel test robot
2021-10-12 21:52 ` kernel test robot [this message]
2021-10-12 21:52   ` [RFC PATCH] lib/stackdepot: stack_depot_init_mutex can be static kernel test robot
2021-10-12 21:52   ` [Intel-gfx] " kernel test robot
2021-10-13  7:30 ` [PATCH v3] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() Vlastimil Babka
2021-10-13  7:30   ` [Intel-gfx] " Vlastimil Babka
2021-10-15  8:57   ` Vlastimil Babka
2021-10-15  8:57     ` [Intel-gfx] " Vlastimil Babka
2021-10-13  7:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev3) Patchwork
2021-10-13  8:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-13 10:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-14  8:54 ` [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address kernel test robot
2021-10-14  8:54   ` kernel test robot
2021-10-14  8:54   ` [Intel-gfx] " kernel test robot
2021-10-14  9:33   ` Vlastimil Babka
2021-10-14  9:33     ` Vlastimil Babka
2021-10-14  9:33     ` [Intel-gfx] " Vlastimil Babka
2021-10-14 10:16     ` Mike Rapoport
2021-10-14 10:16       ` Mike Rapoport
2021-10-14 10:16       ` [Intel-gfx] " Mike Rapoport
2021-10-15  8:27       ` Vlastimil Babka
2021-10-15  8:27         ` Vlastimil Babka
2021-10-15  8:27         ` [Intel-gfx] " Vlastimil Babka
2021-10-15  8:55         ` Mike Rapoport
2021-10-15  8:55           ` Mike Rapoport
2021-10-15  8:55           ` [Intel-gfx] " Mike Rapoport
2021-10-15  9:28 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012215233.GA41525@800d2291961c \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kasan-dev@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    --cc=vjitta@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.