* [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe()
@ 2021-10-13 8:08 Dan Carpenter
2021-10-14 18:54 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-10-13 8:08 UTC (permalink / raw)
To: Andrzej Hajda, Laurent Pinchart
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
David Airlie, Daniel Vetter, Boris Brezillon, Tomi Valkeinen,
Sebastian Reichel, Sam Ravnborg, dri-devel, kernel-janitors
The "label" pointer is used for debug output. The code assumes that it
is either NULL or valid, but it is never set to NULL. It is either
valid or uninitialized.
Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/bridge/display-connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
index 05eb759da6fc..847a0dce7f1d 100644
--- a/drivers/gpu/drm/bridge/display-connector.c
+++ b/drivers/gpu/drm/bridge/display-connector.c
@@ -107,7 +107,7 @@ static int display_connector_probe(struct platform_device *pdev)
{
struct display_connector *conn;
unsigned int type;
- const char *label;
+ const char *label = NULL;
int ret;
conn = devm_kzalloc(&pdev->dev, sizeof(*conn), GFP_KERNEL);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe()
2021-10-13 8:08 [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe() Dan Carpenter
@ 2021-10-14 18:54 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2021-10-14 18:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrzej Hajda, Laurent Pinchart, Neil Armstrong, Robert Foss,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Boris Brezillon, Tomi Valkeinen, Sebastian Reichel, dri-devel,
kernel-janitors
Hi Dan,
On Wed, Oct 13, 2021 at 11:08:25AM +0300, Dan Carpenter wrote:
> The "label" pointer is used for debug output. The code assumes that it
> is either NULL or valid, but it is never set to NULL. It is either
> valid or uninitialized.
>
> Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to drm-misc-next.
It was IMO not urgent.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-14 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 8:08 [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe() Dan Carpenter
2021-10-14 18:54 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.