* [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs
@ 2021-10-13 8:16 Sreekanth Reddy
2021-10-13 8:23 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Sreekanth Reddy @ 2021-10-13 8:16 UTC (permalink / raw)
To: linux-scsi, martin.petersen
Cc: thenzl, sathya.prakash, stable, Sreekanth Reddy
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
When the user scans the devices through 'scan' sysfs using below
command then the user will observe duplicate device entries
in lsscsi command output.
echo "- - -" > /sys/class/scsi_host/host0/scan
Fix is to set the shost's max_channel to zero.
Cc: stable@vger.kernel.org #v5.14.11+
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
drivers/scsi/mpi3mr/mpi3mr_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index 2197988333fe..3cae8803383b 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -3736,7 +3736,7 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
shost->max_lun = -1;
shost->unique_id = mrioc->id;
- shost->max_channel = 1;
+ shost->max_channel = 0;
shost->max_id = 0xFFFFFFFF;
if (prot_mask >= 0)
--
2.27.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs
2021-10-13 8:16 [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs Sreekanth Reddy
@ 2021-10-13 8:23 ` Greg KH
2021-10-13 16:05 ` Sreekanth Reddy
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2021-10-13 8:23 UTC (permalink / raw)
To: Sreekanth Reddy
Cc: linux-scsi, martin.petersen, thenzl, sathya.prakash, stable
On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote:
> When the user scans the devices through 'scan' sysfs using below
> command then the user will observe duplicate device entries
> in lsscsi command output.
> echo "- - -" > /sys/class/scsi_host/host0/scan
>
> Fix is to set the shost's max_channel to zero.
>
> Cc: stable@vger.kernel.org #v5.14.11+
Please tag this based on a release of Linus's, or better yet, provide a
"Fixes:" commit so that the stable people know exactly where to backport
it to.
As this is, we do not take patches only for stable kernels...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs
2021-10-13 8:23 ` Greg KH
@ 2021-10-13 16:05 ` Sreekanth Reddy
2021-10-13 16:40 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Sreekanth Reddy @ 2021-10-13 16:05 UTC (permalink / raw)
To: Greg KH
Cc: linux-scsi, Martin K. Petersen, Tomas Henzl,
Sathya Prakash Veerichetty, stable
On Wed, Oct 13, 2021 at 1:53 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote:
> > When the user scans the devices through 'scan' sysfs using below
> > command then the user will observe duplicate device entries
> > in lsscsi command output.
> > echo "- - -" > /sys/class/scsi_host/host0/scan
> >
> > Fix is to set the shost's max_channel to zero.
> >
> > Cc: stable@vger.kernel.org #v5.14.11+
>
> Please tag this based on a release of Linus's, or better yet, provide a
> "Fixes:" commit so that the stable people know exactly where to backport
> it to.
Thanks, Shall I resend the patch with proper "Fixes:" commit ID.
>
> As this is, we do not take patches only for stable kernels...
This fix applies for the mainline kernel as well.
Thanks,
Sreekanth
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs
2021-10-13 16:05 ` Sreekanth Reddy
@ 2021-10-13 16:40 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-10-13 16:40 UTC (permalink / raw)
To: Sreekanth Reddy
Cc: linux-scsi, Martin K. Petersen, Tomas Henzl,
Sathya Prakash Veerichetty, stable
On Wed, Oct 13, 2021 at 09:35:39PM +0530, Sreekanth Reddy wrote:
> On Wed, Oct 13, 2021 at 1:53 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Oct 13, 2021 at 01:46:56PM +0530, Sreekanth Reddy wrote:
> > > When the user scans the devices through 'scan' sysfs using below
> > > command then the user will observe duplicate device entries
> > > in lsscsi command output.
> > > echo "- - -" > /sys/class/scsi_host/host0/scan
> > >
> > > Fix is to set the shost's max_channel to zero.
> > >
> > > Cc: stable@vger.kernel.org #v5.14.11+
> >
> > Please tag this based on a release of Linus's, or better yet, provide a
> > "Fixes:" commit so that the stable people know exactly where to backport
> > it to.
> Thanks, Shall I resend the patch with proper "Fixes:" commit ID.
Yes please.
> > As this is, we do not take patches only for stable kernels...
> This fix applies for the mainline kernel as well.
That's good, as that is the only way to get patches accepted :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-13 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 8:16 [PATCH] mpi3mr: Fix duplicate device entries when scan through sysfs Sreekanth Reddy
2021-10-13 8:23 ` Greg KH
2021-10-13 16:05 ` Sreekanth Reddy
2021-10-13 16:40 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.