[PATCH net-next] ethernet: remove random_ether_addr()

[PATCH net-next] ethernet: remove random_ether_addr()

[Jakub Kicinski]

random_ether_addr() was the original name of the helper which
was kept for backward compatibility (?) after the rename in
commit 0a4dd594982a ("etherdevice: Rename random_ether_addr
to eth_random_addr").

We have a single random_ether_addr() caller left in tree
while there are 70 callers of eth_random_addr().
Time to drop this define.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: grygorii.strashko@ti.com
CC: vigneshr@ti.com
CC: joe@perches.com
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
 include/linux/etherdevice.h              | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 6904bfaa5777..c092cb61416a 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1918,7 +1918,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 							port->port_id,
 							port->slave.mac_addr);
 			if (!is_valid_ether_addr(port->slave.mac_addr)) {
-				random_ether_addr(port->slave.mac_addr);
+				eth_random_addr(port->slave.mac_addr);
 				dev_err(dev, "Use random MAC address\n");
 			}
 		}
diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 76f7ff684cbf..23681c3d3b8a 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -234,8 +234,6 @@ static inline void eth_random_addr(u8 *addr)
 	addr[0] |= 0x02;	/* set local assignment bit (IEEE802) */
 }
 
-#define random_ether_addr(addr) eth_random_addr(addr)
-
 /**
  * eth_broadcast_addr - Assign broadcast address
  * @addr: Pointer to a six-byte array containing the Ethernet address
-- 
2.31.1

Re: [PATCH net-next] ethernet: remove random_ether_addr()

[Simon Horman]

On Wed, Oct 13, 2021 at 01:54:50PM -0700, Jakub Kicinski wrote:
> random_ether_addr() was the original name of the helper which
> was kept for backward compatibility (?) after the rename in
> commit 0a4dd594982a ("etherdevice: Rename random_ether_addr
> to eth_random_addr").
> 
> We have a single random_ether_addr() caller left in tree
> while there are 70 callers of eth_random_addr().
> Time to drop this define.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH net-next] ethernet: remove random_ether_addr()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 13 Oct 2021 13:54:50 -0700 you wrote:
> random_ether_addr() was the original name of the helper which
> was kept for backward compatibility (?) after the rename in
> commit 0a4dd594982a ("etherdevice: Rename random_ether_addr
> to eth_random_addr").
> 
> We have a single random_ether_addr() caller left in tree
> while there are 70 callers of eth_random_addr().
> Time to drop this define.
> 
> [...]

Here is the summary with links:
  - [net-next] ethernet: remove random_ether_addr()
    https://git.kernel.org/netdev/net-next/c/ba530fea8ca1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html