[PATCH] drm/mcde: dsi: Add of_node_put() before return

* [PATCH] drm/mcde: dsi: Add of_node_put() before return
@ 2021-10-14  7:00 Wan Jiabing
  0 siblings, 0 replies; only message in thread
From: Wan Jiabing @ 2021-10-14  7:00 UTC (permalink / raw)
  To: Linus Walleij, David Airlie, Daniel Vetter, dri-devel, linux-kernel
  Cc: kael_w, Wan Jiabing

Fix following coccicheck warning:

./drivers/gpu/drm/mcde/mcde_dsi.c:1104:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return

Early exits from for_each_available_child_of_node should decrement the
node reference counter.
 
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/gpu/drm/mcde/mcde_dsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 5651734ce977..9f9ac8699310 100644
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
 			bridge = of_drm_find_bridge(child);
 			if (!bridge) {
 				dev_err(dev, "failed to find bridge\n");
+				of_node_put(child);
 				return -EINVAL;
 			}
 		}
-- 
2.20.1


^ permalink raw reply related	[flat|nested] only message in thread