[PATCH v2 0/1] sssd: re-package to fix QA issues

[PATCH v2 0/1] sssd: re-package to fix QA issues

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

v2:
* replace _ with - new sub-package name
* allow empty for new sub-package that it is enabled/disabled by a
  package config

Kai Kang (1):
  sssd: re-package to fix QA issues

 recipes-security/sssd/sssd_2.5.2.bb | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

-- 
2.17.1

[PATCH v2 1/1] sssd: re-package to fix QA issues

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

It packages all file in ${libdir} to package sssd, including the .so
symlink files. Then it causes QA issues:

| ERROR: QA Issue: sssd rdepends on dbus-dev [dev-deps]
| ERROR: QA Issue: sssd rdepends on ding-libs-dev [dev-deps]

So re-package sssd then the .so symlink files and .pc files are packaged
to sssd-dev which should be.

File ${libdir}/libsss_sudo.so is not a symlink file but packaged to
sssd-dev too. Then causes another QA issue:

| ERROR: sssd-2.5.2-r0 do_package_qa: QA Issue:
    -dev package sssd-dev contains non-symlink .so '/usr/lib/libsss_sudo.so' [dev-elf]

So create a new sub-package libsss-sudo to package file libsss_sudo.so
and make sssd rdepends on it.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 recipes-security/sssd/sssd_2.5.2.bb | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb
index 76d6e03..ed8af5e 100644
--- a/recipes-security/sssd/sssd_2.5.2.bb
+++ b/recipes-security/sssd/sssd_2.5.2.bb
@@ -125,10 +125,14 @@ SYSTEMD_SERVICE:${PN} = " \
 "
 SYSTEMD_AUTO_ENABLE = "disable"
 
-FILES:${PN} += "${libdir} ${datadir} ${base_libdir}/security/pam_sss*.so"
-FILES:${PN}-dev = " ${includedir}/* ${libdir}/*la ${libdir}/*/*la"
+PACKAGES =+ "libsss-sudo"
+ALLOW_EMPTY:libsss-sudo = "1"
 
-# The package contains symlinks that trip up insane
-INSANE_SKIP:${PN} = "dev-so"
+FILES:${PN} += "${base_libdir}/security/pam_sss*.so  \
+                ${datadir}/dbus-1/system-services/*.service \
+                ${libdir}/krb5/* \
+                ${libdir}/ldb/* \
+                "
+FILES:libsss-sudo = "${libdir}/libsss_sudo.so"
 
-RDEPENDS:${PN} = "bind bind-utils dbus libldb libpam"
+RDEPENDS:${PN} = "bind bind-utils dbus libldb libpam libsss-sudo"
-- 
2.17.1

Re: [yocto] [PATCH v2 1/1] sssd: re-package to fix QA issues

[Kai]

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]

On 10/14/21 4:59 PM, kai wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> It packages all file in ${libdir} to package sssd, including the .so
> symlink files. Then it causes QA issues:
>
> | ERROR: QA Issue: sssd rdepends on dbus-dev [dev-deps]
> | ERROR: QA Issue: sssd rdepends on ding-libs-dev [dev-deps]
>
> So re-package sssd then the .so symlink files and .pc files are packaged
> to sssd-dev which should be.
>
> File ${libdir}/libsss_sudo.so is not a symlink file but packaged to
> sssd-dev too. Then causes another QA issue:
>
> | ERROR: sssd-2.5.2-r0 do_package_qa: QA Issue:
>      -dev package sssd-dev contains non-symlink .so '/usr/lib/libsss_sudo.so' [dev-elf]
>
> So create a new sub-package libsss-sudo to package file libsss_sudo.so
> and make sssd rdepends on it.

Hi Armin,

Ping in case you may miss it.

Regards,
Kai

>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   recipes-security/sssd/sssd_2.5.2.bb | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb
> index 76d6e03..ed8af5e 100644
> --- a/recipes-security/sssd/sssd_2.5.2.bb
> +++ b/recipes-security/sssd/sssd_2.5.2.bb
> @@ -125,10 +125,14 @@ SYSTEMD_SERVICE:${PN} = " \
>   "
>   SYSTEMD_AUTO_ENABLE = "disable"
>   
> -FILES:${PN} += "${libdir} ${datadir} ${base_libdir}/security/pam_sss*.so"
> -FILES:${PN}-dev = " ${includedir}/* ${libdir}/*la ${libdir}/*/*la"
> +PACKAGES =+ "libsss-sudo"
> +ALLOW_EMPTY:libsss-sudo = "1"
>   
> -# The package contains symlinks that trip up insane
> -INSANE_SKIP:${PN} = "dev-so"
> +FILES:${PN} += "${base_libdir}/security/pam_sss*.so  \
> +                ${datadir}/dbus-1/system-services/*.service \
> +                ${libdir}/krb5/* \
> +                ${libdir}/ldb/* \
> +                "
> +FILES:libsss-sudo = "${libdir}/libsss_sudo.so"
>   
> -RDEPENDS:${PN} = "bind bind-utils dbus libldb libpam"
> +RDEPENDS:${PN} = "bind bind-utils dbus libldb libpam libsss-sudo"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#55069): https://lists.yoctoproject.org/g/yocto/message/55069
> Mute This Topic: https://lists.yoctoproject.org/mt/86307938/3616933
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [kai.kang@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

-- 
Kai Kang
Wind River Linux


[-- Attachment #2: Type: text/html, Size: 3758 bytes --]