From: Horatiu Vultur <horatiu.vultur@microchip.com> To: <linus.walleij@linaro.org>, <robh+dt@kernel.org>, <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>, <UNGLinuxDriver@microchip.com>, <p.zabel@pengutronix.de>, <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: Horatiu Vultur <horatiu.vultur@microchip.com> Subject: [PATCH v3 2/2] pinctrl: microchip sgpio: use reset driver Date: Thu, 14 Oct 2021 10:59:29 +0200 [thread overview] Message-ID: <20211014085929.2579695-3-horatiu.vultur@microchip.com> (raw) In-Reply-To: <20211014085929.2579695-1-horatiu.vultur@microchip.com> On lan966x platform when the switch gets reseted then also the sgpio gets reseted. The fix for this is to extend also the sgpio driver to call the reset driver which will be reseted only once by the first driver that is probed. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 072bccdea2a5..e8a91d0824cb 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -17,6 +17,7 @@ #include <linux/pinctrl/pinmux.h> #include <linux/platform_device.h> #include <linux/property.h> +#include <linux/reset.h> #include "core.h" #include "pinconf.h" @@ -803,6 +804,7 @@ static int microchip_sgpio_probe(struct platform_device *pdev) int div_clock = 0, ret, port, i, nbanks; struct device *dev = &pdev->dev; struct fwnode_handle *fwnode; + struct reset_control *reset; struct sgpio_priv *priv; struct clk *clk; u32 val; @@ -813,6 +815,10 @@ static int microchip_sgpio_probe(struct platform_device *pdev) priv->dev = dev; + reset = devm_reset_control_get_shared(&pdev->dev, "switch"); + if (!IS_ERR(reset)) + reset_control_reset(reset); + clk = devm_clk_get(dev, NULL); if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "Failed to get clock\n"); -- 2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: Horatiu Vultur <horatiu.vultur@microchip.com> To: <linus.walleij@linaro.org>, <robh+dt@kernel.org>, <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>, <UNGLinuxDriver@microchip.com>, <p.zabel@pengutronix.de>, <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: Horatiu Vultur <horatiu.vultur@microchip.com> Subject: [PATCH v3 2/2] pinctrl: microchip sgpio: use reset driver Date: Thu, 14 Oct 2021 10:59:29 +0200 [thread overview] Message-ID: <20211014085929.2579695-3-horatiu.vultur@microchip.com> (raw) In-Reply-To: <20211014085929.2579695-1-horatiu.vultur@microchip.com> On lan966x platform when the switch gets reseted then also the sgpio gets reseted. The fix for this is to extend also the sgpio driver to call the reset driver which will be reseted only once by the first driver that is probed. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 072bccdea2a5..e8a91d0824cb 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -17,6 +17,7 @@ #include <linux/pinctrl/pinmux.h> #include <linux/platform_device.h> #include <linux/property.h> +#include <linux/reset.h> #include "core.h" #include "pinconf.h" @@ -803,6 +804,7 @@ static int microchip_sgpio_probe(struct platform_device *pdev) int div_clock = 0, ret, port, i, nbanks; struct device *dev = &pdev->dev; struct fwnode_handle *fwnode; + struct reset_control *reset; struct sgpio_priv *priv; struct clk *clk; u32 val; @@ -813,6 +815,10 @@ static int microchip_sgpio_probe(struct platform_device *pdev) priv->dev = dev; + reset = devm_reset_control_get_shared(&pdev->dev, "switch"); + if (!IS_ERR(reset)) + reset_control_reset(reset); + clk = devm_clk_get(dev, NULL); if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "Failed to get clock\n"); -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-14 8:58 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-14 8:59 [PATCH v3 0/2] pinctrl: pinctrl-microchip-sgpio: Extend to call reset driver Horatiu Vultur 2021-10-14 8:59 ` Horatiu Vultur 2021-10-14 8:59 ` [PATCH v3 1/2] dt-bindings: pinctrl: pinctrl-microchip-sgpio: Add reset binding Horatiu Vultur 2021-10-14 8:59 ` Horatiu Vultur 2021-10-14 11:48 ` Philipp Zabel 2021-10-14 11:48 ` Philipp Zabel 2021-10-14 8:59 ` Horatiu Vultur [this message] 2021-10-14 8:59 ` [PATCH v3 2/2] pinctrl: microchip sgpio: use reset driver Horatiu Vultur 2021-10-14 11:47 ` Philipp Zabel 2021-10-14 11:47 ` Philipp Zabel 2021-10-14 14:37 ` Horatiu Vultur 2021-10-14 14:37 ` Horatiu Vultur 2021-10-15 13:46 ` Philipp Zabel 2021-10-15 13:46 ` Philipp Zabel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211014085929.2579695-3-horatiu.vultur@microchip.com \ --to=horatiu.vultur@microchip.com \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=lars.povlsen@microchip.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.