From: Horatiu Vultur <horatiu.vultur@microchip.com> To: Philipp Zabel <p.zabel@pengutronix.de> Cc: <robh+dt@kernel.org>, <andrew@lunn.ch>, <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>, <UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 1/2] dt-bindings: reset: Add lan966x support Date: Thu, 14 Oct 2021 17:20:16 +0200 [thread overview] Message-ID: <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost> (raw) In-Reply-To: <838af7b574968fc55d517a3becede5fa106ed896.camel@pengutronix.de> Hi Philipp, The 10/14/2021 13:55, Philipp Zabel wrote: > > On Wed, 2021-10-13 at 09:38 +0200, Horatiu Vultur wrote: > > This adds support for lan966x. > > > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > > --- > > .../devicetree/bindings/reset/microchip,rst.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > index 370579aeeca1..fb170ed2c57a 100644 > > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > @@ -20,7 +20,11 @@ properties: > > pattern: "^reset-controller@[0-9a-f]+$" > > > > compatible: > > - const: microchip,sparx5-switch-reset > > + oneOf: > > + - items: > > + - const: microchip,sparx5-switch-reset > > + - items: > > + - const: microchip,lan966x-switch-reset > > > > reg: > > items: > > @@ -37,6 +41,14 @@ properties: > > $ref: "/schemas/types.yaml#/definitions/phandle" > > description: syscon used to access CPU reset > > > > + cuphy-syscon: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: syscon used to access CuPHY > > Can this be used on sparx5? No, because the sparx5 doesn't have any internal PHYs that need to be released of the reset. > Is it optional on lan966x? No, it is required on lan966x. I will update the binding to show this. > > > + phy-reset-gpios: > > + description: used for release of reset of the external PHY > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > I'd like somebody to reassure me that putting the CuPHY reset and > external PHY GPIO reset in the reset controller is the right thing to > do. > > It looks fine to me, but I'm not sure if these should rather be in > separate phy nodes that are referenced from the switch. > > regards > Philipp -- /Horatiu
WARNING: multiple messages have this Message-ID (diff)
From: Horatiu Vultur <horatiu.vultur@microchip.com> To: Philipp Zabel <p.zabel@pengutronix.de> Cc: <robh+dt@kernel.org>, <andrew@lunn.ch>, <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>, <UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 1/2] dt-bindings: reset: Add lan966x support Date: Thu, 14 Oct 2021 17:20:16 +0200 [thread overview] Message-ID: <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost> (raw) In-Reply-To: <838af7b574968fc55d517a3becede5fa106ed896.camel@pengutronix.de> Hi Philipp, The 10/14/2021 13:55, Philipp Zabel wrote: > > On Wed, 2021-10-13 at 09:38 +0200, Horatiu Vultur wrote: > > This adds support for lan966x. > > > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > > --- > > .../devicetree/bindings/reset/microchip,rst.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > index 370579aeeca1..fb170ed2c57a 100644 > > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > > @@ -20,7 +20,11 @@ properties: > > pattern: "^reset-controller@[0-9a-f]+$" > > > > compatible: > > - const: microchip,sparx5-switch-reset > > + oneOf: > > + - items: > > + - const: microchip,sparx5-switch-reset > > + - items: > > + - const: microchip,lan966x-switch-reset > > > > reg: > > items: > > @@ -37,6 +41,14 @@ properties: > > $ref: "/schemas/types.yaml#/definitions/phandle" > > description: syscon used to access CPU reset > > > > + cuphy-syscon: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: syscon used to access CuPHY > > Can this be used on sparx5? No, because the sparx5 doesn't have any internal PHYs that need to be released of the reset. > Is it optional on lan966x? No, it is required on lan966x. I will update the binding to show this. > > > + phy-reset-gpios: > > + description: used for release of reset of the external PHY > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > I'd like somebody to reassure me that putting the CuPHY reset and > external PHY GPIO reset in the reset controller is the right thing to > do. > > It looks fine to me, but I'm not sure if these should rather be in > separate phy nodes that are referenced from the switch. > > regards > Philipp -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-14 15:18 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-13 7:38 [PATCH v3 0/2] Extend Sparx5 switch reset driver for lan966x Horatiu Vultur 2021-10-13 7:38 ` Horatiu Vultur 2021-10-13 7:38 ` [PATCH v3 1/2] dt-bindings: reset: Add lan966x support Horatiu Vultur 2021-10-13 7:38 ` Horatiu Vultur 2021-10-14 11:55 ` Philipp Zabel 2021-10-14 11:55 ` Philipp Zabel 2021-10-14 15:20 ` Horatiu Vultur [this message] 2021-10-14 15:20 ` Horatiu Vultur 2021-10-15 14:14 ` Horatiu Vultur 2021-10-15 14:14 ` Horatiu Vultur 2021-10-18 10:40 ` Philipp Zabel 2021-10-18 10:40 ` Philipp Zabel 2021-10-13 7:38 ` [PATCH v3 2/2] reset: mchp: sparx5: Extend support for lan966x Horatiu Vultur 2021-10-13 7:38 ` Horatiu Vultur 2021-10-14 12:00 ` Philipp Zabel 2021-10-14 12:00 ` Philipp Zabel 2021-10-14 15:40 ` Horatiu Vultur 2021-10-14 15:40 ` Horatiu Vultur 2021-10-18 10:43 ` Philipp Zabel 2021-10-18 10:43 ` Philipp Zabel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost \ --to=horatiu.vultur@microchip.com \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=lars.povlsen@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.