From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: dev@dpdk.org, honnappa.nagarahalli@arm.com, mdr@ashroe.eu,
yipeng1.wang@intel.com, stephen@networkplumber.org
Cc: dharmik.thakkar@arm.com, nd@arm.com
Subject: [dpdk-dev] [PATCH v2] hash: promote APIs to stable
Date: Thu, 14 Oct 2021 21:27:10 -0500 [thread overview]
Message-ID: <20211015022710.13296-1-honnappa.nagarahalli@arm.com> (raw)
Promote APIs to stable.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
---
v2:
1) Removed EXPERIMENTAL warning in comments
2) Promoted all the APIs except rte_thash_*** APIs
lib/hash/rte_hash.h | 17 -----------------
lib/hash/version.map | 10 +++++-----
2 files changed, 5 insertions(+), 22 deletions(-)
diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h
index 73c415ff7e..7cefc4a380 100644
--- a/lib/hash/rte_hash.h
+++ b/lib/hash/rte_hash.h
@@ -205,9 +205,6 @@ int32_t
rte_hash_count(const struct rte_hash *h);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Return the maximum key value ID that could possibly be returned by
* rte_hash_add_key function.
*
@@ -217,7 +214,6 @@ rte_hash_count(const struct rte_hash *h);
* - -EINVAL if parameters are invalid
* - A value indicating the max key ID of key slots present in the table.
*/
-__rte_experimental
int32_t
rte_hash_max_key_id(const struct rte_hash *h);
@@ -430,7 +426,6 @@ rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t position,
* - 0 if freed successfully
* - -EINVAL if the parameters are invalid.
*/
-__rte_experimental
int
rte_hash_free_key_with_position(const struct rte_hash *h,
const int32_t position);
@@ -564,9 +559,6 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
uint32_t num_keys, uint64_t *hit_mask, void *data[]);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Find multiple keys in the hash table with precomputed hash value array.
* This operation is multi-thread safe with regarding to other lookup threads.
* Read-write concurrency can be enabled by setting flag during
@@ -589,15 +581,11 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
* @return
* -EINVAL if there's an error, otherwise 0.
*/
-__rte_experimental
int
rte_hash_lookup_with_hash_bulk(const struct rte_hash *h, const void **keys,
hash_sig_t *sig, uint32_t num_keys, int32_t *positions);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Find multiple keys in the hash table with precomputed hash value array.
* This operation is multi-thread safe with regarding to other lookup threads.
* Read-write concurrency can be enabled by setting flag during
@@ -618,7 +606,6 @@ rte_hash_lookup_with_hash_bulk(const struct rte_hash *h, const void **keys,
* @return
* -EINVAL if there's an error, otherwise number of successful lookups.
*/
-__rte_experimental
int
rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,
const void **keys, hash_sig_t *sig,
@@ -672,9 +659,6 @@ int32_t
rte_hash_iterate(const struct rte_hash *h, const void **key, void **data, uint32_t *next);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Associate RCU QSBR variable with a Hash object.
* This API should be called to enable the integrated RCU QSBR support and
* should be called immediately after creating the Hash object.
@@ -691,7 +675,6 @@ rte_hash_iterate(const struct rte_hash *h, const void **key, void **data, uint32
* - EEXIST - already added QSBR
* - ENOMEM - memory allocation failure
*/
-__rte_experimental
int rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg);
#ifdef __cplusplus
diff --git a/lib/hash/version.map b/lib/hash/version.map
index ce4309aa07..81854701c8 100644
--- a/lib/hash/version.map
+++ b/lib/hash/version.map
@@ -14,6 +14,7 @@ DPDK_22 {
rte_hash_del_key_with_hash;
rte_hash_find_existing;
rte_hash_free;
+ rte_hash_free_key_with_position;
rte_hash_get_key_with_position;
rte_hash_hash;
rte_hash_iterate;
@@ -22,7 +23,11 @@ DPDK_22 {
rte_hash_lookup_bulk_data;
rte_hash_lookup_data;
rte_hash_lookup_with_hash;
+ rte_hash_lookup_with_hash_bulk;
+ rte_hash_lookup_with_hash_bulk_data;
rte_hash_lookup_with_hash_data;
+ rte_hash_max_key_id;
+ rte_hash_rcu_qsbr_add;
rte_hash_reset;
rte_hash_set_cmp_func;
@@ -32,11 +37,6 @@ DPDK_22 {
EXPERIMENTAL {
global:
- rte_hash_free_key_with_position;
- rte_hash_lookup_with_hash_bulk;
- rte_hash_lookup_with_hash_bulk_data;
- rte_hash_max_key_id;
- rte_hash_rcu_qsbr_add;
rte_thash_add_helper;
rte_thash_adjust_tuple;
rte_thash_find_existing;
--
2.25.1
next reply other threads:[~2021-10-15 2:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 2:27 Honnappa Nagarahalli [this message]
2021-10-20 19:23 ` [dpdk-dev] [PATCH v2] hash: promote APIs to stable David Marchand
2021-10-20 19:45 ` Honnappa Nagarahalli
2021-10-20 20:47 ` Wang, Yipeng1
2021-10-21 7:42 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015022710.13296-1-honnappa.nagarahalli@arm.com \
--to=honnappa.nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=mdr@ashroe.eu \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.