All of lore.kernel.org
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>,
	"Wang, Yipeng1" <yipeng1.wang@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>,
	"Gobriel, Sameh" <sameh.gobriel@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] hash: promote APIs to stable
Date: Wed, 20 Oct 2021 19:45:22 +0000	[thread overview]
Message-ID: <DBAPR08MB5814F9523C8D130CCE9A72F698BE9@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zvBL7V6DhsAmu7And79zeDv1FdN60ZzHS+w1YJyf=rxA@mail.gmail.com>

<snip>

> 
> On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli
> <honnappa.nagarahalli@arm.com> wrote:
> >
> > Promote APIs to stable.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > ---
> > v2:
> > 1) Removed EXPERIMENTAL warning in comments
> > 2) Promoted all the APIs except rte_thash_*** APIs
> 
> Yipeng, Vladimir,
> 
> Are we good?
> 
> 
> Honnappa,
> 
> One nit which I can handle when applying, if others are ok with patch.
Thanks. I have no words to explain.

> 
> > @@ -217,7 +214,6 @@ rte_hash_count(const struct rte_hash *h);
> >   *   - -EINVAL if parameters are invalid
> >   *   - A value indicating the max key ID of key slots present in the table.
> >   */
> > -__rte_experimental
> >  int32_t
> >  rte_hash_max_key_id(const struct rte_hash *h);
> >
> > @@ -430,7 +426,6 @@ rte_hash_get_key_with_position(const struct
> rte_hash *h, const int32_t position,
> >   *   - 0 if freed successfully
> >   *   - -EINVAL if the parameters are invalid.
> >   */
> > -__rte_experimental
> >  int
> >  rte_hash_free_key_with_position(const struct rte_hash *h,
> >                                 const int32_t position);
> 
> There is still a @b EXPERIMENTAL banner for this function.
> 
> 
> --
> David Marchand


  reply	other threads:[~2021-10-20 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  2:27 [dpdk-dev] [PATCH v2] hash: promote APIs to stable Honnappa Nagarahalli
2021-10-20 19:23 ` David Marchand
2021-10-20 19:45   ` Honnappa Nagarahalli [this message]
2021-10-20 20:47     ` Wang, Yipeng1
2021-10-21  7:42       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB5814F9523C8D130CCE9A72F698BE9@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Dharmik.Thakkar@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=nd@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.