From: Christian Brauner <christian.brauner@ubuntu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: jmorris@namei.org, linux-security-module@vger.kernel.org,
selinux@vger.kernel.org, serge@hallyn.com,
linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
Miklos Szeredi <miklos@szeredi.hu>,
dwalsh@redhat.com, jlayton@kernel.org, idryomov@gmail.com,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
bfields@fieldses.org, chuck.lever@oracle.com,
anna.schumaker@netapp.com, trond.myklebust@hammerspace.com,
stephen.smalley.work@gmail.com, casey@schaufler-ca.com,
Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH v2] security: Return xattr name from security_dentry_init_security()
Date: Fri, 15 Oct 2021 11:07:18 +0200 [thread overview]
Message-ID: <20211015090718.4xwdnyujw354hnxe@wittgenstein> (raw)
In-Reply-To: <YWWMO/ZDrvDZ5X4c@redhat.com>
On Tue, Oct 12, 2021 at 09:23:07AM -0400, Vivek Goyal wrote:
> Right now security_dentry_init_security() only supports single security
> label and is used by SELinux only. There are two users of of this hook,
> namely ceph and nfs.
>
> NFS does not care about xattr name. Ceph hardcodes the xattr name to
> security.selinux (XATTR_NAME_SELINUX).
>
> I am making changes to fuse/virtiofs to send security label to virtiofsd
> and I need to send xattr name as well. I also hardcoded the name of
> xattr to security.selinux.
>
> Stephen Smalley suggested that it probably is a good idea to modify
> security_dentry_init_security() to also return name of xattr so that
> we can avoid this hardcoding in the callers.
>
> This patch adds a new parameter "const char **xattr_name" to
> security_dentry_init_security() and LSM puts the name of xattr
> too if caller asked for it (xattr_name != NULL).
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> ---
Looks good to me.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
Ondrej Mosnacek <omosnace@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
selinux@vger.kernel.org, stephen.smalley.work@gmail.com,
jlayton@kernel.org, jmorris@namei.org, anna.schumaker@netapp.com,
virtio-fs@redhat.com, casey@schaufler-ca.com,
linux-security-module@vger.kernel.org, chuck.lever@oracle.com,
linux-fsdevel@vger.kernel.org, idryomov@gmail.com,
ceph-devel@vger.kernel.org, trond.myklebust@hammerspace.com,
serge@hallyn.com
Subject: Re: [Virtio-fs] [PATCH v2] security: Return xattr name from security_dentry_init_security()
Date: Fri, 15 Oct 2021 11:07:18 +0200 [thread overview]
Message-ID: <20211015090718.4xwdnyujw354hnxe@wittgenstein> (raw)
In-Reply-To: <YWWMO/ZDrvDZ5X4c@redhat.com>
On Tue, Oct 12, 2021 at 09:23:07AM -0400, Vivek Goyal wrote:
> Right now security_dentry_init_security() only supports single security
> label and is used by SELinux only. There are two users of of this hook,
> namely ceph and nfs.
>
> NFS does not care about xattr name. Ceph hardcodes the xattr name to
> security.selinux (XATTR_NAME_SELINUX).
>
> I am making changes to fuse/virtiofs to send security label to virtiofsd
> and I need to send xattr name as well. I also hardcoded the name of
> xattr to security.selinux.
>
> Stephen Smalley suggested that it probably is a good idea to modify
> security_dentry_init_security() to also return name of xattr so that
> we can avoid this hardcoding in the callers.
>
> This patch adds a new parameter "const char **xattr_name" to
> security_dentry_init_security() and LSM puts the name of xattr
> too if caller asked for it (xattr_name != NULL).
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> ---
Looks good to me.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-10-15 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 13:23 [PATCH v2] security: Return xattr name from security_dentry_init_security() Vivek Goyal
2021-10-12 13:23 ` [Virtio-fs] " Vivek Goyal
2021-10-15 9:07 ` Christian Brauner [this message]
2021-10-15 9:07 ` Christian Brauner
2021-10-18 12:35 ` Vivek Goyal
2021-10-18 12:35 ` [Virtio-fs] " Vivek Goyal
2021-10-19 20:52 ` James Morris
2021-10-19 20:52 ` [Virtio-fs] " James Morris
2021-10-19 23:49 ` Paul Moore
2021-10-19 23:49 ` [Virtio-fs] " Paul Moore
2021-10-20 12:24 ` Paul Moore
2021-10-20 12:24 ` [Virtio-fs] " Paul Moore
2021-10-20 12:31 ` Vivek Goyal
2021-10-20 12:31 ` [Virtio-fs] " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015090718.4xwdnyujw354hnxe@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dwalsh@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.