From: Frieder Schrempf <frieder@fris.de> To: devicetree@vger.kernel.org, Frieder Schrempf <frieder.schrempf@kontron.de>, Krzysztof Kozlowski <krzk@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org> Cc: stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: [PATCH v2 5/6] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Date: Fri, 15 Oct 2021 14:48:39 +0200 [thread overview] Message-ID: <20211015124841.28226-6-frieder@fris.de> (raw) In-Reply-To: <20211015124841.28226-1-frieder@fris.de> From: Frieder Schrempf <frieder.schrempf@kontron.de> The MCP2515 can be used with an SPI clock of up to 10 MHz. Set the limit accordingly to prevent any performance issues caused by the really low clock speed of 100 kHz. This removes the arbitrarily low limit on the SPI frequency, that was caused by a typo in the original dts. Without this change, receiving CAN messages on the board beyond a certain bitrate will cause overrun errors (see 'ip -det -stat link show can0'). With this fix, receiving messages on the bus works without any overrun errors for bitrates up to 1 MBit. Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Cc: stable@vger.kernel.org Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> --- Changes in v2: * Fix the commit ref in the Fixes tag * Improve commit message --- arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts index a192a047f264..14263cd40daf 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts @@ -97,7 +97,7 @@ can0: can@0 { clocks = <&osc_can>; interrupt-parent = <&gpio4>; interrupts = <28 IRQ_TYPE_EDGE_FALLING>; - spi-max-frequency = <100000>; + spi-max-frequency = <10000000>; vdd-supply = <®_vdd_3v3>; xceiver-supply = <®_vdd_5v>; }; -- 2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder@fris.de> To: devicetree@vger.kernel.org, Frieder Schrempf <frieder.schrempf@kontron.de>, Krzysztof Kozlowski <krzk@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org> Cc: stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: [PATCH v2 5/6] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Date: Fri, 15 Oct 2021 14:48:39 +0200 [thread overview] Message-ID: <20211015124841.28226-6-frieder@fris.de> (raw) In-Reply-To: <20211015124841.28226-1-frieder@fris.de> From: Frieder Schrempf <frieder.schrempf@kontron.de> The MCP2515 can be used with an SPI clock of up to 10 MHz. Set the limit accordingly to prevent any performance issues caused by the really low clock speed of 100 kHz. This removes the arbitrarily low limit on the SPI frequency, that was caused by a typo in the original dts. Without this change, receiving CAN messages on the board beyond a certain bitrate will cause overrun errors (see 'ip -det -stat link show can0'). With this fix, receiving messages on the bus works without any overrun errors for bitrates up to 1 MBit. Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Cc: stable@vger.kernel.org Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> --- Changes in v2: * Fix the commit ref in the Fixes tag * Improve commit message --- arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts index a192a047f264..14263cd40daf 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts @@ -97,7 +97,7 @@ can0: can@0 { clocks = <&osc_can>; interrupt-parent = <&gpio4>; interrupts = <28 IRQ_TYPE_EDGE_FALLING>; - spi-max-frequency = <100000>; + spi-max-frequency = <10000000>; vdd-supply = <®_vdd_3v3>; xceiver-supply = <®_vdd_5v>; }; -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-15 12:49 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-15 12:48 [PATCH v2 0/6] Devicetree fixes and additions for Kontron SL/BL i.MX8MM boards Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-15 12:48 ` [PATCH v2 1/6] arm64: dts: imx8mm-kontron: Add support for ultra high speed modes on SD card Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-15 12:48 ` [PATCH v2 2/6] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-15 12:48 ` [PATCH v2 3/6] arm64: dts: imx8mm-kontron: Set lower limit of VDD_SNVS to 800 mV Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-15 12:48 ` [PATCH v2 4/6] arm64: dts: imx8mm-kontron: Fix polarity of reg_rst_eth2 Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf [this message] 2021-10-15 12:48 ` [PATCH v2 5/6] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Frieder Schrempf 2021-10-15 12:48 ` [PATCH v2 6/6] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Frieder Schrempf 2021-10-15 12:48 ` Frieder Schrempf 2021-10-16 7:50 ` [PATCH v2 0/6] Devicetree fixes and additions for Kontron SL/BL i.MX8MM boards Shawn Guo 2021-10-16 7:50 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211015124841.28226-6-frieder@fris.de \ --to=frieder@fris.de \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.