* [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config
@ 2021-10-15 15:00 Sudeep Holla
2021-10-15 15:21 ` Cristian Marussi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sudeep Holla @ 2021-10-15 15:00 UTC (permalink / raw)
To: linux-clk
Cc: Sudeep Holla, Cristian Marussi, Etienne Carriere,
Gabriel Fernandez, Stephen Boyd
Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
used anywhere.
Further, it looks like this Kconfig option is just to select bunch of other
options which doesn't sound correct to me. There is no need for another
SCMI firmware based clock driver and hence the same applies for the config
option too.
Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
someone idea to write a specific clock driver for this SoC/platform.
Cc: Etienne Carriere <etienne.carriere@foss.st.com>
Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/clk/Kconfig | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index c5b3dc97396a..b64058d1af2d 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -339,16 +339,6 @@ config COMMON_CLK_STM32MP157
help
Support for stm32mp157 SoC family clocks
-config COMMON_CLK_STM32MP157_SCMI
- bool "stm32mp157 Clock driver with Trusted Firmware"
- depends on COMMON_CLK_STM32MP157
- select COMMON_CLK_SCMI
- select ARM_SCMI_PROTOCOL
- default y
- help
- Support for stm32mp157 SoC family clocks with Trusted Firmware using
- SCMI protocol.
-
config COMMON_CLK_STM32F
def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
help
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config
2021-10-15 15:00 [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config Sudeep Holla
@ 2021-10-15 15:21 ` Cristian Marussi
2021-10-15 16:26 ` Sudeep Holla
2021-12-01 15:51 ` Sudeep Holla
2022-01-06 1:23 ` Stephen Boyd
2 siblings, 1 reply; 5+ messages in thread
From: Cristian Marussi @ 2021-10-15 15:21 UTC (permalink / raw)
To: Sudeep Holla; +Cc: linux-clk, Etienne Carriere, Gabriel Fernandez, Stephen Boyd
On Fri, Oct 15, 2021 at 04:00:43PM +0100, Sudeep Holla wrote:
> Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
> introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
> used anywhere.
>
> Further, it looks like this Kconfig option is just to select bunch of other
> options which doesn't sound correct to me. There is no need for another
> SCMI firmware based clock driver and hence the same applies for the config
> option too.
>
> Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
> someone idea to write a specific clock driver for this SoC/platform.
>
> Cc: Etienne Carriere <etienne.carriere@foss.st.com>
> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Looking at the original commit, and guessing its original aim,
is it not better to put some sort of WARN in the STM32MP157 driver
when the specific "rcc-secure" compatible is found configured BUT
!IS_ENABLED(COMMON_CLK_SCMI) ?
Thanks,
Cristian
> drivers/clk/Kconfig | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c5b3dc97396a..b64058d1af2d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -339,16 +339,6 @@ config COMMON_CLK_STM32MP157
> help
> Support for stm32mp157 SoC family clocks
>
> -config COMMON_CLK_STM32MP157_SCMI
> - bool "stm32mp157 Clock driver with Trusted Firmware"
> - depends on COMMON_CLK_STM32MP157
> - select COMMON_CLK_SCMI
> - select ARM_SCMI_PROTOCOL
> - default y
> - help
> - Support for stm32mp157 SoC family clocks with Trusted Firmware using
> - SCMI protocol.
> -
> config COMMON_CLK_STM32F
> def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
> help
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config
2021-10-15 15:21 ` Cristian Marussi
@ 2021-10-15 16:26 ` Sudeep Holla
0 siblings, 0 replies; 5+ messages in thread
From: Sudeep Holla @ 2021-10-15 16:26 UTC (permalink / raw)
To: Cristian Marussi
Cc: linux-clk, Etienne Carriere, Sudeep Holla, Gabriel Fernandez,
Stephen Boyd
On Fri, Oct 15, 2021 at 04:21:47PM +0100, Cristian Marussi wrote:
> On Fri, Oct 15, 2021 at 04:00:43PM +0100, Sudeep Holla wrote:
> > Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
> > introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
> > used anywhere.
> >
> > Further, it looks like this Kconfig option is just to select bunch of other
> > options which doesn't sound correct to me. There is no need for another
> > SCMI firmware based clock driver and hence the same applies for the config
> > option too.
> >
> > Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
> > someone idea to write a specific clock driver for this SoC/platform.
> >
> > Cc: Etienne Carriere <etienne.carriere@foss.st.com>
> > Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
>
> LGTM.
>
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>
Thanks.
> Looking at the original commit, and guessing its original aim,
> is it not better to put some sort of WARN in the STM32MP157 driver
> when the specific "rcc-secure" compatible is found configured BUT
> !IS_ENABLED(COMMON_CLK_SCMI) ?
>
IMO, that makes sense. I will leave that to Etienne/Gabriel to decide.
> Thanks,
> Cristian
>
> > drivers/clk/Kconfig | 10 ----------
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index c5b3dc97396a..b64058d1af2d 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -339,16 +339,6 @@ config COMMON_CLK_STM32MP157
> > help
> > Support for stm32mp157 SoC family clocks
> >
> > -config COMMON_CLK_STM32MP157_SCMI
> > - bool "stm32mp157 Clock driver with Trusted Firmware"
> > - depends on COMMON_CLK_STM32MP157
> > - select COMMON_CLK_SCMI
> > - select ARM_SCMI_PROTOCOL
> > - default y
> > - help
> > - Support for stm32mp157 SoC family clocks with Trusted Firmware using
> > - SCMI protocol.
> > -
> > config COMMON_CLK_STM32F
> > def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
> > help
> > --
> > 2.25.1
> >
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config
2021-10-15 15:00 [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config Sudeep Holla
2021-10-15 15:21 ` Cristian Marussi
@ 2021-12-01 15:51 ` Sudeep Holla
2022-01-06 1:23 ` Stephen Boyd
2 siblings, 0 replies; 5+ messages in thread
From: Sudeep Holla @ 2021-12-01 15:51 UTC (permalink / raw)
To: linux-clk, Etienne Carriere, Stephen Boyd
Cc: Cristian Marussi, Gabriel Fernandez, Sudeep Holla
Hi Etienne,
On Fri, Oct 15, 2021 at 04:00:43PM +0100, Sudeep Holla wrote:
> Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
> introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
> used anywhere.
>
> Further, it looks like this Kconfig option is just to select bunch of other
> options which doesn't sound correct to me. There is no need for another
> SCMI firmware based clock driver and hence the same applies for the config
> option too.
>
> Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
> someone idea to write a specific clock driver for this SoC/platform.
>
Any thoughts ? I don't see any reason we need this Kconfig especially
with no users.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config
2021-10-15 15:00 [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config Sudeep Holla
2021-10-15 15:21 ` Cristian Marussi
2021-12-01 15:51 ` Sudeep Holla
@ 2022-01-06 1:23 ` Stephen Boyd
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2022-01-06 1:23 UTC (permalink / raw)
To: Sudeep Holla, linux-clk
Cc: Sudeep Holla, Cristian Marussi, Etienne Carriere, Gabriel Fernandez
Quoting Sudeep Holla (2021-10-15 08:00:43)
> Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support")
> introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not
> used anywhere.
>
> Further, it looks like this Kconfig option is just to select bunch of other
> options which doesn't sound correct to me. There is no need for another
> SCMI firmware based clock driver and hence the same applies for the config
> option too.
>
> Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives
> someone idea to write a specific clock driver for this SoC/platform.
>
> Cc: Etienne Carriere <etienne.carriere@foss.st.com>
> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
Applied to clk-next
I got tired of waiting
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-06 1:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 15:00 [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config Sudeep Holla
2021-10-15 15:21 ` Cristian Marussi
2021-10-15 16:26 ` Sudeep Holla
2021-12-01 15:51 ` Sudeep Holla
2022-01-06 1:23 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.