All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64
@ 2021-10-15 18:31 Fabrice Fontaine
  2021-10-15 19:52 ` Kieran Bingham
  2021-10-16  7:24 ` Yann E. MORIN
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-10-15 18:31 UTC (permalink / raw)
  To: buildroot; +Cc: Kieran Bingham, Fabrice Fontaine

Add a dependency on arm or aarch64 for
BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI to avoid the following build
failure with one powerpc64 toolchain since commit
c09f126f570355b8ec134724b453300a4811339c
as suggested by upstream in
https://lists.libcamera.org/pipermail/libcamera-devel/2021-October/025796.html:

In file included from ../include/libcamera/base/log.h:10,
                 from ../src/ipa/raspberrypi/raspberrypi.cpp:18:
../src/ipa/raspberrypi/raspberrypi.cpp:64:53:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 3.0e+1)'
/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 3.0e+1)' is not a constant expression
  502 |  return __cd(__cd(__d).count() / __s);
../src/ipa/raspberrypi/raspberrypi.cpp:73:56:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 6.0e+1)'
/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 6.0e+1)' is not a constant expression

Fixes:
 - http://autobuild.buildroot.org/results/49caebe7ef7e3d63de49e78d5d6839dd0aedf10c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libcamera/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index 92c17df849..c510e34924 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -40,6 +40,7 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
 
 config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
 	bool "raspberrypi pipeline"
+	depends on BR2_arm || BR2_aarch64
 	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64
  2021-10-15 18:31 [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64 Fabrice Fontaine
@ 2021-10-15 19:52 ` Kieran Bingham
  2021-10-16  7:24 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-10-15 19:52 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Fabrice Fontaine

Quoting Fabrice Fontaine (2021-10-15 19:31:13)
> Add a dependency on arm or aarch64 for
> BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI to avoid the following build
> failure with one powerpc64 toolchain since commit
> c09f126f570355b8ec134724b453300a4811339c
> as suggested by upstream in
> https://lists.libcamera.org/pipermail/libcamera-devel/2021-October/025796.html:
> 
> In file included from ../include/libcamera/base/log.h:10,
>                  from ../src/ipa/raspberrypi/raspberrypi.cpp:18:
> ../src/ipa/raspberrypi/raspberrypi.cpp:64:53:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 3.0e+1)'
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 3.0e+1)' is not a constant expression
>   502 |  return __cd(__cd(__d).count() / __s);
> ../src/ipa/raspberrypi/raspberrypi.cpp:73:56:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 6.0e+1)'
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 6.0e+1)' is not a constant expression
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/49caebe7ef7e3d63de49e78d5d6839dd0aedf10c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libcamera/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index 92c17df849..c510e34924 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -40,6 +40,7 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
>  
>  config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
>         bool "raspberrypi pipeline"
> +       depends on BR2_arm || BR2_aarch64

Yes, I think filtering the pipeline handlers is reasonable in this way.

I'd go further and filter the IPU3 on only x86 for instance, and the
RKISP on (arm||aarch64).

But that could be separate patches too.


>         depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
>         select BR2_PACKAGE_BOOST
>         select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
> -- 
> 2.33.0
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64
  2021-10-15 18:31 [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64 Fabrice Fontaine
  2021-10-15 19:52 ` Kieran Bingham
@ 2021-10-16  7:24 ` Yann E. MORIN
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-10-16  7:24 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Kieran Bingham, buildroot

Fabrice, All,

On 2021-10-15 20:31 +0200, Fabrice Fontaine spake thusly:
> Add a dependency on arm or aarch64 for
> BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI to avoid the following build
> failure with one powerpc64 toolchain since commit
> c09f126f570355b8ec134724b453300a4811339c
> as suggested by upstream in
> https://lists.libcamera.org/pipermail/libcamera-devel/2021-October/025796.html:
> 
> In file included from ../include/libcamera/base/log.h:10,
>                  from ../src/ipa/raspberrypi/raspberrypi.cpp:18:
> ../src/ipa/raspberrypi/raspberrypi.cpp:64:53:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 3.0e+1)'
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 3.0e+1)' is not a constant expression
>   502 |  return __cd(__cd(__d).count() / __s);
> ../src/ipa/raspberrypi/raspberrypi.cpp:73:56:   in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 6.0e+1)'
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 6.0e+1)' is not a constant expression
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/49caebe7ef7e3d63de49e78d5d6839dd0aedf10c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, after adding simialr depepndencies to IPU3 and
RKISP1, as suggested by Kieran. Thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcamera/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index 92c17df849..c510e34924 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -40,6 +40,7 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3
>  
>  config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
>  	bool "raspberrypi pipeline"
> +	depends on BR2_arm || BR2_aarch64
>  	depends on BR2_USE_WCHAR # boost (already enforced for gnutls)
>  	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-16  7:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 18:31 [Buildroot] [PATCH 1/1] package/libcamera: raspberrypi depends on arm or aarch64 Fabrice Fontaine
2021-10-15 19:52 ` Kieran Bingham
2021-10-16  7:24 ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.