* [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency
@ 2021-10-13 16:24 Yann E. MORIN
2021-10-13 16:33 ` Herve Codina
2021-10-16 7:36 ` Yann E. MORIN
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-10-13 16:24 UTC (permalink / raw)
To: buildroot; +Cc: Herve Codina, Yann E. MORIN, Fabrice Fontaine
Commit b00b9c865d21 (package/dtbocfg: depends on kernel) forgot to add a
comment when the kernel is not enabled.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Herve Codina <herve.codina@bootlin.com>
---
package/dtbocfg/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in
index 862dc0ccc5..2b2a8538a3 100644
--- a/package/dtbocfg/Config.in
+++ b/package/dtbocfg/Config.in
@@ -7,3 +7,6 @@ config BR2_PACKAGE_DTBOCFG
as a userspace API of Device Tree Overlay.
https://github.com/ikwzm/dtbocfg
+
+comment "dtbocfg needs a kernel to be built"
+ depends on !BR2_LINUX_KERNEL
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency
2021-10-13 16:24 [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency Yann E. MORIN
@ 2021-10-13 16:33 ` Herve Codina
2021-10-16 7:36 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Herve Codina @ 2021-10-13 16:33 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Fabrice Fontaine, buildroot
Hi Yann, Fabrice,
On Wed, 13 Oct 2021 18:24:10 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Commit b00b9c865d21 (package/dtbocfg: depends on kernel) forgot to add a
> comment when the kernel is not enabled.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Cc: Herve Codina <herve.codina@bootlin.com>
> ---
> package/dtbocfg/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in
> index 862dc0ccc5..2b2a8538a3 100644
> --- a/package/dtbocfg/Config.in
> +++ b/package/dtbocfg/Config.in
> @@ -7,3 +7,6 @@ config BR2_PACKAGE_DTBOCFG
> as a userspace API of Device Tree Overlay.
>
> https://github.com/ikwzm/dtbocfg
> +
> +comment "dtbocfg needs a kernel to be built"
> + depends on !BR2_LINUX_KERNEL
I think the right sentence is "dtbocfg needs a Linux kernel to be built"
(ie s/a kernel/a Linux kernel/)
Best regards,
Herve
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency
2021-10-13 16:24 [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency Yann E. MORIN
2021-10-13 16:33 ` Herve Codina
@ 2021-10-16 7:36 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-10-16 7:36 UTC (permalink / raw)
To: buildroot; +Cc: Herve Codina, Fabrice Fontaine
All,
On 2021-10-13 18:24 +0200, Yann E. MORIN spake thusly:
> Commit b00b9c865d21 (package/dtbocfg: depends on kernel) forgot to add a
> comment when the kernel is not enabled.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Cc: Herve Codina <herve.codina@bootlin.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/dtbocfg/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in
> index 862dc0ccc5..2b2a8538a3 100644
> --- a/package/dtbocfg/Config.in
> +++ b/package/dtbocfg/Config.in
> @@ -7,3 +7,6 @@ config BR2_PACKAGE_DTBOCFG
> as a userspace API of Device Tree Overlay.
>
> https://github.com/ikwzm/dtbocfg
> +
> +comment "dtbocfg needs a kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> --
> 2.25.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-16 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 16:24 [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency Yann E. MORIN
2021-10-13 16:33 ` Herve Codina
2021-10-16 7:36 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.