From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 1/2] can: peak_usb: always ask for BERR reporting for PCAN-USB devices
Date: Sun, 17 Oct 2021 22:50:18 +0200 [thread overview]
Message-ID: <20211017205018.4dngil53gtdsphm4@pengutronix.de> (raw)
In-Reply-To: <20210929141421.55580-1-s.grosjean@peak-system.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On 29.09.2021 16:14:20, Stephane Grosjean wrote:
> Since for the PCAN-USB, the management of the transition to the
> ERROR_WARNING or ERROR_PASSIVE state is done according to the error
> counters, these must be requested unconditionally.
If you switch on bus error reporting unconditionally, please remove
CAN_CTRLMODE_BERR_REPORTING from ctrlmode_supported.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-10-17 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 14:14 [PATCH 1/2] can: peak_usb: always ask for BERR reporting for PCAN-USB devices Stephane Grosjean
2021-09-29 14:14 ` [PATCH 2/2] can: peak_usb: exchange the order of information messages Stephane Grosjean
2021-10-17 20:50 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017205018.4dngil53gtdsphm4@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.