* [PATCH v2] driver: bdisp: add pm_runtime_disable in the error handling code
@ 2021-10-19 3:08 Dongliang Mu
0 siblings, 0 replies; only message in thread
From: Dongliang Mu @ 2021-10-19 3:08 UTC (permalink / raw)
To: Fabien Dessenne, Mauro Carvalho Chehab
Cc: Dongliang Mu, linux-media, linux-kernel
In the error handling code of bdisp_probe, it fails to invoke
pm_runtime_disable in many error sites.
Fix this by adding pm_runtime_disable at the label err_remove.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
v1->v2: move pm_runtime_disable from the end of label err_pm to
the beginning of err_remove
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
index 6413cd279125..01cc8b577ad4 100644
--- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
@@ -1395,6 +1395,7 @@ static int bdisp_probe(struct platform_device *pdev)
err_pm:
pm_runtime_put(dev);
err_remove:
+ pm_runtime_disable(dev);
bdisp_debugfs_remove(bdisp);
v4l2_device_unregister(&bdisp->v4l2_dev);
err_clk:
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-19 3:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 3:08 [PATCH v2] driver: bdisp: add pm_runtime_disable in the error handling code Dongliang Mu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.