All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default
@ 2021-10-19  9:00 Meng Li
  2021-10-19 14:42 ` Kieran Bingham
  0 siblings, 1 reply; 2+ messages in thread
From: Meng Li @ 2021-10-19  9:00 UTC (permalink / raw)
  To: geert+renesas, magnus.damm, robh+dt
  Cc: linux-renesas-soc, devicetree, linux-kernel, meng.li

The gpio5-pin9 is used as the interrupt pin of i2c external
gpio chip, so set this pin as input by default.

Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 202177706cde..8986a7e6e099 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -205,6 +205,15 @@
 	};
 };
 
+&gpio5 {
+	gpio_exp_77_int {
+		gpio-hog;
+		gpios = <9 0>;
+		input;
+		line-name = "gpio-exp-77-int";
+	};
+};
+
 &i2c4 {
 	i2cswitch4: i2c-switch@71 {
 		compatible = "nxp,pca9548";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default
  2021-10-19  9:00 [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default Meng Li
@ 2021-10-19 14:42 ` Kieran Bingham
  0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2021-10-19 14:42 UTC (permalink / raw)
  To: Meng Li, geert+renesas, magnus.damm, robh+dt
  Cc: linux-renesas-soc, devicetree, linux-kernel, meng.li

Quoting Meng Li (2021-10-19 10:00:20)
> The gpio5-pin9 is used as the interrupt pin of i2c external
> gpio chip, so set this pin as input by default.

Is a GPIO hog the right way to do this?
Shouldn't the other GPIO chip be modelled in DT and reference the gpio
interrupt line from there in its interrupt property?

I assume by 'external gpio chip' you mean one which is permanantly
attached to the ULCB Kingfisher board, and not a custom addition?

--
Regards
Kieran

> 
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 202177706cde..8986a7e6e099 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -205,6 +205,15 @@
>         };
>  };
>  
> +&gpio5 {
> +       gpio_exp_77_int {
> +               gpio-hog;
> +               gpios = <9 0>;
> +               input;
> +               line-name = "gpio-exp-77-int";
> +       };
> +};
> +
>  &i2c4 {
>         i2cswitch4: i2c-switch@71 {
>                 compatible = "nxp,pca9548";
> -- 
> 2.17.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-19 14:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19  9:00 [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default Meng Li
2021-10-19 14:42 ` Kieran Bingham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.