All of lore.kernel.org
 help / color / mirror / Atom feed
From: <luo.penghao@zte.com.cn>
To: <ville.syrjala@linux.intel.com>
Cc: <cgel.zte@gmail.com>, <jani.nikula@linux.intel.com>,
	<joonas.lahtinen@linux.intel.com>, <rodrigo.vivi@intel.com>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <sfr@canb.auug.org.au>,
	<intel-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<zealci@zte.com.cn>
Subject: Re:[PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.
Date: Tue, 19 Oct 2021 10:22:09 +0800 (CST)	[thread overview]
Message-ID: <202110191022090370609@zte.com.cn> (raw)
In-Reply-To: <YW024pwrV7fLgV/2@intel.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 963 bytes --]

> This one we could use. For some reason we hardcode it to



> 1 now, which is correct for our use cases but I don't really> see a reason to hardcode it here. We are supposed to calculate> it correctly after all, and chv_crtc_clock_get() also just blindly> reads it out.> > >      bestm2_frac = crtc_state->dpll.m2 & 0x3fffff;> > -    bestm1 = crtc_state->dpll.m1;> > This one is a bit trickier since I don't think the spec even> gives us other values. But we could assert that it's correct.> > Some something along these lines I think would be best:> + drm_WARN_ON(&dev_priv->drm, bestm1 != 2);>   vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW1(port),>                  DPIO_CHV_M1_DIV_BY_2 |> -          1 << DPIO_CHV_N_DIV_SHIFT);> +          bestn << DPIO_CHV_N_DIV_SHIFT);






Thanks for your kind response ! Does that means the variable will be


used by the hardware？if so as far as I see it, I don't seem to see the


relevant interface.

[-- Attachment #1.1.2: Type: text/html , Size: 2778 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: <luo.penghao@zte.com.cn>
To: <ville.syrjala@linux.intel.com>
Cc: <cgel.zte@gmail.com>, <jani.nikula@linux.intel.com>,
	<joonas.lahtinen@linux.intel.com>, <rodrigo.vivi@intel.com>,
	<airlied@linux.ie>, <daniel@ffwll.ch>, <sfr@canb.auug.org.au>,
	<intel-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<zealci@zte.com.cn>
Subject: Re: [Intel-gfx]  [PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.
Date: Tue, 19 Oct 2021 10:22:09 +0800 (CST)	[thread overview]
Message-ID: <202110191022090370609@zte.com.cn> (raw)
In-Reply-To: <YW024pwrV7fLgV/2@intel.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 963 bytes --]

> This one we could use. For some reason we hardcode it to



> 1 now, which is correct for our use cases but I don't really> see a reason to hardcode it here. We are supposed to calculate> it correctly after all, and chv_crtc_clock_get() also just blindly> reads it out.> > >      bestm2_frac = crtc_state->dpll.m2 & 0x3fffff;> > -    bestm1 = crtc_state->dpll.m1;> > This one is a bit trickier since I don't think the spec even> gives us other values. But we could assert that it's correct.> > Some something along these lines I think would be best:> + drm_WARN_ON(&dev_priv->drm, bestm1 != 2);>   vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW1(port),>                  DPIO_CHV_M1_DIV_BY_2 |> -          1 << DPIO_CHV_N_DIV_SHIFT);> +          bestn << DPIO_CHV_N_DIV_SHIFT);






Thanks for your kind response ! Does that means the variable will be


used by the hardware？if so as far as I see it, I don't seem to see the


relevant interface.

[-- Attachment #1.1.2: Type: text/html , Size: 2778 bytes --]

  reply	other threads:[~2021-10-19  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18  8:43 [PATCH linux-next] drm/i915/display: Remove unused variable and its assignment luo penghao
2021-10-18  8:43 ` [Intel-gfx] " luo penghao
2021-10-18  8:57 ` Ville Syrjälä
2021-10-18  8:57   ` [Intel-gfx] " Ville Syrjälä
2021-10-19  2:22   ` luo.penghao [this message]
2021-10-19  2:22     ` luo.penghao
2021-10-18 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-10-18 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-18 23:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-19  2:23 Re:[PATCH linux-next] " luo.penghao
2021-10-19  2:24 luo.penghao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110191022090370609@zte.com.cn \
    --to=luo.penghao@zte.com.cn \
    --cc=airlied@linux.ie \
    --cc=cgel.zte@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=ville.syrjala@linux.intel.com \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.