All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] qcom: spm: allow compile-testing
@ 2021-10-19 15:42 Arnd Bergmann
  2021-10-19 15:42 ` [PATCH 2/3] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency Arnd Bergmann
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-10-19 15:42 UTC (permalink / raw)
  To: linux-pm
  Cc: soc, Daniel Lezcano, Rafael J . Wysocki, linux-arm-msm,
	Bjorn Andersson, Arnd Bergmann, Andy Gross, Lina Iyer,
	John Stultz, Maulik Shah, Stephen Boyd,
	AngeloGioacchino Del Regno, Srinivas Kandagatla,
	Mahesh Sivasubramanian, Ulf Hansson, Stephan Gerhold,
	Rafael J. Wysocki, He Ying, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

ARM_QCOM_SPM_CPUIDLE can be selected when compile-testing on
other architectures, but this causes a Kconfig warning
for QCOM_SPM:

WARNING: unmet direct dependencies detected for QCOM_SPM
  Depends on [n]: ARCH_QCOM [=n]
  Selected by [y]:
  - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]

Make it possible to also compile-test this one, which can
be done now that v5.15-rc5 lets you select QCOM_SCM everywhere.

Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
Fixes: 498ba2a8a275 ("cpuidle: Fix ARM_QCOM_SPM_CPUIDLE configuration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Bjorn, if you think this is the right solution, let me know and I can
apply it on top of the drivers branch that I have already pulled
into the soc tree.

Alternatively, this could go through the cpuidle tree, along with
the other two patches.
---
 drivers/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 3cf3a6b41182..e718b8735444 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -192,7 +192,7 @@ config QCOM_SOCINFO
 
 config QCOM_SPM
 	tristate "Qualcomm Subsystem Power Manager (SPM)"
-	depends on ARCH_QCOM
+	depends on ARCH_QCOM || COMPILE_TEST
 	select QCOM_SCM
 	help
 	  Enable the support for the Qualcomm Subsystem Power Manager, used
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency
  2021-10-19 15:42 [PATCH 1/3] qcom: spm: allow compile-testing Arnd Bergmann
@ 2021-10-19 15:42 ` Arnd Bergmann
  2021-10-19 15:42 ` [PATCH 3/3] cpuidle: qcom: " Arnd Bergmann
  2021-10-20  4:24 ` [PATCH 1/3] qcom: spm: allow compile-testing Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-10-19 15:42 UTC (permalink / raw)
  To: linux-pm, Rafael J. Wysocki, Daniel Lezcano
  Cc: soc, linux-arm-msm, Bjorn Andersson, Arnd Bergmann,
	Dmitry Osipenko, Stephan Gerhold, He Ying,
	AngeloGioacchino Del Regno, Thierry Reding, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Some StrongARM processors don't support suspend, which leads
to a build failure with the tegra cpuidle driver:

WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
  Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
  Selected by [y]:
  - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]

arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference to `cpu_sa110_suspend_size'

Add an explicit dependency to make randconfig builds avoid
this combination.

Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/cpuidle/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 15d6c46c0a47..74df12e23546 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE
 config ARM_TEGRA_CPUIDLE
 	bool "CPU Idle Driver for NVIDIA Tegra SoCs"
 	depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
+	depends on ARCH_SUSPEND_POSSIBLE
 	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
 	select ARM_CPU_SUSPEND
 	help
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] cpuidle: qcom: add ARCH_SUSPEND_POSSIBLE dependency
  2021-10-19 15:42 [PATCH 1/3] qcom: spm: allow compile-testing Arnd Bergmann
  2021-10-19 15:42 ` [PATCH 2/3] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency Arnd Bergmann
@ 2021-10-19 15:42 ` Arnd Bergmann
  2021-10-20  4:24 ` [PATCH 1/3] qcom: spm: allow compile-testing Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-10-19 15:42 UTC (permalink / raw)
  To: linux-pm, Rafael J. Wysocki, Daniel Lezcano
  Cc: soc, linux-arm-msm, Bjorn Andersson, Arnd Bergmann,
	Dmitry Osipenko, Thierry Reding, He Ying,
	AngeloGioacchino Del Regno, Ulf Hansson, Lina Iyer,
	Stephan Gerhold, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Some StrongARM processors don't support suspend, which leads
to a build failure with the tegra cpuidle driver:

WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
  Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
  Selected by [y]:
  - ARM_QCOM_SPM_CPUIDLE [=y] && ...

arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference to `cpu_sa110_suspend_size'

Add an explicit dependency to make randconfig builds avoid
this combination.

Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/cpuidle/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 74df12e23546..1b4f5ae1ee05 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -109,6 +109,7 @@ config ARM_TEGRA_CPUIDLE
 config ARM_QCOM_SPM_CPUIDLE
 	bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
 	depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
+	depends on ARCH_SUSPEND_POSSIBLE
 	select ARM_CPU_SUSPEND
 	select CPU_IDLE_MULTIPLE_DRIVERS
 	select DT_IDLE_STATES
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] qcom: spm: allow compile-testing
  2021-10-19 15:42 [PATCH 1/3] qcom: spm: allow compile-testing Arnd Bergmann
  2021-10-19 15:42 ` [PATCH 2/3] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency Arnd Bergmann
  2021-10-19 15:42 ` [PATCH 3/3] cpuidle: qcom: " Arnd Bergmann
@ 2021-10-20  4:24 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-10-20  4:24 UTC (permalink / raw)
  To: Arnd Bergmann, linux-pm
  Cc: soc, Daniel Lezcano, Rafael J . Wysocki, linux-arm-msm,
	Bjorn Andersson, Arnd Bergmann, Andy Gross, Lina Iyer,
	John Stultz, Maulik Shah, AngeloGioacchino Del Regno,
	Srinivas Kandagatla, Mahesh Sivasubramanian, Ulf Hansson,
	Stephan Gerhold, Rafael J. Wysocki, He Ying, linux-kernel

Quoting Arnd Bergmann (2021-10-19 08:42:02)
> From: Arnd Bergmann <arnd@arndb.de>
>
> ARM_QCOM_SPM_CPUIDLE can be selected when compile-testing on
> other architectures, but this causes a Kconfig warning
> for QCOM_SPM:
>
> WARNING: unmet direct dependencies detected for QCOM_SPM
>   Depends on [n]: ARCH_QCOM [=n]
>   Selected by [y]:
>   - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> Make it possible to also compile-test this one, which can
> be done now that v5.15-rc5 lets you select QCOM_SCM everywhere.
>
> Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
> Fixes: 498ba2a8a275 ("cpuidle: Fix ARM_QCOM_SPM_CPUIDLE configuration")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-20  4:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 15:42 [PATCH 1/3] qcom: spm: allow compile-testing Arnd Bergmann
2021-10-19 15:42 ` [PATCH 2/3] cpuidle: tegra: add ARCH_SUSPEND_POSSIBLE dependency Arnd Bergmann
2021-10-19 15:42 ` [PATCH 3/3] cpuidle: qcom: " Arnd Bergmann
2021-10-20  4:24 ` [PATCH 1/3] qcom: spm: allow compile-testing Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.